dohertj2/lmxopcua
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Heidenhain: CSV import preview doesn't flag ReadWrite / data-type mismatches (only Commit refuses) #830

New Issue
Closed
opened 2026-11-11 00:06:00 -05:00 by dohertj2 · 2 comments
dohertj2 commented 2026-11-11 00:06:00 -05:00
Owner
Copy Link
Copy Source

From #803. The CSV import staged review grid validates only TagConfig, so a ReadWrite or mistyped Heidenhain row is refused at Commit (all-or-nothing, rows named) rather than shown in the preview. Surface the same save-path rules in the preview.

From #803. The CSV import staged review grid validates only TagConfig, so a ReadWrite or mistyped Heidenhain row is refused at Commit (all-or-nothing, rows named) rather than shown in the preview. Surface the same save-path rules in the preview.
dohertj2 added the type:followuppriority:p3 labels 2026-11-11 00:06:00 -05:00
dohertj2 commented 2026-11-11 00:48:15 -05:00
Author
Owner
Copy Link
Copy Source

Additional authoring UX from the #803 live gate (5bbe1e3c): the manual-entry grid still lets you pick a data type that is silently replaced on commit (picked Int32 for Axes/Positions, Double saved); the CSV review grid marks ReadWrite / mismatched rows "OK" (refused only at commit); the driver modal shows the credential error twice (form + save check).

Additional authoring UX from the #803 live gate (5bbe1e3c): the manual-entry grid still lets you pick a data type that is silently replaced on commit (picked Int32 for `Axes/Positions`, Double saved); the CSV review grid marks ReadWrite / mismatched rows "OK" (refused only at commit); the driver modal shows the credential error twice (form + save check).
dohertj2 commented 2026-11-11 05:24:34 -05:00
Author
Owner
Copy Link
Copy Source

Fixed (d3285af6). Pushed to master in d1b6cad2. Heidenhain CSV import preview flags ReadWrite and data-type mismatches before commit; invalid rows show their CSV name (#847).

Fixed (`d3285af6`). Pushed to master in `d1b6cad2`. Heidenhain CSV import preview flags ReadWrite and data-type mismatches before commit; invalid rows show their CSV name (#847).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 blocked
Blocked by dependency or external hold
 cross-driver
queue management
 cross-repo
Needs coordinated change in another family repo (wire contract etc.)
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 migrated
Migrated from a markdown backlog (2026-11 standardization)
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 priority:p0
Must-have / blocking
 priority:p1
High priority
 priority:p2
Normal priority
 priority:p3
Low priority / nice to have
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
 type:bug
Defect in shipped behaviour
 type:debt
Technical debt / hygiene
 type:deploy-gate
Rollout/deploy/migration step not yet done on an environment
 type:docs
Documentation work
 type:feature
Feature implementation
 type:followup
Follow-up deferred from a plan, PR or gate
 type:infra
Infrastructure and scaffolding
 type:review-finding
Unfixed finding from an architecture/code review
 type:test
Test work
No Label priority:p3 type:followup
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?