dohertj2/lmxopcua
1
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects Releases Wiki Activity

Review remediation: Lane Modbus #741

New Issue
Open
opened 2026-10-22 06:05:19 -04:00 by dohertj2 · 0 comments
dohertj2 commented 2026-10-22 06:05:19 -04:00
Owner
Copy Link
Copy Source

From the 2026-10-21 Fable system review. Findings R0x:ID refer to docs/reviews/2026-10-21/0x-*.md (location, evidence, failure scenario, fix recipe). Plan: docs/superpowers/plans/2026-10-22-review-remediation.md.

Lane Modbus

  • Deadband baselines on (value,status) (R07:H2).
  • Transport self-heals with a throttled in-gate connect (P3).
  • Dispose the failed TcpClient, one in-gate attempt, DNS under the timeout (L3).
  • Wire Family/MelsecSubFamily/DisableFC23 (U1): the editor + factory route the address through ModbusAddressParser and persist the resolved region/offset; DisableFC23 gates multi-write.
  • Coalescing on by default (gap 8), plus coils/DI/BitInRegister folding (U2).
  • String[]/BitInRegister[] writes (U3).
  • Region/type validation at the factory (P6).
  • Exception codes 01/02/03 are refusals (H4).
  • Write status mapping (H7); PDU length check (H9).
From the 2026-10-21 Fable system review. Findings `R0x:ID` refer to `docs/reviews/2026-10-21/0x-*.md` (location, evidence, failure scenario, fix recipe). Plan: `docs/superpowers/plans/2026-10-22-review-remediation.md`. ### Lane Modbus - Deadband baselines on `(value,status)` (`R07:H2`). - Transport self-heals with a throttled in-gate connect (`P3`). - Dispose the failed `TcpClient`, one in-gate attempt, DNS under the timeout (`L3`). - **Wire Family/MelsecSubFamily/DisableFC23** (`U1`): the editor + factory route the address through `ModbusAddressParser` and persist the resolved region/offset; `DisableFC23` gates multi-write. - Coalescing on by default (gap 8), plus coils/DI/BitInRegister folding (`U2`). - String[]/BitInRegister[] writes (`U3`). - Region/type validation at the factory (`P6`). - Exception codes 01/02/03 are refusals (`H4`). - Write status mapping (`H7`); PDU length check (`H9`).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#741
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?