Ensure driver test cleanup preserves primary failures #730

2026-10-13T19:04:08-04:00

dohertj2 commented

2026-10-13 19:04:08 -04:00

Six driver test fixtures could leave their owned probes/resources running when initialization or assertions failed; two also omitted normal-path shutdown. Wrap those bodies in one linked test-only cleanup operation, registered before initialization. It awaits shutdown, preserves the original failure and stack, reports a secondary cleanup failure, and fails on cleanup-only errors. Existing behavioral assertions, probe settings, tokens and deadlines remain intact.

Also explicitly discard five Task-valued ShouldNotBeNull results, preserving their synchronous checks and running-probe assertions. No production or dependency changes. #725 remains open for the remaining warning groups.

Validation: six offline project suites passed 3,323 tests with zero failed/skipped; helper contract tests failed 5/5 with a body-only stub then passed 5/5; removing cleanup made the new real-driver/fake-resource regressions fail in every affected project. Independent scope/quality review passed, and all original assertion lines were retained. Modbus evidence establishes cancellation, fake request completion and transport disposal, not a background probe-task join. Several other drivers have bounded joins; completion is demonstrated only in these fake scenarios. Existing test warnings remain.

Refs #725.
Resolves #726.

Merged main c89912a9 is integrated without conflicts; the resulting tree matches the reviewed integration preflight. Required hosted run988 passed all ten steps on final head4f537a5652eec807ccdc020c7b3ab08a6435fdaf:62TRX reports,14,672executed tests,573individual skips, floor>=12,000 and finalized artifacts. All six affected suites passed3,323/0fail/0skip; completed build emitted zero CS4014 warnings.

Six driver test fixtures could leave their owned probes/resources running when initialization or assertions failed; two also omitted normal-path shutdown. Wrap those bodies in one linked test-only cleanup operation, registered before initialization. It awaits shutdown, preserves the original failure and stack, reports a secondary cleanup failure, and fails on cleanup-only errors. Existing behavioral assertions, probe settings, tokens and deadlines remain intact. Also explicitly discard five Task-valued ShouldNotBeNull results, preserving their synchronous checks and running-probe assertions. No production or dependency changes. #725 remains open for the remaining warning groups. Validation: six offline project suites passed 3,323 tests with zero failed/skipped; helper contract tests failed 5/5 with a body-only stub then passed 5/5; removing cleanup made the new real-driver/fake-resource regressions fail in every affected project. Independent scope/quality review passed, and all original assertion lines were retained. Modbus evidence establishes cancellation, fake request completion and transport disposal, not a background probe-task join. Several other drivers have bounded joins; completion is demonstrated only in these fake scenarios. Existing test warnings remain. Refs #725. Resolves #726. Merged main c89912a9 is integrated without conflicts; the resulting tree matches the reviewed integration preflight. Required hosted run988 passed all ten steps on final head4f537a5652eec807ccdc020c7b3ab08a6435fdaf:62TRX reports,14,672executed tests,573individual skips, floor>=12,000 and finalized artifacts. All six affected suites passed3,323/0fail/0skip; completed build emitted zero CS4014 warnings.

dohertj2 added 3 commits 2026-10-13 19:04:09 -04:00

Discard asserted probe-task return values without joining loops 5310a7e07a

test: guarantee driver fixture cleanup without masking failures eed7cc7d75

Merge remote-tracking branch 'origin/master' into test/task-assertion-return-discard

v2-ci / unit-tests (pull_request) Successful in 1h1m9s

Details

4f537a5652

dohertj2 referenced this pull request

2026-10-13 19:05:15 -04:00

Driver test fixtures leave owned probe loops without guaranteed teardown #726

dohertj2 referenced this pull request

2026-10-13 19:05:15 -04:00