dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(historian): preserve alarm delivery identity across retries #706

Merged
dohertj2 merged 1 commits from fix/alarm-delivery-identity into master 2026-10-13 07:11:12 -04:00
Conversation 0 Commits 1 Files Changed 13
+341 -27
dohertj2 commented 2026-10-13 07:11:00 -04:00
Owner
Copy Link
Copy Source

AlarmEventMapper left the wire ID empty because it assumed the historian supplied identity. Events now carry a nonzero transport GUID; direct retries/copies retain it, and durable deliveries derive it solely from the persisted queue key. Queue JSON/fingerprints/schema/deduplication, business equality/hash and AlarmId stay unchanged. Explicit empty IDs are rejected; SQL/QuestDB identity logic is unchanged.

Validation: RED empty wire ID and unstable queue retry IDs reproduced; Core51/51, migration/convergence16/16, Gateway453passed/6live skipped; full offline solution14,635passed/611skipped/0failed across62suites, exit0. Literal fixtures and retry/reopen/replication/legacy/revival tests included. Independent review and diffcheck clear.

No live writes or deployment. Live exact-ID persistence and timestamps remain Gateway #28/#39; no historical rows rewritten. Results: docs/plans/2026-10-13-alarm-delivery-identity-results.md.

Fixes #705.

AlarmEventMapper left the wire ID empty because it assumed the historian supplied identity. Events now carry a nonzero transport GUID; direct retries/copies retain it, and durable deliveries derive it solely from the persisted queue key. Queue JSON/fingerprints/schema/deduplication, business equality/hash and AlarmId stay unchanged. Explicit empty IDs are rejected; SQL/QuestDB identity logic is unchanged. Validation: RED empty wire ID and unstable queue retry IDs reproduced; Core51/51, migration/convergence16/16, Gateway453passed/6live skipped; full offline solution14,635passed/611skipped/0failed across62suites, exit0. Literal fixtures and retry/reopen/replication/legacy/revival tests included. Independent review and diffcheck clear. No live writes or deployment. Live exact-ID persistence and timestamps remain Gateway #28/#39; no historical rows rewritten. Results: docs/plans/2026-10-13-alarm-delivery-identity-results.md. Fixes #705.
dohertj2 added 1 commit 2026-10-13 07:11:01 -04:00
fix(historian): preserve stable alarm delivery identities
v2-ci / build (pull_request) Successful in 5m52s
Details
v2-ci / unit-tests (pull_request) Failing after 1h23m55s
Details
109163621c
dohertj2 merged commit 7b23875070 into master 2026-10-13 07:11:12 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#706
Delete Branch "fix/alarm-delivery-identity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?