dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Accept supported definitive loss reasons in restart wire test #704

Merged
dohertj2 merged 1 commits from fix/restart-loss-reason into master 2026-10-13 06:30:24 -04:00
Conversation 0 Commits 1 Files Changed 2
+25 -6
dohertj2 commented 2026-10-13 06:30:10 -04:00
Owner
Copy Link
Copy Source

The restart wire test intermittently rejected a valid BadSessionIdInvalid notification because it required BadServerHalted. Accept the explicit supported definitive-loss reason set; retain every outage, value-retention, frozen-stamp, notification-count and explicit recovery assertion. Production behavior is unchanged. Existing deterministic tests independently enforce each direct status and the sustained closed-channel gate.

Validation: captured original reason mismatch under full integration121pass/1fail; corrected isolated1/1, deterministic routes30/30, full integration122/122; full offline solution14,613 passed /611 skipped /zero failed, exit0. Independent review clear; diff check passed. Host fixture/environment-dependent skips remain recorded. Results: docs/plans/2026-10-13-restart-loss-reason-results.md.

Fixes #702.

The restart wire test intermittently rejected a valid BadSessionIdInvalid notification because it required BadServerHalted. Accept the explicit supported definitive-loss reason set; retain every outage, value-retention, frozen-stamp, notification-count and explicit recovery assertion. Production behavior is unchanged. Existing deterministic tests independently enforce each direct status and the sustained closed-channel gate. Validation: captured original reason mismatch under full integration121pass/1fail; corrected isolated1/1, deterministic routes30/30, full integration122/122; full offline solution14,613 passed /611 skipped /zero failed, exit0. Independent review clear; diff check passed. Host fixture/environment-dependent skips remain recorded. Results: docs/plans/2026-10-13-restart-loss-reason-results.md. Fixes #702.
dohertj2 added 1 commit 2026-10-13 06:30:12 -04:00
test: accept definitive session loss reasons during restart
v2-ci / build (pull_request) Successful in 12m16s
Details
v2-ci / unit-tests (pull_request) Failing after 3h13m34s
Details
dccab57d39
dohertj2 merged commit 0ccfbbee5c into master 2026-10-13 06:30:24 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#704
Delete Branch "fix/restart-loss-reason"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?