dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Galaxy reconnect snapshot: ActiveAcked entry for an unknown condition lands inactive; re-statements write duplicate Activated rows #656

New Issue
Closed
opened 2026-10-08 20:51:50 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 20:51:50 -04:00
Owner
Copy Link
Copy Source

Residuals noted in the #647 reviews (batch b647), pre-existing, out of that lane:

  1. After a process restart, a Galaxy reconnect-snapshot entry that is Active and already acknowledged maps to Acknowledge only. On a condition the host has no prior record of, that leaves it inactive+acked instead of Active+acked.
  2. OpcUaClient and the Galaxy snapshot re-stating a condition that is already Active and unacked send Retrigger, which writes a second 'Activated' /alerts row (the old Raise did the same).
    Fix direction: map ActiveAcked-on-unknown to Raise+Acknowledge (or a combined transition the projector understands), and let the projector treat a Retrigger with an unchanged message on an Active+unacked condition as a re-statement for history purposes.
Residuals noted in the #647 reviews (batch b647), pre-existing, out of that lane: 1. After a process restart, a Galaxy reconnect-snapshot entry that is Active **and already acknowledged** maps to `Acknowledge` only. On a condition the host has no prior record of, that leaves it inactive+acked instead of Active+acked. 2. OpcUaClient and the Galaxy snapshot re-stating a condition that is already Active and **unacked** send Retrigger, which writes a second 'Activated' /alerts row (the old Raise did the same). Fix direction: map ActiveAcked-on-unknown to Raise+Acknowledge (or a combined transition the projector understands), and let the projector treat a Retrigger with an unchanged message on an Active+unacked condition as a re-statement for history purposes.
dohertj2 commented 2026-10-09 04:55:26 -04:00
Author
Owner
Copy Link
Copy Source

Fixed on master — merge 82750ccc (lane commit e138e397 + predecessor), pushed 2026-10-09.

  • New atomic AlarmTransitionKind.ActiveAcknowledged (one projector update, one client event, /alerts rows only for what changed) — Galaxy snapshot ActiveAcked and OpcUaClient inactive→acked-active. A cold host's ActiveAcked entry now lands Active.
  • New optional AlarmEventArgs.IsRestatement (Galaxy snapshot entries, OpcUaClient first sight): a flagged Retrigger on an Active+unacked condition with the same message and severity, or a flagged Clear on an inactive condition, writes no row. NativeAlarmProjector returns the rows to write; FOCAS/MTConnect/AbCip unaffected. E2E: Runtime.Tests/NativeAlarmRestatementEndToEndTests.

Live check (docker-dev + opc-plc), reusable for #657:

  1. ssh dohertj2@10.100.0.35 'cd /opt/otopcua-opcuaclient && docker compose up -d' (bring it down again after).
  2. Insert raw tag MAIN-opcua-alarm1 on the MAIN OpcUaClient driver with TagConfig {"nodeId":"ns=6;s=1:Colours/NorthMotor?Red","alarm":{"alarmType":"AlarmCondition","severity":500}}, deploy (docker-dev/deploy.sh < /dev/null). That condition is permanently Active+unacked and alternates its message every few seconds.
  3. Force respawns: UPDATE dbo.DriverInstance SET DriverConfig = JSON_MODIFY(DriverConfig,'$.hw3RespawnToggle',N) + deploy, every ~15 s (logs: stopped driver child MAIN-opcua → spawned → connected).
  4. Watch AdminUI /alerts: a duplicate re-statement is a row identical in timestamp/severity/message to the one before it.

Result: pre-fix image 4/4 respawns wrote a duplicate "Activated" row; post-fix 0/6. Revert the tag/toggle afterwards.

Follow-up found in review: #657 (respawn replays inactive+unacked as Raise+Clear).

Fixed on master — merge `82750ccc` (lane commit `e138e397` + predecessor), pushed 2026-10-09. - New atomic `AlarmTransitionKind.ActiveAcknowledged` (one projector update, one client event, `/alerts` rows only for what changed) — Galaxy snapshot `ActiveAcked` and OpcUaClient inactive→acked-active. A cold host's ActiveAcked entry now lands Active. - New optional `AlarmEventArgs.IsRestatement` (Galaxy snapshot entries, OpcUaClient first sight): a flagged Retrigger on an Active+unacked condition with the same message and severity, or a flagged Clear on an inactive condition, writes no row. `NativeAlarmProjector` returns the rows to write; FOCAS/MTConnect/AbCip unaffected. E2E: `Runtime.Tests/NativeAlarmRestatementEndToEndTests`. **Live check (docker-dev + opc-plc), reusable for #657:** 1. `ssh dohertj2@10.100.0.35 'cd /opt/otopcua-opcuaclient && docker compose up -d'` (bring it down again after). 2. Insert raw tag `MAIN-opcua-alarm1` on the MAIN OpcUaClient driver with TagConfig `{"nodeId":"ns=6;s=1:Colours/NorthMotor?Red","alarm":{"alarmType":"AlarmCondition","severity":500}}`, deploy (`docker-dev/deploy.sh < /dev/null`). That condition is permanently Active+unacked and alternates its message every few seconds. 3. Force respawns: `UPDATE dbo.DriverInstance SET DriverConfig = JSON_MODIFY(DriverConfig,'$.hw3RespawnToggle',N)` + deploy, every ~15 s (logs: `stopped driver child MAIN-opcua` → `spawned` → `connected`). 4. Watch AdminUI `/alerts`: a duplicate re-statement is a row identical in timestamp/severity/message to the one before it. Result: pre-fix image 4/4 respawns wrote a duplicate "Activated" row; post-fix 0/6. Revert the tag/toggle afterwards. Follow-up found in review: #657 (respawn replays inactive+unacked as Raise+Clear).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?