dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

OpcUaClient: HistoryRead ignores per-node StatusCode (BadAggregateNotSupported looks like empty data) #649

New Issue
Closed
opened 2026-10-08 18:51:36 -04:00 by dohertj2 · 2 comments
dohertj2 commented 2026-10-08 18:51:36 -04:00
Owner
Copy Link
Copy Source

Found during #622. OpcUaClientDriver.ExecuteHistoryReadAsync (~lines 1982-2003) never checks r.StatusCode on the per-node HistoryReadResult, so a Processed read the upstream server rejects (e.g. BadAggregateNotSupported) is surfaced as empty data instead of the status. Test OpcUaClientDriverHistoryWireTests pins the current behaviour and must be updated with the fix.

Found during #622. OpcUaClientDriver.ExecuteHistoryReadAsync (~lines 1982-2003) never checks r.StatusCode on the per-node HistoryReadResult, so a Processed read the upstream server rejects (e.g. BadAggregateNotSupported) is surfaced as empty data instead of the status. Test OpcUaClientDriverHistoryWireTests pins the current behaviour and must be updated with the fix.
dohertj2 added the driver/opcuaclient label 2026-10-08 18:51:36 -04:00
dohertj2 commented 2026-10-08 20:50:23 -04:00
Author
Owner
Copy Link
Copy Source

Fixed on master (22e79112 + b8c21367, merged 83ab1234). ExecuteHistoryReadAsync now checks each node's StatusCode (CodeBits): BadAggregateNotSupported → HistoryAggregateNotSupportedException; any other Bad → new HistoryReadStatusException (rejects non-Bad codes) relayed verbatim for that node only by ServeNodeAsync / ServeRawPagedAsync; node-level BadNoData stays an empty result. Wire tests cover Processed, Raw paging (resume read throws, sibling stays Good, no stray cursor) and BadNoData; each goes red when its fix is reverted.

⚠️ Latent in production: review found the server never dispatches HistoryRead to a driver's IHistoryProvider (only the server-wide historian source), so no client sees this today. Filed separately.

Fixed on master (`22e79112` + `b8c21367`, merged `83ab1234`). `ExecuteHistoryReadAsync` now checks each node's StatusCode (CodeBits): `BadAggregateNotSupported` → `HistoryAggregateNotSupportedException`; any other Bad → new `HistoryReadStatusException` (rejects non-Bad codes) relayed verbatim for that node only by `ServeNodeAsync` / `ServeRawPagedAsync`; node-level `BadNoData` stays an empty result. Wire tests cover Processed, Raw paging (resume read throws, sibling stays Good, no stray cursor) and BadNoData; each goes red when its fix is reverted. ⚠️ **Latent in production:** review found the server never dispatches HistoryRead to a driver's `IHistoryProvider` (only the server-wide historian source), so no client sees this today. Filed separately.
dohertj2 commented 2026-10-08 20:51:57 -04:00
Author
Owner
Copy Link
Copy Source

Follow-up for the production-reachability gap: #655.

Follow-up for the production-reachability gap: #655.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/opcuaclient
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#649
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?