dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Re-triage the 11 Deferred code-review findings and the Sql TODO(M2) #625

New Issue
Closed
opened 2026-10-08 02:31:17 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:17 -04:00
Owner
Copy Link
Copy Source

Thirteen findings carry Status Deferred with no tracking (2 in retired Wonderware modules → 11 live); the README index counts them as resolved-equivalent.
Sources: code-reviews/{Cluster-002, Commons-002, Driver.Galaxy-017, Driver.OpcUaClient.Browser-002, Driver.OpcUaClient.Contracts-002, Driver.S7.Cli-012, Driver.S7.Contracts-003, OpcUaServer-003, Runtime-001}/findings.md; src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Sql/SqlDriver.cs:1129.

  • Runtime-001 (Medium, folder-rename semantics, tied to OpcUaServer-001): superseded by surgical deploys?
  • Port ComputeVerdict to the S7 CLI probe (S7.Cli-012)
  • OpcUaServer-003: HistoryRead endUtc inclusive vs exclusive
  • Close or fix the remaining Lows
  • Hoist the duplicated Detach helper (SqlDriver + SqlPollReader, TODO(M2))

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

Thirteen findings carry Status Deferred with no tracking (2 in retired Wonderware modules → 11 live); the README index counts them as resolved-equivalent. Sources: code-reviews/{Cluster-002, Commons-002, Driver.Galaxy-017, Driver.OpcUaClient.Browser-002, Driver.OpcUaClient.Contracts-002, Driver.S7.Cli-012, Driver.S7.Contracts-003, OpcUaServer-003, Runtime-001}/findings.md; src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Sql/SqlDriver.cs:1129. - [ ] Runtime-001 (Medium, folder-rename semantics, tied to OpcUaServer-001): superseded by surgical deploys? - [ ] Port `ComputeVerdict` to the S7 CLI probe (S7.Cli-012) - [ ] OpcUaServer-003: HistoryRead `endUtc` inclusive vs exclusive - [ ] Close or fix the remaining Lows - [ ] Hoist the duplicated `Detach` helper (`SqlDriver` + `SqlPollReader`, `TODO(M2)`) _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 commented 2026-10-08 09:24:36 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (3fb65492, merge 75c66c16).

  • Runtime-001 (folder-rename semantics): Resolved, verified closed by OpcUaServer-001 (the planner now diffs UnsArea/UnsLine renames, so a display-name-only rename is no longer IsEmpty).
  • S7.Cli-012: `ProbeCommand` now ports ComputeVerdict (`ProbeCommandTests`).
  • OpcUaServer-003 (HistoryRead endUtc inclusive vs exclusive): Won't Fix, accepted by design (inclusive chain is the conservative side of the exclusive backend contract; worst case one extra empty resume page, never a dropped or duplicated sample); recorded in the finding.
  • Remaining Lows closed or ruled: Cluster-002 (MemberLeft/Exited/Downed handled; `ClusterRoleInfoMemberEventTests`), Driver.OpcUaClient.Browser-002 (continuation-point release; `OpcUaClientBrowseSessionPaginationTests`), Driver.Galaxy-017 (Won't Fix: needs a gateway-side GetVersion RPC owned by mxaccessgw), plus the Commons/Contracts findings. code-reviews/README.md counts regenerated.
  • The duplicated Detach helper hoisted into `AbandonedTask` (SqlDriver + SqlPollReader); TODO(M2) removed.
  • Not touched: Driver.FOCAS-014 (bench-CNC gated, not in this issue's list) and the two retired Wonderware modules stay Deferred.

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (3fb65492, merge 75c66c16). - [x] Runtime-001 (folder-rename semantics): Resolved, verified closed by OpcUaServer-001 (the planner now diffs UnsArea/UnsLine renames, so a display-name-only rename is no longer IsEmpty). - [x] S7.Cli-012: \`ProbeCommand\` now ports ComputeVerdict (\`ProbeCommandTests\`). - [x] OpcUaServer-003 (HistoryRead endUtc inclusive vs exclusive): Won't Fix, accepted by design (inclusive chain is the conservative side of the exclusive backend contract; worst case one extra empty resume page, never a dropped or duplicated sample); recorded in the finding. - [x] Remaining Lows closed or ruled: Cluster-002 (MemberLeft/Exited/Downed handled; \`ClusterRoleInfoMemberEventTests\`), Driver.OpcUaClient.Browser-002 (continuation-point release; \`OpcUaClientBrowseSessionPaginationTests\`), Driver.Galaxy-017 (Won't Fix: needs a gateway-side GetVersion RPC owned by mxaccessgw), plus the Commons/Contracts findings. code-reviews/README.md counts regenerated. - [x] The duplicated Detach helper hoisted into \`AbandonedTask\` (SqlDriver + SqlPollReader); TODO(M2) removed. - Not touched: Driver.FOCAS-014 (bench-CNC gated, not in this issue's list) and the two retired Wonderware modules stay Deferred. *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#625
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?