dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Server: array writes; decide ValueRank > 1 #610

New Issue
Closed
opened 2026-10-08 02:31:13 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:13 -04:00
Owner
Copy Link
Copy Source

The applier forces every array tag read-only ("array writes are out of scope") although Modbus has array/coil-array write paths; multi-dimensional arrays unsupported.
Sources: docs/Uns.md:317-318; AddressSpaceApplier.cs:898,1046; S7Driver.cs:467,1807; code-reviews/Driver.S7/findings.md (S7-016, Deferred).

  • Lift forced read-only for drivers that implement array writes; OPC UA array-write path test
  • S7 array writes + AdminUI/DTO field (S7-016)
  • Decide whether ValueRank > 1 is in scope

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

The applier forces every array tag read-only ("array writes are out of scope") although Modbus has array/coil-array write paths; multi-dimensional arrays unsupported. Sources: docs/Uns.md:317-318; AddressSpaceApplier.cs:898,1046; S7Driver.cs:467,1807; code-reviews/Driver.S7/findings.md (S7-016, Deferred). - [ ] Lift forced read-only for drivers that implement array writes; OPC UA array-write path test - [ ] S7 array writes + AdminUI/DTO field (S7-016) - [ ] Decide whether ValueRank > 1 is in scope _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 added the driver/s7 label 2026-10-08 02:31:13 -04:00
dohertj2 commented 2026-10-08 09:24:34 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (merge b7a48e2b; reviews R4 a702875d and R6 31346f1e).

  • Forced read-only lifted for drivers that implement array writes: DriverArrayWriteSupport capability gates it per driver (18f8eb5d); ArrayWritable added to the surgical whitelist and the UNS Backing mirror. Shape and IndexRange refusals, over-the-wire test coverage. Review hardening: exact element-type match (BadTypeMismatch, nothing sent) and Modbus writability bounded by the register/coil cap (dabd8eb9); numeric arrays then converted element-wise (checked) so ScadaBridge CLR-list writes work, refusing out-of-range/fractional/NaN, with the array-to-scalar refusal scoped to Modbus/S7 (52708bff). The Galaxy encoder refuses uint[]/ulong[]; Galaxy arrays without a declared length stay read-only.
  • S7 array writes (contiguous block write; writable Bool arrays refused) and author-time validation in S7TagConfigModel (82372f16, 439752d3); the DTO half of S7-016 was already stale. S7-016 note updated.
  • ValueRank > 1: out of scope by decision, documented in docs/Uns.md.

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (merge b7a48e2b; reviews R4 a702875d and R6 31346f1e). - [x] Forced read-only lifted for drivers that implement array writes: `DriverArrayWriteSupport` capability gates it per driver (18f8eb5d); `ArrayWritable` added to the surgical whitelist and the UNS Backing mirror. Shape and IndexRange refusals, over-the-wire test coverage. Review hardening: exact element-type match (BadTypeMismatch, nothing sent) and Modbus writability bounded by the register/coil cap (dabd8eb9); numeric arrays then converted element-wise (checked) so ScadaBridge CLR-list writes work, refusing out-of-range/fractional/NaN, with the array-to-scalar refusal scoped to Modbus/S7 (52708bff). The Galaxy encoder refuses uint[]/ulong[]; Galaxy arrays without a declared length stay read-only. - [x] S7 array writes (contiguous block write; writable Bool arrays refused) and author-time validation in `S7TagConfigModel` (82372f16, 439752d3); the DTO half of S7-016 was already stale. S7-016 note updated. - [x] ValueRank > 1: **out of scope by decision**, documented in docs/Uns.md. *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/s7
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?