dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Galaxy gateway seam hardening (archreview r3 item 11) #605

New Issue
Closed
opened 2026-10-08 02:31:12 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:12 -04:00
Owner
Copy Link
Copy Source

A thrown (vs non-Ok) AdviseSupervisory leaves the handle marked supervised, so later writes skip the advise forever (06/S-12).
Sources: archreview/00-OVERALL.md:122 (06/S-12, S-6, S-13, S-3).

  • try/catch the advise; TryRemove on any failure
  • Wire or delete the historian health snapshot, with a registration guard (S-6)
  • Log + record the losing RawPath on a duplicate attributeRef (S-13)
  • Internal deadline on ReadViaSubscribeOnceAsync (S-3)

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

A thrown (vs non-Ok) `AdviseSupervisory` leaves the handle marked supervised, so later writes skip the advise forever (06/S-12). Sources: archreview/00-OVERALL.md:122 (06/S-12, S-6, S-13, S-3). - [ ] try/catch the advise; `TryRemove` on any failure - [ ] Wire or delete the historian health snapshot, with a registration guard (S-6) - [ ] Log + record the losing RawPath on a duplicate attributeRef (S-13) - [ ] Internal deadline on `ReadViaSubscribeOnceAsync` (S-3) _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 commented 2026-10-08 09:24:32 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (7c4c7f96, merge ba3d8828).

  • AdviseSupervisory throw: the handle is unmarked on any failure (GatewayGalaxyDataWriterFailClosedTests).
  • Historian health snapshot: the dormant connection probe was deleted and health is derived instead (GatewayHealthSnapshotTests).
  • Duplicate attributeRef: logged and the losing RawPath recorded (GalaxyDriverRawPathKeyingTests).
  • ReadViaSubscribeOnceAsync has an internal deadline; the R2 review also made it return BadTimeout (e77bca38). Review fix: OperationCanceled when SubscribeBulk is pending.

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (7c4c7f96, merge ba3d8828). - [x] AdviseSupervisory throw: the handle is unmarked on any failure (`GatewayGalaxyDataWriterFailClosedTests`). - [x] Historian health snapshot: the dormant connection probe was deleted and health is derived instead (`GatewayHealthSnapshotTests`). - [x] Duplicate attributeRef: logged and the losing RawPath recorded (`GalaxyDriverRawPathKeyingTests`). - [x] `ReadViaSubscribeOnceAsync` has an internal deadline; the R2 review also made it return BadTimeout (e77bca38). Review fix: OperationCanceled when SubscribeBulk is pending. *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?