dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AdminUI N−1 sweep: stale-open guard on 5 modals, ValidationSummary, API-key delete confirm, ErrorBoundary (archreview r3 item 10) #604

New Issue
Closed
opened 2026-10-08 02:31:11 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:11 -04:00
Owner
Copy Link
Copy Source

Only RawBrowseModal and RawManualTagEntryModal carry _openGeneration; worst case is a CSV import committing to the wrong device.
Sources: archreview/00-OVERALL.md:121 (04/S-8, S-9, S-5, S-3).

  • Port the guard to the five unguarded modals, CSV import first
  • ValidationSummary on the three silent EditForms + reflection guard (the #505 class)
  • Confirm dialog on API-key Delete
  • ErrorBoundary around @Body
  • Live-verify on docker-dev (no bUnit)

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

Only `RawBrowseModal` and `RawManualTagEntryModal` carry `_openGeneration`; worst case is a CSV import committing to the wrong device. Sources: archreview/00-OVERALL.md:121 (04/S-8, S-9, S-5, S-3). - [ ] Port the guard to the five unguarded modals, CSV import first - [ ] `ValidationSummary` on the three silent EditForms + reflection guard (the #505 class) - [ ] Confirm dialog on API-key Delete - [ ] `ErrorBoundary` around `@Body` - [ ] Live-verify on docker-dev (no bUnit) _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 commented 2026-10-08 09:24:32 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (d3bca7af, merge db10e9d2; review R3 1475991f, merge 85491f1e).

  • Stale-open (_openGeneration) guard ported to the five unguarded modals, CSV import first.
  • ValidationSummary on the silent EditForms, with AdminUiFormSweepGuardTests as the reflection guard.
  • Confirm dialog on API-key Delete.
  • ErrorBoundary around @Body, moved to a per-page interactive boundary in R3 (PageErrorBoundaryTests); a CSV commit now refreshes after the modal closes.
  • Live-verified on docker-dev at a702875d: ValidationSummary on /clusters/new, /clusters/MAIN/edit, /scripts/{id}; /raw driver and device modals, CSV import and tag delete; API-key delete Cancel keeps / Delete removes; Add-reference picker is cluster-scoped. A SQL-paused save shows the handled timeout banner (no circuit death). The boundary has no live trip path without fault injection, so it is covered by unit tests only. CSV export skipped (browser download).
  • Two cosmetics found in the pass are filed separately.

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (d3bca7af, merge db10e9d2; review R3 1475991f, merge 85491f1e). - [x] Stale-open (`_openGeneration`) guard ported to the five unguarded modals, CSV import first. - [x] `ValidationSummary` on the silent EditForms, with `AdminUiFormSweepGuardTests` as the reflection guard. - [x] Confirm dialog on API-key Delete. - [x] ErrorBoundary around `@Body`, moved to a per-page interactive boundary in R3 (`PageErrorBoundaryTests`); a CSV commit now refreshes after the modal closes. - [x] Live-verified on docker-dev at a702875d: ValidationSummary on /clusters/new, /clusters/MAIN/edit, /scripts/{id}; /raw driver and device modals, CSV import and tag delete; API-key delete Cancel keeps / Delete removes; Add-reference picker is cluster-scoped. A SQL-paused save shows the handled timeout banner (no circuit death). The boundary has no live trip path without fault injection, so it is covered by unit tests only. CSV export skipped (browser download). - Two cosmetics found in the pass are filed separately. *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?