dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Dormant Core.VirtualTags engine decision, ScriptSandbox reference caching, single drain-gate predicate (archreview r3 item 9) #603

New Issue
Closed
opened 2026-10-08 02:31:11 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-08 02:31:11 -04:00
Owner
Copy Link
Copy Source

Oldest open Highs. ~1,100-line Core.VirtualTags engine dormant with no retire/sanction decision; ScriptSandbox.Build rebuilds the BCL reference set every compile; the alarm drain gate's "replicated" test (PeerAddress || SyncListenPort) disagrees with LocalDb's (PeerAddress || ApiKey).
Sources: archreview/00-OVERALL.md:120 (02/U1, 02/P1, 02/S15); src/Server/ZB.MOM.WW.OtOpcUa.Runtime/ServiceCollectionExtensions.cs:180-185 vs LocalDbSetup.ReplicationIsConfigured.

  • Decide the engine (retiring closes 02/S1, S10, half of S3, C1, U7-b)
  • Cache the sandbox reference set statically
  • Use ReplicationIsConfigured as the single predicate

Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep.

Oldest open Highs. ~1,100-line `Core.VirtualTags` engine dormant with no retire/sanction decision; `ScriptSandbox.Build` rebuilds the BCL reference set every compile; the alarm drain gate's "replicated" test (`PeerAddress || SyncListenPort`) disagrees with LocalDb's (`PeerAddress || ApiKey`). Sources: archreview/00-OVERALL.md:120 (02/U1, 02/P1, 02/S15); src/Server/ZB.MOM.WW.OtOpcUa.Runtime/ServiceCollectionExtensions.cs:180-185 vs `LocalDbSetup.ReplicationIsConfigured`. - [ ] Decide the engine (retiring closes 02/S1, S10, half of S3, C1, U7-b) - [ ] Cache the sandbox reference set statically - [ ] Use `ReplicationIsConfigured` as the single predicate _Filed 2026-10-08 by the pending/deferred-work sweep after the #562–#591 issue sweep._
dohertj2 commented 2026-10-08 09:24:31 -04:00
Author
Owner
Copy Link
Copy Source

Resolved on master (merge e9e35baa).

  • Engine decision: retired. VirtualTagEngine/Source/Definition and TimerTriggerScheduler deleted (a8703c6a); the scheduler was welded to the engine and had no production consumer.
  • ScriptSandbox now caches the BCL + pinned metadata references statically (1b37b2f2).
  • The alarm drain gate and table registration share LocalDbSetup.ReplicationIsConfigured (PeerAddress || ApiKey) (4f6231fa). Behaviour change noted in review: a node with only a SyncListenPort is no longer gated (it shares nothing, fail-closed), and an ApiKey-only passive node now is. The passive half of a pair was further drain-gated on its mesh partner in 3be8a121 (review R6, merge 31346f1e).

Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).

Resolved on master (merge e9e35baa). - [x] Engine decision: **retired**. `VirtualTagEngine`/Source/Definition and `TimerTriggerScheduler` deleted (a8703c6a); the scheduler was welded to the engine and had no production consumer. - [x] `ScriptSandbox` now caches the BCL + pinned metadata references statically (1b37b2f2). - [x] The alarm drain gate and table registration share `LocalDbSetup.ReplicationIsConfigured` (PeerAddress || ApiKey) (4f6231fa). Behaviour change noted in review: a node with only a SyncListenPort is no longer gated (it shares nothing, fail-closed), and an ApiKey-only passive node now is. The passive half of a pair was further drain-gated on its mesh partner in 3be8a121 (review R6, merge 31346f1e). *Closed 2026-10-08 by the hardware-available issue sweep (master d898262c).*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?