dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AB transport: pin libplctag width-mismatch health/warn-once and DefaultTransport registration with tests #585

New Issue
Closed
opened 2026-10-07 21:51:03 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 21:51:03 -04:00
Owner
Copy Link
Copy Source

Found by the final re-review of the native AB transport work (branch feat/native-ab-transport). Minor test gaps:

  • No test pins the libplctag width-mismatch path's new behaviour (BadTypeMismatch, handle kept, no Degraded, warn once).
  • Deleting the Drivers:AbCip:DefaultTransport registration in Program.cs would silently ignore an operator's pin; no test would catch it — add a composition-root test.
  • Note: a driver left Degraded after an outage whose only remaining tags mismatch gets one extra watchdog reconnect after 90 s before settling (benign).
Found by the final re-review of the native AB transport work (branch `feat/native-ab-transport`). Minor test gaps: - [ ] No test pins the libplctag width-mismatch path's new behaviour (BadTypeMismatch, handle kept, no Degraded, warn once). - [ ] Deleting the `Drivers:AbCip:DefaultTransport` registration in `Program.cs` would silently ignore an operator's pin; no test would catch it — add a composition-root test. - [ ] Note: a driver left Degraded after an outage whose only remaining tags mismatch gets one extra watchdog reconnect after 90 s before settling (benign).
dohertj2 added the driver/abcip label 2026-10-07 21:51:03 -04:00
dohertj2 commented 2026-10-08 01:53:58 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: width-mismatch test (BadTypeMismatch, handle kept, no Degraded, warn once); AddAbCipDriverDefaults extracted and a composition-root test fails if Program.cs stops calling it; benign Degraded note documented. (merge 29cd25de on master, pushed 2026-10-08)

Fixed: width-mismatch test (BadTypeMismatch, handle kept, no Degraded, warn once); AddAbCipDriverDefaults extracted and a composition-root test fails if Program.cs stops calling it; benign Degraded note documented. (merge `29cd25de` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?