dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AB transport tests: replace fixed-delay absence assertions with positive controls #583

New Issue
Closed
opened 2026-10-07 21:47:00 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 21:47:00 -04:00
Owner
Copy Link
Copy Source

Found by the final whole-branch review of the native AB transport work (branch feat/native-ab-transport, plan docs/plans/2026-10-07-native-ab-transport.md). Minor; not merge-blocking.

Several Ab.Transport tests assert absence after a fixed delay. They can only pass vacuously, never fail spuriously — replace with a positive control (follow-up message that must arrive) or processed-tick counts.

Found by the final whole-branch review of the native AB transport work (branch `feat/native-ab-transport`, plan `docs/plans/2026-10-07-native-ab-transport.md`). Minor; not merge-blocking. Several Ab.Transport tests assert absence after a fixed delay. They can only pass vacuously, never fail spuriously — replace with a positive control (follow-up message that must arrive) or processed-tick counts.
dohertj2 added the driver/abcipdriver/ablegacy labels 2026-10-07 21:47:00 -04:00
dohertj2 commented 2026-10-08 01:53:57 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: ~20 fixed-delay absence assertions across Ab.Transport/AbCip/AbLegacy tests converted to processed-count waits or positive controls. (merge e5fe2e55 on master, pushed 2026-10-08)

Fixed: ~20 fixed-delay absence assertions across Ab.Transport/AbCip/AbLegacy tests converted to processed-count waits or positive controls. (merge `e5fe2e55` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#583
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?