dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AB drivers: share MapStatus + libplctag orphan release across AbCip/AbLegacy; remove dead MapCipGeneralStatus/MapPcccStatus #580

New Issue
Closed
opened 2026-10-07 21:46:59 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 21:46:59 -04:00
Owner
Copy Link
Copy Source

Found by the final whole-branch review of the native AB transport work (branch feat/native-ab-transport, plan docs/plans/2026-10-07-native-ab-transport.md). Minor; not merge-blocking.

Status mapping and the #578 orphan-release helper are duplicated across the two drivers; MapCipGeneralStatus / MapPcccStatus have no callers. Consolidate into one shared place and delete or [Obsolete] the dead mappers.

Found by the final whole-branch review of the native AB transport work (branch `feat/native-ab-transport`, plan `docs/plans/2026-10-07-native-ab-transport.md`). Minor; not merge-blocking. Status mapping and the #578 orphan-release helper are duplicated across the two drivers; `MapCipGeneralStatus` / `MapPcccStatus` have no callers. Consolidate into one shared place and delete or [Obsolete] the dead mappers.
dohertj2 added the driver/abcipdriver/ablegacy labels 2026-10-07 21:46:59 -04:00
dohertj2 commented 2026-10-08 01:53:55 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: one AbOpcUaStatusMap in Ab.Transport; LibplctagOrphanRelease is one shared source file compiled into both drivers; MapCipGeneralStatus/MapPcccStatus deleted. (merge 29cd25de on master, pushed 2026-10-08)

Fixed: one AbOpcUaStatusMap in Ab.Transport; LibplctagOrphanRelease is one shared source file compiled into both drivers; MapCipGeneralStatus/MapPcccStatus deleted. (merge `29cd25de` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?