AbCip native: make lease release non-blocking (async teardown) and align with AbLegacy #579

New Issue

2026-10-07T21:46:58-04:00

dohertj2 commented

2026-10-07 21:46:58 -04:00

Found by the final whole-branch review of the native AB transport work (branch feat/native-ab-transport, plan docs/plans/2026-10-07-native-ab-transport.md). Minor; not merge-blocking.

Lease release on the native AbCip path blocks up to 2 s under the per-tag lock (a deliberate earlier decision). Move to async/non-blocking teardown and align the AbCip and AbLegacy release paths; needs its own design + a soak run.

Found by the final whole-branch review of the native AB transport work (branch `feat/native-ab-transport`, plan `docs/plans/2026-10-07-native-ab-transport.md`). Minor; not merge-blocking. Lease release on the native AbCip path blocks up to 2 s under the per-tag lock (a deliberate earlier decision). Move to async/non-blocking teardown and align the AbCip and AbLegacy release paths; needs its own design + a soak run.

dohertj2 added the driver/abcip label 2026-10-07 21:46:58 -04:00

dohertj2 referenced this issue from a commit

2026-10-08 01:53:39 -04:00

fix(abcip): native runtime STRING capacity, mistype churn, malformed-name config error, LWORD type check; non-blocking lease release (#570, #579)

dohertj2 referenced this issue

2026-10-08 01:53:47 -04:00

Ab.Transport: CipConnection/DeviceSessionPool test gaps and CIP-level close detection #566

dohertj2 commented

2026-10-08 01:53:54 -04:00

Fixed: ConnectionLease.ReleaseInBackground — native AbCip release no longer blocks under the per-tag lock; AbLegacy uses the same helper; pool records the close before returning so a re-create can't double-open; repeated create/release cycle tests show no leaked connections. Residual: no soak against ab_server (offline cycle tests stand in); ab_server read/write suites pass on the merged code. (merge 501f6ea4 on master, pushed 2026-10-08)

Fixed: ConnectionLease.ReleaseInBackground — native AbCip release no longer blocks under the per-tag lock; AbLegacy uses the same helper; pool records the close before returning so a re-create can't double-open; repeated create/release cycle tests show no leaked connections. Residual: no soak against ab_server (offline cycle tests stand in); ab_server read/write suites pass on the merged code. (merge `501f6ea4` on master, pushed 2026-10-08)

dohertj2 closed this issue

2026-10-08 01:53:55 -04:00

dohertj2 referenced this issue

2026-10-08 02:31:08 -04:00

Ab.Transport: offline/simulator test gaps left by #565, #570, #579 #593

dohertj2 referenced this issue from a commit

2026-10-08 09:03:18 -04:00

test(abcip): ab_server soak of ConnectionLease.ReleaseInBackground; fixture docs (#579, #593, #594)

dohertj2 referenced this issue

2026-10-08 09:24:24 -04:00

Ab.Transport: offline/simulator test gaps left by #565, #570, #579 #593

Sign in to join this conversation.