dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AdminUI AbCip/AbLegacy driver forms drop unknown options and reset MaxConcurrentReads on save #576

New Issue
Closed
opened 2026-10-07 19:11:02 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-10-07 19:11:02 -04:00
Owner
Copy Link
Copy Source

Found during the native AB transport AdminUI live gate (Task 19, branch feat/native-ab-transport); pre-existing, not fixed there.

  • AbCipDriverForm / AbLegacyDriverForm FromOptions/ToOptions drop unknown JSON keys on save — any driver option not modelled in the form is silently erased when an operator edits an unrelated field (the same defect class Task 19 fixed for transport).
  • AbCipDriverForm resets MaxConcurrentReads to 8 on every save.
  • Add a round-trip test per form: load a config containing every option + an unknown key, edit one field, save, assert everything else is preserved.
Found during the native AB transport AdminUI live gate (Task 19, branch `feat/native-ab-transport`); pre-existing, not fixed there. - [ ] `AbCipDriverForm` / `AbLegacyDriverForm` `FromOptions`/`ToOptions` drop unknown JSON keys on save — any driver option not modelled in the form is silently erased when an operator edits an unrelated field (the same defect class Task 19 fixed for `transport`). - [ ] `AbCipDriverForm` resets `MaxConcurrentReads` to 8 on every save. - [ ] Add a round-trip test per form: load a config containing every option + an unknown key, edit one field, save, assert everything else is preserved.
dohertj2 added the driver/abcipdriver/ablegacy labels 2026-10-07 19:11:02 -04:00
dohertj2 commented 2026-10-08 01:53:53 -04:00
Author
Owner
Copy Link
Copy Source

Fixed: AbCip/AbLegacy forms overlay only the keys they edit (unknown keys survive); MaxConcurrentReads is a form field; also fixed the forms writing TimeSpan-string keys the factories never read — they now write timeoutMs/alarmPollIntervalMs/probe.intervalMs/probe.timeoutMs and migrate legacy keys. Live-verified on docker-dev (edit+save kept injected unknown keys; ms keys written). (merge 7105ef3e on master, pushed 2026-10-08)

Fixed: AbCip/AbLegacy forms overlay only the keys they edit (unknown keys survive); MaxConcurrentReads is a form field; also fixed the forms writing TimeSpan-string keys the factories never read — they now write timeoutMs/alarmPollIntervalMs/probe.intervalMs/probe.timeoutMs and migrate legacy keys. Live-verified on docker-dev (edit+save kept injected unknown keys; ms keys written). (merge `7105ef3e` on master, pushed 2026-10-08)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/abcip driver/ablegacy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?