dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

AdminUI.Tests: PageAuthorizationGuardTests red on master — /apikeys was never classified #531

New Issue
Closed
opened 2026-08-01 01:10:31 -04:00 by dohertj2 · 0 comments
dohertj2 commented 2026-08-01 01:10:31 -04:00
Owner
Copy Link
Copy Source

Fixed in 3a6b2a1d. Red on master from fbe7403c until then.

PageAuthorizationGuardTests.EveryRoutablePage_isClassifiedAndMatchesExpectedPolicy enumerates every
routable page and fails on any not present in its expected-policy map. The /apikeys page added by #520's
key-minting work was never added to that map, so the guard has been failing since it merged.

Classified as AdminUiPolicies.FleetAdmin, matching the page's own [Authorize] attribute — minting a key
hands out a data-plane credential and the secret is shown once, the same authority level as RoleGrants.

Process note, which is the actually useful part of this issue. The pre-merge check for stage 4 ran
Core / ControlPlane / Runtime / Host / OpcUaServer and not AdminUI.Tests, so a red guard merged. The
guard is the one test that fails when a new page appears anywhere, so any change adding a routable page must
run that suite.

**Fixed in `3a6b2a1d`. Red on `master` from `fbe7403c` until then.** `PageAuthorizationGuardTests.EveryRoutablePage_isClassifiedAndMatchesExpectedPolicy` enumerates every routable page and fails on any not present in its expected-policy map. The `/apikeys` page added by #520's key-minting work was never added to that map, so the guard has been failing since it merged. Classified as `AdminUiPolicies.FleetAdmin`, matching the page's own `[Authorize]` attribute — minting a key hands out a data-plane credential and the secret is shown once, the same authority level as `RoleGrants`. **Process note, which is the actually useful part of this issue.** The pre-merge check for stage 4 ran Core / ControlPlane / Runtime / Host / OpcUaServer and *not* `AdminUI.Tests`, so a red guard merged. The guard is the one test that fails when a new page appears anywhere, so any change adding a routable page must run that suite.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?