dohertj2/lmxopcua
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(adminui): _canRebirth is captured at browse-open, so a reaped session still draws Request-rebirth #510

New Issue
Closed
opened 2026-07-27 13:50:30 -04:00 by dohertj2 · 1 comment
dohertj2 commented 2026-07-27 13:50:30 -04:00
Owner
Copy Link
Copy Source

RawBrowseModal.razor:377 sets _canRebirth = BrowserService.CanRequestRebirth(_token) once, when the
browse session is established. Browse sessions are reaped for idleness after ~2 minutes. A modal left open past
the reap therefore still renders the Request rebirth… button (RawBrowseModal.razor:102), and clicking it
fails against a token that no longer resolves.

Not silent — the error is surfaced to the operator, not swallowed, and reopening the browser fixes it. So
this is a stale-affordance defect: the UI offers an action it can no longer perform.

Fix options, in increasing order of effort:

  1. Re-evaluate CanRequestRebirth(_token) at click time and, on a dead token, re-establish the session (or
    tell the operator to reopen) instead of erroring.
  2. Have the session-reap path notify open modals so the button disappears when the capability does.

Option 1 alone closes the operator-visible symptom.

Acceptance. With a browse modal open and idle past the reap window, the rebirth affordance either works
(session re-established) or is no longer offered — it never presents and then errors.

`RawBrowseModal.razor:377` sets `_canRebirth = BrowserService.CanRequestRebirth(_token)` **once**, when the browse session is established. Browse sessions are reaped for idleness after ~2 minutes. A modal left open past the reap therefore still renders the *Request rebirth…* button (`RawBrowseModal.razor:102`), and clicking it fails against a token that no longer resolves. **Not silent** — the error is surfaced to the operator, not swallowed, and reopening the browser fixes it. So this is a stale-affordance defect: the UI offers an action it can no longer perform. **Fix options,** in increasing order of effort: 1. Re-evaluate `CanRequestRebirth(_token)` at click time and, on a dead token, re-establish the session (or tell the operator to reopen) instead of erroring. 2. Have the session-reap path notify open modals so the button disappears when the capability does. Option 1 alone closes the operator-visible symptom. **Acceptance.** With a browse modal open and idle past the reap window, the rebirth affordance either works (session re-established) or is no longer offered — it never presents and then errors.
dohertj2 added the driver/mqtt label 2026-07-27 13:50:30 -04:00
dohertj2 commented 2026-07-31 06:42:58 -04:00
Author
Owner
Copy Link
Copy Source

Fixed in master 2a7d1167 — option 1, plus a bit more.

RawBrowseModal re-probes CanRequestRebirth on arm and on confirm. The second one is not
belt-and-braces: the reap can land between arming the two-click confirm and clicking it, and confirm is
the one path that publishes to a live broker.

When the capability has gone the affordance is retired with an explanation rather than vanishing
silently or erroring — the panel is replaced by "this browse session expired while idle… close and
re-open the browser". CanRequestRebirth is a cheap, non-throwing, no-I/O probe that is false for a
reaped token, so re-running it per click costs nothing.

Note this stays a capability probe. The DriverOperator authorization gate is untouched and still
fails closed server-side in BrowserSessionService.RequestRebirthAsync.

Fixed in master `2a7d1167` — option 1, plus a bit more. `RawBrowseModal` re-probes `CanRequestRebirth` on **arm and on confirm**. The second one is not belt-and-braces: the reap can land between arming the two-click confirm and clicking it, and confirm is the one path that publishes to a live broker. When the capability has gone the affordance is **retired with an explanation** rather than vanishing silently or erroring — the panel is replaced by "this browse session expired while idle… close and re-open the browser". `CanRequestRebirth` is a cheap, non-throwing, no-I/O probe that is false for a reaped token, so re-running it per click costs nothing. Note this stays a **capability** probe. The `DriverOperator` authorization gate is untouched and still fails closed server-side in `BrowserSessionService.RequestRebirthAsync`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/mqtt
MQTT / Sparkplug B broker-subscribe driver
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label driver/mqtt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?