R2-05 AdminUI authorization (arch-review round 2) #428

2026-07-13T10:11:16-04:00

dohertj2 commented

2026-07-13 10:11:16 -04:00

Round-2 arch-review plan R2-05 (finding 04/C-1, High — under-gated AdminUI config surfaces; stakes raised because ResilienceConfig rides the config-authoring surface).

New AdminUiPolicies constants (single source of truth for the 4 policy names).
Two new policies: ConfigEditor (Administrator+Designer) on the 20-page config-authoring surface (incl. all 8 driver pages authoring live ResilienceConfig + /api/script-analysis/*); AuthenticatedRead on the 16 read pages. FleetAdmin/DriverOperator literals→constants.
Every routable page carries an explicit named-policy attribute; zero bare [Authorize], zero Roles=.
Anti-drift reflection guard PageAuthorizationGuardTests (the no-bUnit substitute) + AdminUiPoliciesTests role matrix.

15/16 tasks; T15 deferred-live (docker-dev DisableLogin=true auto-admin makes role-deny unobservable there — deny proof is CI-side, green). Build clean; AdminUI.Tests 517/517, Security.Tests 80/80. Plan: archreview/plans/R2-05-adminui-authz-plan.md.

Round-2 arch-review plan **R2-05** (finding 04/C-1, High — under-gated AdminUI config surfaces; stakes raised because ResilienceConfig rides the config-authoring surface). - New `AdminUiPolicies` constants (single source of truth for the 4 policy names). - Two new policies: **ConfigEditor** (Administrator+Designer) on the 20-page config-authoring surface (incl. all 8 driver pages authoring live ResilienceConfig + `/api/script-analysis/*`); **AuthenticatedRead** on the 16 read pages. FleetAdmin/DriverOperator literals→constants. - Every routable page carries an explicit named-policy attribute; zero bare `[Authorize]`, zero `Roles=`. - Anti-drift reflection guard `PageAuthorizationGuardTests` (the no-bUnit substitute) + `AdminUiPoliciesTests` role matrix. 15/16 tasks; **T15 deferred-live** (docker-dev DisableLogin=true auto-admin makes role-deny unobservable there — deny proof is CI-side, green). Build clean; AdminUI.Tests 517/517, Security.Tests 80/80. Plan: `archreview/plans/R2-05-adminui-authz-plan.md`.

dohertj2 added 5 commits 2026-07-13 10:11:17 -04:00

feat(security): add ConfigEditor + AuthenticatedRead AdminUI policies behind AdminUiPolicies constants 183b72b7cb

fix(adminui): gate every page with named policies — ConfigEditor on the mutating surface (R2-05, 04/C-1) b5bf4b73ff

refactor(adminui): replace authorization string literals with AdminUiPolicies constants aac3285468

docs(security): document AdminUI policy tiers (ConfigEditor/AuthenticatedRead) + R2-05 status dad783514a

docs(r2-05): flip 04/C-1 to FIXED, record execution deviations + task status

v2-ci / build (pull_request) Successful in 3m50s

Details

v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (pull_request) Failing after 3m35s

Details

v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (pull_request) Failing after 1m42s

Details