dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

R2-06 ServerHistorian fail-fast + 0.2.0 DataType (arch-review round 2) #427

Closed
dohertj2 wants to merge 0 commits from r2/06-serverhistorian-failfast into master
pull from: r2/06-serverhistorian-failfast
merge into: dohertj2:master
Conversation 1 Commits - Files Changed -
+592 -26
dohertj2 commented 2026-07-13 10:09:03 -04:00
Owner
Copy Link
Copy Source

Round-2 arch-review plan R2-06 (findings 06/S-11, U-7, C-7).

  • S-11 ServerHistorian misconfig no longer crash-loops the Host with raw UriFormatException — startup ServerHistorianOptionsValidator (gated on ServerHistorian OR AlarmHistorian enabled) fails fast with a named, actionable error; alarm-only-mode warning.
  • U-7 HistorianGateway 0.2.0 proto3-optional DataType: pin Boolean→Int1 on explicit presence (HasDataType), retype probe + live EnsureTags leg (env-gated), upsert/retype doc note.
  • C-7 keep-populating decision documented (proto3 sends 0=Bad when unset); dead Quality field doc'd.

T1–T11 complete; T12 deferred-live (needs a 0.2.0 gateway over VPN — controller's serial live pass). Clean build; Historian.Gateway unit suite 102 passed / 6 skipped. Plan: archreview/plans/R2-06-serverhistorian-failfast-plan.md.

Round-2 arch-review plan **R2-06** (findings 06/S-11, U-7, C-7). - **S-11** ServerHistorian misconfig no longer crash-loops the Host with raw UriFormatException — startup `ServerHistorianOptionsValidator` (gated on ServerHistorian OR AlarmHistorian enabled) fails fast with a named, actionable error; alarm-only-mode warning. - **U-7** HistorianGateway 0.2.0 proto3-optional DataType: pin Boolean→Int1 on explicit presence (HasDataType), retype probe + live EnsureTags leg (env-gated), upsert/retype doc note. - **C-7** keep-populating decision documented (proto3 sends 0=Bad when unset); dead Quality field doc'd. T1–T11 complete; **T12 deferred-live** (needs a 0.2.0 gateway over VPN — controller's serial live pass). Clean build; Historian.Gateway unit suite 102 passed / 6 skipped. Plan: `archreview/plans/R2-06-serverhistorian-failfast-plan.md`.
dohertj2 added 12 commits 2026-07-13 10:09:04 -04:00
fix(r2-06): RED repro — misconfigured ServerHistorian:Endpoint should fail with a named error, not UriFormatException (06/S-11) 3a049a13a4
fix(r2-06): GREEN adapter guard — TryCreate + named InvalidOperationException on bad ServerHistorian:Endpoint (06/S-11) 3108abc13b
fix(r2-06): RED — ServerHistorianOptionsValidator unit + wiring tests (net-new type; does not compile) (06/S-11) 35d8abee84
fix(r2-06): GREEN — ServerHistorianOptionsValidator (consumer-gated fail-fast on bad Endpoint) (06/S-11) 5369994e57
fix(r2-06): wire AddValidatedOptions<ServerHistorianOptions> + alarm-only-mode startup warning in Program.cs (06/S-11) e748f929c8
fix(r2-06): warning parity — malformed-endpoint warning in ServerHistorianOptions.Validate() (06/S-11) b77bbd13b7
test(r2-06): pin 0.2.0 Boolean->Int1 explicit-presence (HasDataType) provisioning (06/U-7) dc2f3fa970
test(r2-06): HISTGW_BOOL_SANDBOX_TAG fixture + Boolean EnsureTags leg + retype probe (skip-clean offline) (06/U-7) 1aa89d754f
docs(r2-06): 0.2.0 DataType provisioning delta (upsert/retype) + HISTGW_BOOL_SANDBOX_TAG recipe (06/U-7) e5cf986a10
docs(r2-06): note WriteLiveValues Quality is a documented-dead input (0.2.0 C-002); keep 192 populated (06/C-7) 4640ecb19b
docs(r2-06): record S-11/U-7/C-7 remediation in STATUS.md + 06 report rows (06/S-11,U-7,C-7) fc38cee00e
docs(r2-06): mark T12 live gate deferred-live + record execution deviations (06/U-7)
v2-ci / build (pull_request) Successful in 3m55s
Details
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (pull_request) Failing after 3m51s
Details
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (pull_request) Failing after 1m43s
Details
v2-ci / unit-tests (pull_request) Failing after 8m36s
Details
d59e6b5934
dohertj2 commented 2026-07-13 10:10:50 -04:00
Author
Owner
Copy Link
Copy Source

Landed on master via merge commit 47905709 (local --no-ff merge, STATUS.md conflict resolved additively, clean dotnet build barrier). Closing as merged.

Landed on `master` via merge commit `47905709` (local --no-ff merge, STATUS.md conflict resolved additively, clean dotnet build barrier). Closing as merged.
dohertj2 closed this pull request 2026-07-13 10:10:50 -04:00
Some checks are pending
v2-ci / build (pull_request) Successful in 3m55s
Details
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) (pull_request) Failing after 3m51s
Details
v2-ci / integration (tests/Server/ZB.MOM.WW.OtOpcUa.OpcUaServer.IntegrationTests) (pull_request) Failing after 1m43s
Details
v2-ci / unit-tests (pull_request) Failing after 8m36s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2 (dohertj2)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#427
Delete Branch "r2/06-serverhistorian-failfast"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?