Pre-existing test failure: EquipmentNamespaceMaterializationTests deployment Rejected (not Accepted) #424

New Issue

2026-06-27T01:57:21-04:00

dohertj2 commented

2026-06-27 01:57:21 -04:00

Summary

EquipmentNamespaceMaterializationTests.Deploying_an_equipment_namespace_carries_the_signal_into_the_artifact (in ZB.MOM.WW.OtOpcUa.Host.IntegrationTests) fails: StartDeploymentAsync returns StartDeploymentOutcome.Rejected where the test expects Accepted — assertion at tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests/EquipmentNamespaceMaterializationTests.cs:43.

The test seeds a 1-area / 1-line / 1-equipment / 1-tag Modbus equipment namespace (tag Speed, FullName = 40001) and StartDeployments it through the real ConfigComposer. The deployment is rejected at the DraftValidator / ConfigComposer stage, before the artifact is composed — so the downstream ParseComposition assertions are never reached.

Repro

dotnet test tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests.csproj \
  --filter "FullyQualifiedName~EquipmentNamespaceMaterializationTests.Deploying_an_equipment_namespace_carries_the_signal_into_the_artifact"

Result:

StartDeploymentOutcome.Accepted
    but was
StartDeploymentOutcome.Rejected
  ...EquipmentNamespaceMaterializationTests.cs:line 43

Pre-existing / scope

Not introduced by the OtOpcUa ↔ HistorianGateway integration (PR #423): that branch touches none of the Modbus / DraftValidator / ConfigComposer / equipment-namespace-materialization code path (git diff --stat master..HEAD confirms only *Historian* files changed), yet the test fails identically.
Surfaced while running the full suite during that integration; filed here so it is tracked independently of the historian work.

Next step

Root-cause the DraftValidator rejection of the Modbus-only namespace (the deployment is rejected before composition). Most likely a validation rule or environment/config expectation the seeded namespace no longer satisfies — capture the rejection reason from the StartDeployment outcome / validator diagnostics.

## Summary `EquipmentNamespaceMaterializationTests.Deploying_an_equipment_namespace_carries_the_signal_into_the_artifact` (in `ZB.MOM.WW.OtOpcUa.Host.IntegrationTests`) fails: `StartDeploymentAsync` returns `StartDeploymentOutcome.Rejected` where the test expects `Accepted` — assertion at `tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests/EquipmentNamespaceMaterializationTests.cs:43`. The test seeds a 1-area / 1-line / 1-equipment / 1-tag **Modbus** equipment namespace (tag `Speed`, `FullName = 40001`) and `StartDeployment`s it through the real `ConfigComposer`. The deployment is rejected at the `DraftValidator` / `ConfigComposer` stage, before the artifact is composed — so the downstream `ParseComposition` assertions are never reached. ## Repro ``` dotnet test tests/Server/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests/ZB.MOM.WW.OtOpcUa.Host.IntegrationTests.csproj \ --filter "FullyQualifiedName~EquipmentNamespaceMaterializationTests.Deploying_an_equipment_namespace_carries_the_signal_into_the_artifact" ``` Result: ``` StartDeploymentOutcome.Accepted but was StartDeploymentOutcome.Rejected ...EquipmentNamespaceMaterializationTests.cs:line 43 ``` ## Pre-existing / scope - **Not introduced** by the OtOpcUa ↔ HistorianGateway integration (PR #423): that branch touches **none** of the Modbus / `DraftValidator` / `ConfigComposer` / equipment-namespace-materialization code path (`git diff --stat master..HEAD` confirms only `*Historian*` files changed), yet the test fails identically. - Surfaced while running the full suite during that integration; filed here so it is tracked **independently** of the historian work. ## Next step Root-cause the `DraftValidator` rejection of the Modbus-only namespace (the deployment is rejected before composition). Most likely a validation rule or environment/config expectation the seeded namespace no longer satisfies — capture the rejection reason from the `StartDeployment` outcome / validator diagnostics.

dohertj2 referenced this issue from a commit

2026-06-27 02:00:13 -04:00

docs(historian-gateway): FU-5 tracked via issue #424 (pre-existing, not ours)

dohertj2 commented

2026-07-15 08:11:48 -04:00

Resolved by 859d6317 ("fix(harness): make deploy E2E tests pass against real SQL (seed cluster FKs)", 2026-07-15, in master).

Root cause

Not a DraftValidator rule regression — the rejection was a missing FK-parent seed on real SQL. The test seeded the equipment namespace but not the parent ServerCluster / ClusterNode rows the SQL FKs require. On the in-memory provider FKs aren't enforced, so it "passed" there; against real SQL StartDeployment was rejected before composition. This is the same class of false alarm the 2026-07-15 integration sweep catalogued (#6b: in-memory-hidden FK-parent-seed + stale-EquipmentId), not a sp_ValidateDraft/managed-validator defect.

Fix

The test now calls harness.SeedDefaultClusterAsync("c1") before SeedEquipmentNamespaceAsync (see EquipmentNamespaceMaterializationTests.cs:46), seeding the parent cluster/node FK rows.

Verification

dotnet test --filter FullyQualifiedName~EquipmentNamespaceMaterializationTests → Passed 3/3 consecutive runs on master @ e0ff908d. Closing as resolved.

**Resolved by `859d6317`** ("fix(harness): make deploy E2E tests pass against real SQL (seed cluster FKs)", 2026-07-15, in `master`). ## Root cause Not a `DraftValidator` rule regression — the rejection was a **missing FK-parent seed on real SQL**. The test seeded the equipment namespace but not the parent `ServerCluster` / `ClusterNode` rows the SQL FKs require. On the in-memory provider FKs aren't enforced, so it "passed" there; against real SQL `StartDeployment` was rejected before composition. This is the same class of false alarm the 2026-07-15 integration sweep catalogued (#6b: in-memory-hidden FK-parent-seed + stale-EquipmentId), *not* a `sp_ValidateDraft`/managed-validator defect. ## Fix The test now calls `harness.SeedDefaultClusterAsync("c1")` before `SeedEquipmentNamespaceAsync` (see `EquipmentNamespaceMaterializationTests.cs:46`), seeding the parent cluster/node FK rows. ## Verification `dotnet test --filter FullyQualifiedName~EquipmentNamespaceMaterializationTests` → **Passed 3/3** consecutive runs on `master` @ `e0ff908d`. Closing as resolved.

dohertj2 closed this issue

2026-07-15 08:11:48 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#424