dohertj2/lmxopcua
1
0
Fork 0
Code Issues 44 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[focas] FOCAS — PMC F/G letters for 16i #356

Merged
dohertj2 merged 1 commits from auto/focas/F2-c into auto/driver-gaps 2026-04-25 19:51:41 -04:00
Conversation 0 Commits 1 Files Changed 2 +7 -5
dohertj2 commented 2026-04-25 19:51:35 -04:00
Owner
Copy Link

Summary

Capability-matrix correctness fix for FOCAS PMC addressing on the 16i CNC family.

  • FocasCapabilityMatrix.PmcLetters(Sixteen_i) widened from {X, Y, R, D} to {X, Y, F, G, R, D}. Real 16i ladders use F/G for handshakes; the prior set silently rejected legitimate addresses.
  • Doc-comment updated noting M/C/E/A/K/T remain 0i-F / 30i-only.

Test plan

  • dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.FOCAS — clean (0 / 0)
  • dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests --filter ~FocasCapabilityMatrixTests — 47 / 47 passed (16i theory rows now expect F/G accepted; K stays rejected; new M rejection confirms boundary)
  • Integration tests — skipped (live CNC required)

🤖 Auto-generated by the Mode-B execution loop. Closes #265.

Closes #265

## Summary Capability-matrix correctness fix for FOCAS PMC addressing on the 16i CNC family. - **`FocasCapabilityMatrix.PmcLetters(Sixteen_i)`** widened from `{X, Y, R, D}` to `{X, Y, F, G, R, D}`. Real 16i ladders use F/G for handshakes; the prior set silently rejected legitimate addresses. - Doc-comment updated noting M/C/E/A/K/T remain 0i-F / 30i-only. ## Test plan - [x] `dotnet build src/ZB.MOM.WW.OtOpcUa.Driver.FOCAS` — clean (0 / 0) - [x] `dotnet test tests/ZB.MOM.WW.OtOpcUa.Driver.FOCAS.Tests --filter ~FocasCapabilityMatrixTests` — **47 / 47 passed** (16i theory rows now expect F/G accepted; K stays rejected; new M rejection confirms boundary) - [ ] Integration tests — skipped (live CNC required) 🤖 Auto-generated by the Mode-B execution loop. Closes #265. Closes #265
dohertj2 added 1 commit 2026-04-25 19:51:36 -04:00
Auto: focas-f2c — PMC F/G for 16i 63099115bf 
Capability-matrix correctness fix: real 16i ladders use F (CNC->PMC) and
G (PMC->CNC) signal groups for handshakes, but PmcLetters(Sixteen_i) was
returning {X,Y,R,D} only. Widen to {X,Y,F,G,R,D}; M/C/E/A/K/T remain
0i-F / 30i-only. Updated the matching test row.

Closes #265
dohertj2 merged commit 9ebe5bd523 into auto/driver-gaps 2026-04-25 19:51:41 -04:00
dohertj2 deleted branch auto/focas/F2-c 2026-04-25 19:51:41 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto-managed
queue management
 cross-driver
queue management
 driver/abcip
queue management
 driver/ablegacy
queue management
 driver/focas
queue management
 driver/opcuaclient
queue management
 driver/s7
queue management
 driver/twincat
queue management
 phase/1
queue management
 phase/2
queue management
 phase/3
queue management
 phase/4
queue management
 phase/5
queue management
 phase/6
queue management
 queue/blocked
queue management
 queue/done
queue management
 queue/failed
queue management
 queue/in-progress
queue management
 queue/queued
queue management
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#356
Delete Branch "auto/focas/F2-c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?