dohertj2/lmxopcua
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Phase 3 PR 15 — alarm-condition contract in abstract layer #14

Merged
dohertj2 merged 1 commits from phase-3-pr15-alarm-contract into v2 2026-04-18 07:54:32 -04:00
Conversation 0 Commits 1 Files Changed 6 +343 -14
dohertj2 commented 2026-04-18 07:54:17 -04:00
Owner
Copy Link

Extends IAddressSpaceBuilder with IVariableHandle.MarkAsAlarmCondition (returns IAlarmConditionSink). GenericDriverNodeManager captures sinks during discovery via a wrapping CapturingBuilder, subscribes to IAlarmSource.OnAlarmEvent, routes by SourceNodeId to the matching sink. GalaxyProxyDriver marks IsAlarm=true variables during Discover. Recording sink + 4 new tests cover routing, filtering, and dispose discipline. Defines the contract PR 16's concrete OPC UA server will implement to materialize AlarmConditionState nodes. 152/152 solution-wide unit tests pass.

Extends IAddressSpaceBuilder with IVariableHandle.MarkAsAlarmCondition (returns IAlarmConditionSink). GenericDriverNodeManager captures sinks during discovery via a wrapping CapturingBuilder, subscribes to IAlarmSource.OnAlarmEvent, routes by SourceNodeId to the matching sink. GalaxyProxyDriver marks IsAlarm=true variables during Discover. Recording sink + 4 new tests cover routing, filtering, and dispose discipline. Defines the contract PR 16's concrete OPC UA server will implement to materialize AlarmConditionState nodes. 152/152 solution-wide unit tests pass.
dohertj2 added 1 commit 2026-04-18 07:54:18 -04:00
Phase 3 PR 15 — alarm-condition contract in IAddressSpaceBuilder + wire OnAlarmEvent through GenericDriverNodeManager. IAddressSpaceBuilder.IVariableHandle gains MarkAsAlarmCondition(AlarmConditionInfo) which returns an IAlarmConditionSink. AlarmConditionInfo carries SourceName/InitialSeverity/InitialDescription. Concrete address-space builders (the upcoming PR 16 OPC UA server backend) materialize a sibling AlarmConditionState node on the first call; the sink receives every lifecycle transition the generic node manager forwards. GenericDriverNodeManager gains a CapturingBuilder wrapper that transparently wraps every Folder/Variable call — the wrapper observes MarkAsAlarmCondition calls without participating in materialization, captures the resulting IAlarmConditionSink into an internal source-node-id → sink ConcurrentDictionary keyed by IVariableHandle.FullReference. After DiscoverAsync completes, if the driver implements IAlarmSource the node manager subscribes to OnAlarmEvent and routes every AlarmEventArgs to the sink registered for args.SourceNodeId — unknown source ids are dropped silently (may belong to another driver or to a variable the builder chose not to flag). Dispose unsubscribes the forwarder to prevent dangling invocation-list references across node-manager rebuilds. GalaxyProxyDriver.DiscoverAsync now calls handle.MarkAsAlarmCondition(new AlarmConditionInfo(fullName, AlarmSeverity.Medium, null)) on every attr.IsAlarm=true variable — severity seed is Medium because the live Priority byte arrives through the subsequent GalaxyAlarmEvent stream (which PR 14's GalaxyAlarmTracker now emits); the Admin UI sees the severity update on the first transition. RecordingAddressSpaceBuilder in Driver.Galaxy.E2E gains a RecordedAlarmCondition list + a RecordingSink implementation that captures AlarmEventArgs for test assertion — the E2E parity suite can now verify alarm-condition registration shape in addition to folder/variable shape. Tests (4 new GenericDriverNodeManagerTests): Alarm_events_are_routed_to_the_sink_registered_for_the_matching_source_node_id — 2 alarms registered (Tank.HiHi + Heater.OverTemp), driver raises an event for Tank.HiHi, the Tank.HiHi sink captures the payload, the Heater.OverTemp sink does not (tag-scoped fan-out, not broadcast); Non_alarm_variables_do_not_register_sinks — plain Tank.Level in the same discover is not in TrackedAlarmSources; Unknown_source_node_id_is_dropped_silently — a transition for Unknown.Source doesn't reach any sink + no exception; Dispose_unsubscribes_from_OnAlarmEvent — post-dispose, a transition for a previously-registered tag is no-op because the forwarder detached. InternalsVisibleTo('ZB.MOM.WW.OtOpcUa.Core.Tests') added to Core csproj so TrackedAlarmSources internal property is visible to the test. Full solution: 0 errors, 152 unit tests pass (8 Core + 14 Proxy + 14 Admin + 24 Configuration + 6 Shared + 84 Galaxy.Host + 2 Server). PR 16 will implement the concrete OPC UA address-space builder that materializes AlarmConditionState from this contract. 190d09cdeb 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dohertj2 merged commit d569c39f30 into v2 2026-04-18 07:54:32 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dohertj2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dohertj2/lmxopcua#14
Delete Branch "phase-3-pr15-alarm-contract"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?