Commit Graph

  • a4d24b5cf5 review(Driver.AbCip.Contracts): first review; document IsArray/Writable contract Joseph Doherty 2026-06-19 12:22:53 -04:00
  • a19b0f8612 review: regenerate code-review index after Batch 8 (driver CLIs) Joseph Doherty 2026-06-19 12:09:01 -04:00
  • 7580e37807 review(Driver.TwinCAT.Cli): clean parse errors + FlushLogging() in finally Joseph Doherty 2026-06-19 12:08:45 -04:00
  • f8bf067243 review(Driver.S7.Cli): endpoint validation + cancellation/flush/write-lock consistency Joseph Doherty 2026-06-19 12:08:45 -04:00
  • b0f9b8016a review(Driver.Modbus.Cli): FlushLogging() + interval validation + banner-before-events Joseph Doherty 2026-06-19 12:08:45 -04:00
  • 754c5a3684 review(Driver.FOCAS.Cli): FlushLogging() in finally + fix misleading detach comment Joseph Doherty 2026-06-19 12:08:45 -04:00
  • b50fd6c34a review(Driver.AbLegacy.Cli): add FlushLogging() to command finally blocks Joseph Doherty 2026-06-19 12:08:45 -04:00
  • 111d6983a5 review: regenerate code-review index after Batch 7 (Wonderware.Client/Client.CLI/Shared/UI/AbCip.Cli) Joseph Doherty 2026-06-19 11:58:38 -04:00
  • 2b077fb789 review(Driver.AbCip.Cli): fix stale CLI-count + misleading --type help Joseph Doherty 2026-06-19 11:58:15 -04:00
  • 12efbffd56 review(Client.UI): single notification when removing non-retained alarm row Joseph Doherty 2026-06-19 11:58:15 -04:00
  • d68c9db9f9 review(Client.Shared): fix Disconnect/failover subscription race + CT forwarding Joseph Doherty 2026-06-19 11:58:15 -04:00
  • 887a31e825 review(Client.CLI): wrap NodeId parse errors in CommandException for alarm-op commands Joseph Doherty 2026-06-19 11:58:15 -04:00
  • cd072baad8 review(Driver.Historian.Wonderware.Client): async frame-header write + wire-parity test Joseph Doherty 2026-06-19 11:58:15 -04:00
  • c95a8c6b19 review: regenerate index after Batch 6 + fix Wonderware open-count header (0, -013 is Deferred=closed) Joseph Doherty 2026-06-19 11:47:46 -04:00
  • b3907efa6e review(Driver.Historian.Wonderware): AtTime fails over on connection-class errors Joseph Doherty 2026-06-19 11:47:11 -04:00
  • e07a4fbf52 review(Driver.FOCAS): add byte-level wire-protocol test coverage Joseph Doherty 2026-06-19 11:47:11 -04:00
  • 22f7d92b72 review(Driver.TwinCAT): thread ArrayLength through factory DTO (Medium) Joseph Doherty 2026-06-19 11:47:11 -04:00
  • 91e2609560 review(Driver.AbLegacy): fix Bit write 1-byte/2-byte encode-decode mismatch (Medium) Joseph Doherty 2026-06-19 11:47:11 -04:00
  • be272d960f review(Driver.OpcUaClient): release browse continuation point on cancel Joseph Doherty 2026-06-19 11:47:11 -04:00
  • 04e0877bff review: regenerate code-review index after Batch 5 (Galaxy/AbCip/S7/Modbus/Modbus.Addressing) Joseph Doherty 2026-06-19 11:34:46 -04:00
  • b5f6cdfdb9 review(Driver.Modbus.Addressing): fix misleading byte-order hint + drop dead overflow guard Joseph Doherty 2026-06-19 11:34:35 -04:00
  • 6853a0430f review(Driver.Modbus): validate FC03 RMW response + correct write error mapping Joseph Doherty 2026-06-19 11:34:34 -04:00
  • f2bdd8bc1c review(Driver.S7): reject writable array tags at init instead of silent write failure Joseph Doherty 2026-06-19 11:34:34 -04:00
  • a914b73d57 review(Driver.AbCip): fix declared UDT array members read as scalar (Medium) Joseph Doherty 2026-06-19 11:34:34 -04:00
  • db72dd1dca review(Driver.Galaxy): re-review at HEAD (1 Low deferred; vendoring findings obsolete) Joseph Doherty 2026-06-19 11:34:34 -04:00
  • ae3f071945 review: regenerate index after Batch 4 + fix Core.VirtualTags checklist heading Joseph Doherty 2026-06-19 11:22:56 -04:00
  • 1180b017f5 review(Driver.Cli.Common): drop dead FormatStatus branch + timestamp-kind test Joseph Doherty 2026-06-19 11:21:36 -04:00
  • 13c1215811 review(Analyzers): add trip-coverage for async guarded-interface methods Joseph Doherty 2026-06-19 11:21:35 -04:00
  • 6b4210cb17 review(Core.AlarmHistorian): reset drain state on cancel + volatile _disposed Joseph Doherty 2026-06-19 11:21:35 -04:00
  • 48af117bff review(Core.VirtualTags): fix Good-null upstream blocking downstream (Medium) Joseph Doherty 2026-06-19 11:21:35 -04:00
  • 272a9da61e review(Core.ScriptedAlarms): stop shelving timer on failed reload + drop dead branch Joseph Doherty 2026-06-19 11:21:35 -04:00
  • 621d00e455 review: regenerate code-review index after Batch 3 (Core/Abstractions/Scripting/Configuration) Joseph Doherty 2026-06-19 11:07:15 -04:00
  • c3d148e396 review(Configuration): fix LiteDB global BsonMapper cross-instance race (High) Joseph Doherty 2026-06-19 11:06:56 -04:00
  • 145b06bec9 review(Core.Scripting.Abstractions): refresh stale Phase7 labels + document {{equip}} Joseph Doherty 2026-06-19 11:06:56 -04:00
  • 38c48a009c review(Core.Scripting): block Unsafe.As sandbox bypass (Security) Joseph Doherty 2026-06-19 11:06:56 -04:00
  • 65e6af6001 review(Core.Abstractions): document ReadEventsAsync continuation contract (OpcUaServer-002 root) Joseph Doherty 2026-06-19 11:06:56 -04:00
  • 354b0e7613 review(Core): re-review at HEAD; clean up duplicate/unexplained doc comments Joseph Doherty 2026-06-19 11:06:56 -04:00
  • 8ac5a2dbc5 review: regenerate code-review index after Batch 2 (Runtime/ControlPlane/AdminUI/Browsers) Joseph Doherty 2026-06-19 10:52:45 -04:00
  • 2fe8e587dd review(Driver.OpcUaClient.Browser): AttributesAsync updates LastUsedUtc Joseph Doherty 2026-06-19 10:52:23 -04:00
  • 960d76ffcb review(Driver.Galaxy.Browser): fix mis-shifted MapSecurityClass codes (High) Joseph Doherty 2026-06-19 10:52:23 -04:00
  • 3c908f1df0 review(AdminUI): fix null-TagConfig crash, CTS leak, unencoded historian tag Joseph Doherty 2026-06-19 10:52:23 -04:00
  • 1aa7905676 review(ControlPlane): fix premature deploy-seal from unexpected-node ack Joseph Doherty 2026-06-19 10:52:22 -04:00
  • 3512089c90 review(Runtime): record findings + fix artifact-decode type tolerance Joseph Doherty 2026-06-19 10:52:22 -04:00
  • 5aaa82bc26 review: regenerate code-review index after Batch 1 (OpcUaServer/Security/Host/Cluster/Commons) Joseph Doherty 2026-06-19 10:37:26 -04:00
  • bac6613dd2 review(OpcUaServer): record findings + fix stale node-manager/host docs Joseph Doherty 2026-06-19 10:37:00 -04:00
  • e4abe186a1 review(Host): allow-anonymous /metrics + unconditional LDAP validator Joseph Doherty 2026-06-19 10:22:59 -04:00
  • d23e585cdb review(Security): fix login open-redirect (High) + stale LDAP doc Joseph Doherty 2026-06-19 10:22:59 -04:00
  • b1946194d6 review(Cluster): record findings + fix snapshot consistency, dispose, stale docs Joseph Doherty 2026-06-19 10:22:59 -04:00
  • 6dc74289ce review(Commons): record findings + add deferred-sink/equip-nodeid tests, fix stale Phase7 doc Joseph Doherty 2026-06-19 10:22:59 -04:00
  • 7286d3208a Merge: fix systemic driver-config enum serialization (AdminUI authoring) Joseph Doherty 2026-06-19 05:20:19 -04:00
  • a0dccbf8ee test(drivers): tighten driver-page converter guard + clarify S7 numeric case Joseph Doherty 2026-06-19 05:06:43 -04:00
  • 4b14feb373 fix(drivers): serialize driver-config enums as strings in AdminUI pages + probes Joseph Doherty 2026-06-19 04:52:47 -04:00
  • 30c9821fe6 Merge FB-7: surgical DataType/array-shape in-place tag writes Joseph Doherty 2026-06-19 03:50:03 -04:00
  • bcba7a4bea docs(opcua): note FB-7 surgical-shape reach (stable-FullName drivers only) Joseph Doherty 2026-06-19 03:49:10 -04:00
  • 7a8ae9600b refactor(opcua): FB-7 review nits — model-event SourceNode=Server, dataType guard, shape tests Joseph Doherty 2026-06-19 03:30:29 -04:00
  • fb094fa566 feat(opcua): FB-7 surgical DataType/array-shape in-place tag writes Joseph Doherty 2026-06-19 03:21:03 -04:00
  • a325ec54c7 docs(plan): record follow-ups batch execution outcome + live-verify results Joseph Doherty 2026-06-19 02:45:23 -04:00
  • 85afb678cd docs(test): mark the audit builder-vs-wiring coverage boundary explicit Joseph Doherty 2026-06-19 02:22:41 -04:00
  • d8254630bb refactor(adminui): trim inline-script label + null-case test + helper-proxy note Joseph Doherty 2026-06-19 02:16:59 -04:00
  • 36eb14e88d feat(opcua): emit Bad blip + AuditWriteUpdateEvent + sync fail-fast on failed device write Joseph Doherty 2026-06-19 02:14:58 -04:00
  • e047af0553 refactor(adminui): harden SetFullName (reject blank ref) + cover alarm-flag re-pick Joseph Doherty 2026-06-19 02:08:43 -04:00
  • da57c307a7 fix(adminui): refresh script dropdown label after inline create Joseph Doherty 2026-06-19 02:06:51 -04:00
  • 2dd723e195 fix(adminui): preserve edited alarm fields on Galaxy address re-pick Joseph Doherty 2026-06-19 02:02:06 -04:00
  • f81fa76809 test(cli): assert Enable/Disable object node + add suffix-idempotency test Joseph Doherty 2026-06-19 01:57:53 -04:00
  • eede0c926b test(opcuaclient): add AcknowledgeAsync stale-session race test + trim fallback delay Joseph Doherty 2026-06-19 01:56:56 -04:00
  • 6223bc970a refactor(adminui): tidy cert-audit review nits (fallthrough comment + single PkiStoreRoot read) Joseph Doherty 2026-06-19 01:51:38 -04:00
  • 88d5ba45bf feat(cli): add enable/disable condition commands (H4 client path) Joseph Doherty 2026-06-19 01:48:21 -04:00
  • eb328e5761 fix(opcuaclient): re-resolve session inside _gate in history/read paths (stale-session race) Joseph Doherty 2026-06-19 01:41:19 -04:00
  • ad359c5cd3 docs(plan): design + implementation plan + tasklist for non-arch follow-ups batch (A/B/C) Joseph Doherty 2026-06-19 01:19:37 -04:00
  • f57aa8facd docs(plan): mark cert-audit + probe-tidy plan COMPLETE (live /run PASS) Joseph Doherty 2026-06-19 00:54:32 -04:00
  • 3eb370d4ea refactor(adminui): explicit discard on fire-and-forget audit + Untrust not-found test (review) Joseph Doherty 2026-06-19 00:45:10 -04:00
  • 3ee0099fae refactor(adminui): omit error key on success cert-audit rows + assert OccurredAtUtc (review) Joseph Doherty 2026-06-19 00:38:41 -04:00
  • 23d45efcfd feat(adminui): audit cert Trust/Untrust/Delete to ConfigAuditLog Joseph Doherty 2026-06-19 00:36:54 -04:00
  • de6ce147fc fix(runtime): drop OpcUaProbeResult in redundancy-topic subscribers (no dead-letter) Joseph Doherty 2026-06-19 00:32:03 -04:00
  • 084d73ea2b feat(adminui): IAuditWriter adapter + cert-action audit-event factory Joseph Doherty 2026-06-19 00:31:37 -04:00
  • 21c881161a docs(plan): implementation plan + tasks for cert-audit + probe dead-letter tidy Joseph Doherty 2026-06-19 00:26:30 -04:00
  • e8c75cc38f docs(plan): design for cert-action audit logging + OpcUaProbeResult dead-letter tidy Joseph Doherty 2026-06-19 00:23:32 -04:00
  • 40e8a23e7c refactor(opcuaserver): rename Phase7* address-space pipeline to AddressSpace* Joseph Doherty 2026-06-18 19:16:28 -04:00
  • 6af54ac935 chore(plan): mark F10b surgical tag-attribute writes phase complete Joseph Doherty 2026-06-18 14:02:47 -04:00
  • 22b0611fb9 fix(opcua): forward ISurgicalAddressSpaceSink through DeferredAddressSpaceSink (F10b surgical path was inert in prod) Joseph Doherty 2026-06-18 13:57:53 -04:00
  • b472bba384 test(opcua): pin F10b surgical guard — alarm-bearing tag rebuilds + multi-delta surgical success Joseph Doherty 2026-06-18 13:44:26 -04:00
  • f6618144a4 perf(opcua): surgical in-place tag-attribute writes (Writable/Historizing) avoid rebuild (F10b) Joseph Doherty 2026-06-18 13:37:56 -04:00
  • 3fc258bd42 feat(opcua): add ISurgicalAddressSpaceSink + node-manager in-place tag-attribute update (F10b) Joseph Doherty 2026-06-18 13:32:53 -04:00
  • acc6a64b26 docs(plan): implementation plan + tasks for F10b surgical tag-attribute writes Joseph Doherty 2026-06-18 13:31:10 -04:00
  • 4fe88519cf docs(plan): design for F10b surgical in-place tag-attribute writes (Writable/Historizing) Joseph Doherty 2026-06-18 13:30:01 -04:00
  • bbba911b51 chore(plan): mark F10b + Galaxy-comment phase tasks complete Joseph Doherty 2026-06-18 13:14:50 -04:00
  • b05c281132 test(opcua): pin F10b boundary — vtag EquipmentId-change + multi-vtag-mixed still rebuild Joseph Doherty 2026-06-18 13:11:53 -04:00
  • fac4418708 docs(client): document Galaxy fallback operator-comment limitation + pin null behavior Joseph Doherty 2026-06-18 13:06:37 -04:00
  • 6c6a2c4203 perf(opcua): skip address-space rebuild for vtag expression/deps/historize-only edits (F10b) Joseph Doherty 2026-06-18 13:03:50 -04:00
  • 0226b49437 docs(plan): implementation plan + tasks for F10b vtag rebuild-skip + Galaxy comment Joseph Doherty 2026-06-18 13:00:54 -04:00
  • 53f1147bfc docs(plan): design for F10b vtag rebuild-skip + Client.UI Galaxy comment limitation Joseph Doherty 2026-06-18 12:59:51 -04:00
  • be703a3026 chore(plan): mark FOCAS/Wonderware/AbCip phase tasks complete Joseph Doherty 2026-06-18 12:48:52 -04:00
  • 4022457000 test(focas): integration test for cnc_getfigure position scaling via focas-mock Joseph Doherty 2026-06-18 12:44:35 -04:00
  • c8ab8fc348 test(abcip): Emulate-tier nested-UDT live-gate smoke + docs (backlog #6) Joseph Doherty 2026-06-18 12:40:04 -04:00
  • 70aad3ef48 test(historian): cover PerEventStatus length-mismatch fallback + Retry status mapping Joseph Doherty 2026-06-18 12:37:31 -04:00
  • e5f568d01f docs(focas): retire stale 'wire backend returns no figures' comments after cnc_getfigure shipped Joseph Doherty 2026-06-18 12:32:55 -04:00
  • feddc2b80e feat(historian): emit PermanentFail for poison alarm events via additive PerEventStatus sidecar IPC field Joseph Doherty 2026-06-18 12:30:14 -04:00
  • f320f323ae feat(focas): add cnc_getfigure wire command + focas-mock handler Joseph Doherty 2026-06-18 12:23:14 -04:00
  • e5b1a5574a docs(plan): implementation plan + tasks for FOCAS/Wonderware/AbCip backlog phase Joseph Doherty 2026-06-18 12:19:45 -04:00
  • a687821f79 docs(plan): design for FOCAS cnc_getfigure + Wonderware poison-event status + AbCip nested-UDT live-gate Joseph Doherty 2026-06-18 12:17:13 -04:00