This website requires JavaScript.
f8406d348c
fix(otopcua): report NodeAdded model-change outside the node Lock
Joseph Doherty
2026-06-26 07:06:43 -04:00
93f7586590
fix(otopcua): guard root-level discovered var parent + tighten mapper
Joseph Doherty
2026-06-26 06:59:34 -04:00
33b0e639a5
feat(otopcua): GeneralModelChangeEvent(NodeAdded) for runtime node adds
Joseph Doherty
2026-06-26 06:55:52 -04:00
d7a0da5ea1
feat(otopcua): map discovered nodes under an equipment subfolder
Joseph Doherty
2026-06-26 06:47:18 -04:00
da55c6913d
feat(otopcua): capturing address-space builder for driver discovery
Joseph Doherty
2026-06-26 06:39:18 -04:00
74e07225c9
docs(otopcua): record the equipment-tag data-plane investigation + fix chain
Joseph Doherty
2026-06-26 06:00:05 -04:00
6600ce9940
feat(otopcua): bridge Akka actor logs into Serilog
Joseph Doherty
2026-06-26 06:00:05 -04:00
235b8b8e6d
fix(focas): serialize per-device wire I/O + bound reads; tolerate AdminUI config formats
Joseph Doherty
2026-06-26 05:59:54 -04:00
20b2df9241
docs(focas): record Phase 10 deploy outcome — v3 binary live + probe healthy; live tags blocked by separate OtOpcUa data-plane issue
feat/focas-pdu-v3
Joseph Doherty
2026-06-25 17:04:44 -04:00
5f0a52864c
feat(focas): real FANUC 30i/31i-B PDU-v3 support (live-validated on a 31i-B)
Joseph Doherty
2026-06-25 16:41:42 -04:00
fd01448ac4
fix(code-review): defer Driver.OpcUaClient.Contracts-002 + regenerate index
Joseph Doherty
2026-06-20 23:11:09 -04:00
23b42b424d
fix(code-review): resolve OpcUaServer-001 — UNS Area/Line rename refreshes folder DisplayName
Joseph Doherty
2026-06-20 23:10:24 -04:00
94eec70fb0
fix(code-review): resolve Batch 3 wave A (OpcUaServer history/guard, ControlPlane topology gate)
Joseph Doherty
2026-06-20 22:53:29 -04:00
c817d7720e
review: regenerate index after Batch 2 resolutions
Joseph Doherty
2026-06-20 22:43:36 -04:00
ab57e53b92
fix(code-review): resolve Batch 2 open findings (AbCip, AbLegacy, Galaxy, FOCAS)
Joseph Doherty
2026-06-20 22:43:36 -04:00
3cc6a5f30d
build: suppress NU1903 for CVE-2025-6965 (SQLitePCLRaw, no upstream fix)
Joseph Doherty
2026-06-20 22:43:15 -04:00
53edcd638b
review: regenerate index after Batch 1 resolutions
Joseph Doherty
2026-06-20 22:30:36 -04:00
98b27fc1b6
fix(code-review): resolve Batch 1 open findings (AdminUI auth, AlarmHistorian dispose guards, docs)
Joseph Doherty
2026-06-20 22:30:33 -04:00
c13fcc1d51
review: regenerate index after cross-module fix pass (Browser enum / auto-unshelve / AbCip array)
Joseph Doherty
2026-06-19 12:30:03 -04:00
3e789dcafc
review(Driver.AbCip): thread ElementCount/IsArray through factory tag DTOs
Joseph Doherty
2026-06-19 12:29:40 -04:00
40749d3f67
review(OpcUaServer): fix silent auto-unshelve failure (empty User -> 'system')
Joseph Doherty
2026-06-19 12:29:40 -04:00
298bd4bfe5
review(Driver.OpcUaClient.Browser): add JsonStringEnumConverter (systemic enum bug)
Joseph Doherty
2026-06-19 12:29:39 -04:00
7e1f34da7d
review: regenerate index after Batch 9+10 (all 9 Contracts modules) — full sweep complete (51 modules)
Joseph Doherty
2026-06-19 12:23:54 -04:00
78542ab2d2
review(Driver.Historian.Wonderware.Client.Contracts): redact SharedSecret in ToString (High)
Joseph Doherty
2026-06-19 12:22:53 -04:00
0c1d5f7f88
review(Driver.TwinCAT.Contracts): first review; fix ReadArrayLength doc
Joseph Doherty
2026-06-19 12:22:53 -04:00
5d01271f03
review(Driver.S7.Contracts): first review; gate stringLength check to String type
Joseph Doherty
2026-06-19 12:22:53 -04:00
9244e506c9
review(Driver.OpcUaClient.Contracts): first review; fix TryResolve nullability + [Range] guards
Joseph Doherty
2026-06-19 12:22:53 -04:00
a7ce742763
review(Driver.Modbus.Contracts): first review; guard equipment-tag bitIndex/stringLength
Joseph Doherty
2026-06-19 12:22:53 -04:00
45711e437d
review(Driver.Galaxy.Contracts): first review; [Range] guard on EventPumpChannelCapacity
Joseph Doherty
2026-06-19 12:22:53 -04:00
97020d0527
review(Driver.FOCAS.Contracts): first review; keep Writable=true default (re-triaged)
Joseph Doherty
2026-06-19 12:22:53 -04:00
26662aa2ec
review(Driver.AbLegacy.Contracts): first review; fix ArrayLength doc
Joseph Doherty
2026-06-19 12:22:53 -04:00
a4d24b5cf5
review(Driver.AbCip.Contracts): first review; document IsArray/Writable contract
Joseph Doherty
2026-06-19 12:22:53 -04:00
a19b0f8612
review: regenerate code-review index after Batch 8 (driver CLIs)
Joseph Doherty
2026-06-19 12:09:01 -04:00
7580e37807
review(Driver.TwinCAT.Cli): clean parse errors + FlushLogging() in finally
Joseph Doherty
2026-06-19 12:08:45 -04:00
f8bf067243
review(Driver.S7.Cli): endpoint validation + cancellation/flush/write-lock consistency
Joseph Doherty
2026-06-19 12:08:45 -04:00
b0f9b8016a
review(Driver.Modbus.Cli): FlushLogging() + interval validation + banner-before-events
Joseph Doherty
2026-06-19 12:08:45 -04:00
754c5a3684
review(Driver.FOCAS.Cli): FlushLogging() in finally + fix misleading detach comment
Joseph Doherty
2026-06-19 12:08:45 -04:00
b50fd6c34a
review(Driver.AbLegacy.Cli): add FlushLogging() to command finally blocks
Joseph Doherty
2026-06-19 12:08:45 -04:00
111d6983a5
review: regenerate code-review index after Batch 7 (Wonderware.Client/Client.CLI/Shared/UI/AbCip.Cli)
Joseph Doherty
2026-06-19 11:58:38 -04:00
2b077fb789
review(Driver.AbCip.Cli): fix stale CLI-count + misleading --type help
Joseph Doherty
2026-06-19 11:58:15 -04:00
12efbffd56
review(Client.UI): single notification when removing non-retained alarm row
Joseph Doherty
2026-06-19 11:58:15 -04:00
d68c9db9f9
review(Client.Shared): fix Disconnect/failover subscription race + CT forwarding
Joseph Doherty
2026-06-19 11:58:15 -04:00
887a31e825
review(Client.CLI): wrap NodeId parse errors in CommandException for alarm-op commands
Joseph Doherty
2026-06-19 11:58:15 -04:00
cd072baad8
review(Driver.Historian.Wonderware.Client): async frame-header write + wire-parity test
Joseph Doherty
2026-06-19 11:58:15 -04:00
c95a8c6b19
review: regenerate index after Batch 6 + fix Wonderware open-count header (0, -013 is Deferred=closed)
Joseph Doherty
2026-06-19 11:47:46 -04:00
b3907efa6e
review(Driver.Historian.Wonderware): AtTime fails over on connection-class errors
Joseph Doherty
2026-06-19 11:47:11 -04:00
e07a4fbf52
review(Driver.FOCAS): add byte-level wire-protocol test coverage
Joseph Doherty
2026-06-19 11:47:11 -04:00
22f7d92b72
review(Driver.TwinCAT): thread ArrayLength through factory DTO (Medium)
Joseph Doherty
2026-06-19 11:47:11 -04:00
91e2609560
review(Driver.AbLegacy): fix Bit write 1-byte/2-byte encode-decode mismatch (Medium)
Joseph Doherty
2026-06-19 11:47:11 -04:00
be272d960f
review(Driver.OpcUaClient): release browse continuation point on cancel
Joseph Doherty
2026-06-19 11:47:11 -04:00
04e0877bff
review: regenerate code-review index after Batch 5 (Galaxy/AbCip/S7/Modbus/Modbus.Addressing)
Joseph Doherty
2026-06-19 11:34:46 -04:00
b5f6cdfdb9
review(Driver.Modbus.Addressing): fix misleading byte-order hint + drop dead overflow guard
Joseph Doherty
2026-06-19 11:34:35 -04:00
6853a0430f
review(Driver.Modbus): validate FC03 RMW response + correct write error mapping
Joseph Doherty
2026-06-19 11:34:34 -04:00
f2bdd8bc1c
review(Driver.S7): reject writable array tags at init instead of silent write failure
Joseph Doherty
2026-06-19 11:34:34 -04:00
a914b73d57
review(Driver.AbCip): fix declared UDT array members read as scalar (Medium)
Joseph Doherty
2026-06-19 11:34:34 -04:00
db72dd1dca
review(Driver.Galaxy): re-review at HEAD (1 Low deferred; vendoring findings obsolete)
Joseph Doherty
2026-06-19 11:34:34 -04:00
ae3f071945
review: regenerate index after Batch 4 + fix Core.VirtualTags checklist heading
Joseph Doherty
2026-06-19 11:22:56 -04:00
1180b017f5
review(Driver.Cli.Common): drop dead FormatStatus branch + timestamp-kind test
Joseph Doherty
2026-06-19 11:21:36 -04:00
13c1215811
review(Analyzers): add trip-coverage for async guarded-interface methods
Joseph Doherty
2026-06-19 11:21:35 -04:00
6b4210cb17
review(Core.AlarmHistorian): reset drain state on cancel + volatile _disposed
Joseph Doherty
2026-06-19 11:21:35 -04:00
48af117bff
review(Core.VirtualTags): fix Good-null upstream blocking downstream (Medium)
Joseph Doherty
2026-06-19 11:21:35 -04:00
272a9da61e
review(Core.ScriptedAlarms): stop shelving timer on failed reload + drop dead branch
Joseph Doherty
2026-06-19 11:21:35 -04:00
621d00e455
review: regenerate code-review index after Batch 3 (Core/Abstractions/Scripting/Configuration)
Joseph Doherty
2026-06-19 11:07:15 -04:00
c3d148e396
review(Configuration): fix LiteDB global BsonMapper cross-instance race (High)
Joseph Doherty
2026-06-19 11:06:56 -04:00
145b06bec9
review(Core.Scripting.Abstractions): refresh stale Phase7 labels + document {{equip}}
Joseph Doherty
2026-06-19 11:06:56 -04:00
38c48a009c
review(Core.Scripting): block Unsafe.As sandbox bypass (Security)
Joseph Doherty
2026-06-19 11:06:56 -04:00
65e6af6001
review(Core.Abstractions): document ReadEventsAsync continuation contract (OpcUaServer-002 root)
Joseph Doherty
2026-06-19 11:06:56 -04:00
354b0e7613
review(Core): re-review at HEAD; clean up duplicate/unexplained doc comments
Joseph Doherty
2026-06-19 11:06:56 -04:00
8ac5a2dbc5
review: regenerate code-review index after Batch 2 (Runtime/ControlPlane/AdminUI/Browsers)
Joseph Doherty
2026-06-19 10:52:45 -04:00
2fe8e587dd
review(Driver.OpcUaClient.Browser): AttributesAsync updates LastUsedUtc
Joseph Doherty
2026-06-19 10:52:23 -04:00
960d76ffcb
review(Driver.Galaxy.Browser): fix mis-shifted MapSecurityClass codes (High)
Joseph Doherty
2026-06-19 10:52:23 -04:00
3c908f1df0
review(AdminUI): fix null-TagConfig crash, CTS leak, unencoded historian tag
Joseph Doherty
2026-06-19 10:52:23 -04:00
1aa7905676
review(ControlPlane): fix premature deploy-seal from unexpected-node ack
Joseph Doherty
2026-06-19 10:52:22 -04:00
3512089c90
review(Runtime): record findings + fix artifact-decode type tolerance
Joseph Doherty
2026-06-19 10:52:22 -04:00
5aaa82bc26
review: regenerate code-review index after Batch 1 (OpcUaServer/Security/Host/Cluster/Commons)
Joseph Doherty
2026-06-19 10:37:26 -04:00
bac6613dd2
review(OpcUaServer): record findings + fix stale node-manager/host docs
Joseph Doherty
2026-06-19 10:37:00 -04:00
e4abe186a1
review(Host): allow-anonymous /metrics + unconditional LDAP validator
Joseph Doherty
2026-06-19 10:22:59 -04:00
d23e585cdb
review(Security): fix login open-redirect (High) + stale LDAP doc
Joseph Doherty
2026-06-19 10:22:59 -04:00
b1946194d6
review(Cluster): record findings + fix snapshot consistency, dispose, stale docs
Joseph Doherty
2026-06-19 10:22:59 -04:00
6dc74289ce
review(Commons): record findings + add deferred-sink/equip-nodeid tests, fix stale Phase7 doc
Joseph Doherty
2026-06-19 10:22:59 -04:00
7286d3208a
Merge: fix systemic driver-config enum serialization (AdminUI authoring)
Joseph Doherty
2026-06-19 05:20:19 -04:00
a0dccbf8ee
test(drivers): tighten driver-page converter guard + clarify S7 numeric case
Joseph Doherty
2026-06-19 05:06:43 -04:00
4b14feb373
fix(drivers): serialize driver-config enums as strings in AdminUI pages + probes
Joseph Doherty
2026-06-19 04:52:47 -04:00
30c9821fe6
Merge FB-7: surgical DataType/array-shape in-place tag writes
Joseph Doherty
2026-06-19 03:50:03 -04:00
bcba7a4bea
docs(opcua): note FB-7 surgical-shape reach (stable-FullName drivers only)
Joseph Doherty
2026-06-19 03:49:10 -04:00
7a8ae9600b
refactor(opcua): FB-7 review nits — model-event SourceNode=Server, dataType guard, shape tests
Joseph Doherty
2026-06-19 03:30:29 -04:00
fb094fa566
feat(opcua): FB-7 surgical DataType/array-shape in-place tag writes
Joseph Doherty
2026-06-19 03:21:03 -04:00
a325ec54c7
docs(plan): record follow-ups batch execution outcome + live-verify results
Joseph Doherty
2026-06-19 02:45:23 -04:00
85afb678cd
docs(test): mark the audit builder-vs-wiring coverage boundary explicit
Joseph Doherty
2026-06-19 02:22:41 -04:00
d8254630bb
refactor(adminui): trim inline-script label + null-case test + helper-proxy note
Joseph Doherty
2026-06-19 02:16:59 -04:00
36eb14e88d
feat(opcua): emit Bad blip + AuditWriteUpdateEvent + sync fail-fast on failed device write
Joseph Doherty
2026-06-19 02:14:58 -04:00
e047af0553
refactor(adminui): harden SetFullName (reject blank ref) + cover alarm-flag re-pick
Joseph Doherty
2026-06-19 02:08:43 -04:00
da57c307a7
fix(adminui): refresh script dropdown label after inline create
Joseph Doherty
2026-06-19 02:06:51 -04:00
2dd723e195
fix(adminui): preserve edited alarm fields on Galaxy address re-pick
Joseph Doherty
2026-06-19 02:02:06 -04:00
f81fa76809
test(cli): assert Enable/Disable object node + add suffix-idempotency test
Joseph Doherty
2026-06-19 01:57:53 -04:00
eede0c926b
test(opcuaclient): add AcknowledgeAsync stale-session race test + trim fallback delay
Joseph Doherty
2026-06-19 01:56:56 -04:00
6223bc970a
refactor(adminui): tidy cert-audit review nits (fallthrough comment + single PkiStoreRoot read)
Joseph Doherty
2026-06-19 01:51:38 -04:00
88d5ba45bf
feat(cli): add enable/disable condition commands (H4 client path)
Joseph Doherty
2026-06-19 01:48:21 -04:00
eb328e5761
fix(opcuaclient): re-resolve session inside _gate in history/read paths (stale-session race)
Joseph Doherty
2026-06-19 01:41:19 -04:00
ad359c5cd3
docs(plan): design + implementation plan + tasklist for non-arch follow-ups batch (A/B/C)
Joseph Doherty
2026-06-19 01:19:37 -04:00