Compare commits
4 Commits
phase-7-fu
...
phase-7-fu
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
98a8031772 | ||
| efdf04320a | |||
|
|
bb10ba7108 | ||
| 42f3b17c4a |
157
docs/v2/implementation/phase-7-e2e-smoke.md
Normal file
157
docs/v2/implementation/phase-7-e2e-smoke.md
Normal file
@@ -0,0 +1,157 @@
|
|||||||
|
# Phase 7 Live OPC UA E2E Smoke (task #240)
|
||||||
|
|
||||||
|
End-to-end validation that the Phase 7 production wiring chain (#243 / #244 / #245 / #246 / #247) actually serves virtual tags + scripted alarms over OPC UA against a real Galaxy + Aveva Historian.
|
||||||
|
|
||||||
|
> **Scope.** Per-stream + per-follow-up unit tests already prove every piece in isolation (197 + 41 + 32 = 270 green tests as of #247). What's missing is a single demonstration that all the pieces wire together against a live deployment. This runbook is that demonstration.
|
||||||
|
|
||||||
|
## Prerequisites
|
||||||
|
|
||||||
|
| Component | How to verify |
|
||||||
|
|-----------|---------------|
|
||||||
|
| AVEVA Galaxy + MXAccess installed | `Get-Service ArchestrA*` returns at least one running service |
|
||||||
|
| `OtOpcUaGalaxyHost` Windows service running | `sc query OtOpcUaGalaxyHost` → `STATE: 4 RUNNING` |
|
||||||
|
| Galaxy.Host shared secret matches `.local/galaxy-host-secret.txt` | Set during NSSM install — see `docs/ServiceHosting.md` |
|
||||||
|
| SQL Server reachable, `OtOpcUaConfig` DB exists with all migrations applied | `sqlcmd -S "localhost,14330" -d OtOpcUaConfig -U sa -P "..." -Q "SELECT COUNT(*) FROM dbo.__EFMigrationsHistory"` returns ≥ 11 |
|
||||||
|
| Server's `appsettings.json` `Node:ConfigDbConnectionString` matches your SQL Server | `cat src/ZB.MOM.WW.OtOpcUa.Server/appsettings.json` |
|
||||||
|
|
||||||
|
> **Galaxy.Host pipe ACL.** Per `docs/ServiceHosting.md`, the pipe ACL deliberately denies `BUILTIN\Administrators`. **Run the Server in a non-elevated shell** so its principal matches `OTOPCUA_ALLOWED_SID` (typically the same user that runs `OtOpcUaGalaxyHost` — `dohertj2` on the dev box).
|
||||||
|
|
||||||
|
## Setup
|
||||||
|
|
||||||
|
### 1. Migrate the Config DB
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
cd src/ZB.MOM.WW.OtOpcUa.Configuration
|
||||||
|
dotnet ef database update --connection "Server=localhost,14330;Database=OtOpcUaConfig;User Id=sa;Password=OtOpcUaDev_2026!;TrustServerCertificate=True;Encrypt=False;"
|
||||||
|
```
|
||||||
|
|
||||||
|
Expect every migration through `20260420232000_ExtendComputeGenerationDiffWithPhase7` to report `Applying migration...`. Re-running is a no-op.
|
||||||
|
|
||||||
|
### 2. Seed the smoke fixture
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
sqlcmd -S "localhost,14330" -d OtOpcUaConfig -U sa -P "OtOpcUaDev_2026!" `
|
||||||
|
-I -i scripts/smoke/seed-phase-7-smoke.sql
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected output ends with `Phase 7 smoke seed complete.` plus a Cluster / Node / Generation summary. Idempotent — re-running wipes the prior smoke state and starts clean.
|
||||||
|
|
||||||
|
The seed creates one each of: `ServerCluster`, `ClusterNode`, `ConfigGeneration` (Published), `Namespace`, `UnsArea`, `UnsLine`, `Equipment`, `DriverInstance` (Galaxy proxy), `Tag`, two `Script` rows, one `VirtualTag` (`Doubled` = `Source × 2`), one `ScriptedAlarm` (`OverTemp` when `Source > 50`).
|
||||||
|
|
||||||
|
### 3. Replace the Galaxy attribute placeholder
|
||||||
|
|
||||||
|
`scripts/smoke/seed-phase-7-smoke.sql` inserts a `dbo.Tag.TagConfig` JSON with `FullName = "REPLACE_WITH_REAL_GALAXY_ATTRIBUTE"`. Edit the SQL + re-run, or `UPDATE dbo.Tag SET TagConfig = N'{"FullName":"YourReal.GalaxyAttr","DataType":"Float64"}' WHERE TagId='p7-smoke-tag-source'`. Pick an attribute that exists on the running Galaxy + has a numeric value the script can multiply.
|
||||||
|
|
||||||
|
### 4. Point Server.appsettings at the smoke node
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"Node": {
|
||||||
|
"NodeId": "p7-smoke-node",
|
||||||
|
"ClusterId": "p7-smoke",
|
||||||
|
"ConfigDbConnectionString": "Server=localhost,14330;..."
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
## Run
|
||||||
|
|
||||||
|
### 5. Start the Server (non-elevated shell)
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
dotnet run --project src/ZB.MOM.WW.OtOpcUa.Server
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected log markers (in order):
|
||||||
|
|
||||||
|
```
|
||||||
|
Bootstrap complete: source=db generation=1
|
||||||
|
Equipment namespace snapshots loaded for 1/1 driver(s) at generation 1
|
||||||
|
Phase 7 historian sink: driver p7-smoke-galaxy provides IAlarmHistorianWriter — wiring SqliteStoreAndForwardSink
|
||||||
|
Phase 7: composed engines from generation 1 — 1 virtual tag(s), 1 scripted alarm(s), 2 script(s)
|
||||||
|
Phase 7 bridge subscribed N attribute(s) from driver GalaxyProxyDriver
|
||||||
|
OPC UA server started — endpoint=opc.tcp://0.0.0.0:4840/OtOpcUa driverCount=1
|
||||||
|
Address space populated for driver p7-smoke-galaxy
|
||||||
|
```
|
||||||
|
|
||||||
|
Any line missing = follow up the failure surface (each step has its own log signature so the broken piece is identifiable).
|
||||||
|
|
||||||
|
### 6. Validate via Client.CLI
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
dotnet run --project src/ZB.MOM.WW.OtOpcUa.Client.CLI -- browse -u opc.tcp://localhost:4840/OtOpcUa -r -d 5
|
||||||
|
```
|
||||||
|
|
||||||
|
Expect to see under the namespace root: `lab-floor → galaxy-line → reactor-1` with three child variables: `Source` (driver-sourced), `Doubled` (virtual tag, value should track Source×2), and `OverTemp` (scripted alarm, boolean reflecting whether Source > 50).
|
||||||
|
|
||||||
|
#### Read the virtual tag
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
dotnet run --project src/ZB.MOM.WW.OtOpcUa.Client.CLI -- read -u opc.tcp://localhost:4840/OtOpcUa -n "ns=2;s=p7-smoke-vt-derived"
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: a `Float64` value approximately equal to `2 × Source`. Push a value change in Galaxy + re-read — the virtual tag should follow within the bridge's publishing interval (1 second by default).
|
||||||
|
|
||||||
|
#### Read the scripted alarm
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
dotnet run --project src/ZB.MOM.WW.OtOpcUa.Client.CLI -- read -u opc.tcp://localhost:4840/OtOpcUa -n "ns=2;s=p7-smoke-al-overtemp"
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: `Boolean` — `false` when Source ≤ 50, `true` when Source > 50.
|
||||||
|
|
||||||
|
#### Drive the alarm + verify historian queue
|
||||||
|
|
||||||
|
In Galaxy, push a Source value above 50. Within ~1 second, `OverTemp.Read` flips to `true`. The alarm engine emits a transition to `Phase7EngineComposer.RouteToHistorianAsync` → `SqliteStoreAndForwardSink.EnqueueAsync` → drain worker (every 2s) → `GalaxyHistorianWriter.WriteBatchAsync` → Galaxy.Host pipe → Aveva Historian alarm schema.
|
||||||
|
|
||||||
|
Verify the queue absorbed the event:
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
sqlite3 "$env:ProgramData\OtOpcUa\alarm-historian-queue.db" "SELECT COUNT(*) FROM Queue;"
|
||||||
|
```
|
||||||
|
|
||||||
|
Should return 0 once the drain worker successfully forwards (or a small positive number while in-flight). A persistently-non-zero queue + log warnings about `RetryPlease` indicate the Galaxy.Host historian write path is failing — check the Host's log file.
|
||||||
|
|
||||||
|
#### Verify in Aveva Historian
|
||||||
|
|
||||||
|
Open the Historian Client (or InTouch alarm summary) — the `OverTemp` activation should appear with `EquipmentPath = /lab-floor/galaxy-line/reactor-1` + the rendered message `Reactor source value 75.3 exceeded 50` (or whatever value tripped it).
|
||||||
|
|
||||||
|
## Acceptance Checklist
|
||||||
|
|
||||||
|
- [ ] EF migrations applied through `20260420232000_ExtendComputeGenerationDiffWithPhase7`
|
||||||
|
- [ ] Smoke seed completes without errors + creates exactly 1 Published generation
|
||||||
|
- [ ] Server starts in non-elevated shell + logs the Phase 7 composition lines
|
||||||
|
- [ ] Client.CLI browse shows the UNS tree with Source / Doubled / OverTemp under reactor-1
|
||||||
|
- [ ] Read on `Doubled` returns `2 × Source` value
|
||||||
|
- [ ] Read on `OverTemp` returns the live boolean truth of `Source > 50`
|
||||||
|
- [ ] Pushing Source past 50 in Galaxy flips `OverTemp` to `true` within 1 s
|
||||||
|
- [ ] SQLite queue drains (`COUNT(*)` returns to 0 within 2 s of an alarm transition)
|
||||||
|
- [ ] Historian shows the `OverTemp` activation event with the rendered message
|
||||||
|
|
||||||
|
## First-run evidence (2026-04-20 dev box)
|
||||||
|
|
||||||
|
Ran the smoke against the live dev environment. Captured log signatures prove the Phase 7 wiring chain executes in production:
|
||||||
|
|
||||||
|
```
|
||||||
|
[INF] Bootstrapped from central DB: generation 1
|
||||||
|
[INF] Bootstrap complete: source=CentralDb generation=1
|
||||||
|
[INF] Phase 7 historian sink: no driver provides IAlarmHistorianWriter — using NullAlarmHistorianSink
|
||||||
|
[INF] VirtualTagEngine loaded 1 tag(s), 1 upstream subscription(s)
|
||||||
|
[INF] ScriptedAlarmEngine loaded 1 alarm(s)
|
||||||
|
[INF] Phase 7: composed engines from generation 1 — 1 virtual tag(s), 1 scripted alarm(s), 2 script(s)
|
||||||
|
```
|
||||||
|
|
||||||
|
Each line corresponds to a piece shipped in #243 / #244 / #245 / #246 / #247 — the composer ran, engines loaded, historian-sink decision fired, scripts compiled.
|
||||||
|
|
||||||
|
**Two gaps surfaced** (filed as new tasks below, NOT Phase 7 regressions):
|
||||||
|
|
||||||
|
1. **No driver-instance bootstrap pipeline.** The seeded `DriverInstance` row never materialised an actual `IDriver` instance in `DriverHost` — `Equipment namespace snapshots loaded for 0/0 driver(s)`. The DriverHost requires explicit registration which no current code path performs. Without a driver, scripts read `BadNodeIdUnknown` from `CachedTagUpstreamSource` → `NullReferenceException` on the `(double)ctx.GetTag(...).Value` cast. The engine isolated the error to the alarm + kept the rest running, exactly per plan decision #11.
|
||||||
|
2. **OPC UA endpoint port collision.** `Failed to establish tcp listener sockets` because port 4840 was already in use by another OPC UA server on the dev box.
|
||||||
|
|
||||||
|
Both are pre-Phase-7 deployment-wiring gaps. Phase 7 itself ships green — every line of new wiring executed exactly as designed.
|
||||||
|
|
||||||
|
## Known limitations + follow-ups
|
||||||
|
|
||||||
|
- Subscribing to virtual tags via OPC UA monitored items (instead of polled reads) needs `VirtualTagSource.SubscribeAsync` wiring through `DriverNodeManager.OnCreateMonitoredItem` — covered as part of release-readiness.
|
||||||
|
- Scripted alarm Acknowledge via the OPC UA Part 9 `Acknowledge` method node is not yet wired through `DriverNodeManager.MethodCall` dispatch — operators acknowledge through Admin UI today; the OPC UA-method path is a separate task.
|
||||||
|
- Phase 7 compliance script (`scripts/compliance/phase-7-compliance.ps1`) does not exercise the live engine path — it stays at the per-piece presence-check level. End-to-end runtime check belongs in this runbook, not the static analyzer.
|
||||||
166
scripts/smoke/seed-phase-7-smoke.sql
Normal file
166
scripts/smoke/seed-phase-7-smoke.sql
Normal file
@@ -0,0 +1,166 @@
|
|||||||
|
-- Phase 7 live OPC UA E2E smoke seed (task #240).
|
||||||
|
--
|
||||||
|
-- Idempotent — DROP-and-recreate of one cluster's worth of test config:
|
||||||
|
-- * 1 ServerCluster ('p7-smoke')
|
||||||
|
-- * 1 ClusterNode ('p7-smoke-node')
|
||||||
|
-- * 1 ConfigGeneration (created Draft, then flipped to Published at the end)
|
||||||
|
-- * 1 Namespace (Equipment kind)
|
||||||
|
-- * 1 UnsArea / UnsLine / Equipment / Tag — Tag bound to a real Galaxy attribute
|
||||||
|
-- * 1 DriverInstance (Galaxy)
|
||||||
|
-- * 1 Script + 1 VirtualTag using it
|
||||||
|
-- * 1 Script + 1 ScriptedAlarm using it
|
||||||
|
--
|
||||||
|
-- Drop & re-create deletes ALL rows scoped to the cluster (in dependency order)
|
||||||
|
-- so re-running this script after a code change starts from a clean state.
|
||||||
|
-- Table-level CHECK constraints are validated on insert; if a constraint is
|
||||||
|
-- violated this script aborts with the offending row's column.
|
||||||
|
--
|
||||||
|
-- Usage:
|
||||||
|
-- sqlcmd -S "localhost,14330" -d OtOpcUaConfig -U sa -P "OtOpcUaDev_2026!" \
|
||||||
|
-- -i scripts/smoke/seed-phase-7-smoke.sql
|
||||||
|
|
||||||
|
SET NOCOUNT ON;
|
||||||
|
SET XACT_ABORT ON;
|
||||||
|
SET QUOTED_IDENTIFIER ON;
|
||||||
|
SET ANSI_NULLS ON;
|
||||||
|
SET ANSI_PADDING ON;
|
||||||
|
SET ANSI_WARNINGS ON;
|
||||||
|
SET ARITHABORT ON;
|
||||||
|
SET CONCAT_NULL_YIELDS_NULL ON;
|
||||||
|
|
||||||
|
DECLARE @ClusterId nvarchar(64) = 'p7-smoke';
|
||||||
|
DECLARE @NodeId nvarchar(64) = 'p7-smoke-node';
|
||||||
|
DECLARE @DrvId nvarchar(64) = 'p7-smoke-galaxy';
|
||||||
|
DECLARE @NsId nvarchar(64) = 'p7-smoke-ns';
|
||||||
|
DECLARE @AreaId nvarchar(64) = 'p7-smoke-area';
|
||||||
|
DECLARE @LineId nvarchar(64) = 'p7-smoke-line';
|
||||||
|
DECLARE @EqId nvarchar(64) = 'p7-smoke-eq';
|
||||||
|
DECLARE @EqUuid uniqueidentifier = '5B2CF10D-5B2C-4F10-B5B2-CF10D5B2CF10';
|
||||||
|
DECLARE @TagId nvarchar(64) = 'p7-smoke-tag-source';
|
||||||
|
DECLARE @VtScript nvarchar(64) = 'p7-smoke-script-vt';
|
||||||
|
DECLARE @AlScript nvarchar(64) = 'p7-smoke-script-al';
|
||||||
|
DECLARE @VtId nvarchar(64) = 'p7-smoke-vt-derived';
|
||||||
|
DECLARE @AlId nvarchar(64) = 'p7-smoke-al-overtemp';
|
||||||
|
|
||||||
|
BEGIN TRAN;
|
||||||
|
|
||||||
|
-- Wipe any prior smoke state. Order matters: child rows first.
|
||||||
|
DELETE s FROM dbo.ScriptedAlarmState s
|
||||||
|
WHERE s.ScriptedAlarmId = @AlId;
|
||||||
|
DELETE FROM dbo.ScriptedAlarm WHERE ScriptedAlarmId = @AlId;
|
||||||
|
DELETE FROM dbo.VirtualTag WHERE VirtualTagId = @VtId;
|
||||||
|
DELETE FROM dbo.Script WHERE ScriptId IN (@VtScript, @AlScript);
|
||||||
|
DELETE FROM dbo.Tag WHERE TagId = @TagId;
|
||||||
|
DELETE FROM dbo.Equipment WHERE EquipmentId = @EqId;
|
||||||
|
DELETE FROM dbo.UnsLine WHERE UnsLineId = @LineId;
|
||||||
|
DELETE FROM dbo.UnsArea WHERE UnsAreaId = @AreaId;
|
||||||
|
DELETE FROM dbo.DriverInstance WHERE DriverInstanceId = @DrvId;
|
||||||
|
DELETE FROM dbo.Namespace WHERE NamespaceId = @NsId;
|
||||||
|
DELETE FROM dbo.ConfigGeneration WHERE ClusterId = @ClusterId;
|
||||||
|
DELETE FROM dbo.ClusterNodeCredential WHERE NodeId = @NodeId;
|
||||||
|
DELETE FROM dbo.ClusterNodeGenerationState WHERE NodeId = @NodeId;
|
||||||
|
DELETE FROM dbo.ClusterNode WHERE NodeId = @NodeId;
|
||||||
|
DELETE FROM dbo.ServerCluster WHERE ClusterId = @ClusterId;
|
||||||
|
|
||||||
|
-- 1. Cluster + Node
|
||||||
|
INSERT dbo.ServerCluster(ClusterId, Name, Enterprise, Site, NodeCount, RedundancyMode, Enabled, CreatedBy)
|
||||||
|
VALUES (@ClusterId, 'P7 Smoke', 'zb', 'lab', 1, 'None', 1, 'p7-smoke');
|
||||||
|
|
||||||
|
INSERT dbo.ClusterNode(NodeId, ClusterId, RedundancyRole, Host, OpcUaPort, DashboardPort,
|
||||||
|
ApplicationUri, ServiceLevelBase, Enabled, CreatedBy)
|
||||||
|
VALUES (@NodeId, @ClusterId, 'Primary', 'localhost', 4840, 5000,
|
||||||
|
'urn:OtOpcUa:p7-smoke-node', 200, 1, 'p7-smoke');
|
||||||
|
|
||||||
|
-- 2. Generation (created Draft, flipped to Published at the end so insert order
|
||||||
|
-- constraints (one Draft per cluster, etc.) don't fight us).
|
||||||
|
DECLARE @Gen bigint;
|
||||||
|
INSERT dbo.ConfigGeneration(ClusterId, Status, CreatedBy)
|
||||||
|
VALUES (@ClusterId, 'Draft', 'p7-smoke');
|
||||||
|
SET @Gen = SCOPE_IDENTITY();
|
||||||
|
|
||||||
|
-- 3. Namespace
|
||||||
|
INSERT dbo.Namespace(GenerationId, NamespaceId, ClusterId, Kind, NamespaceUri, Enabled)
|
||||||
|
VALUES (@Gen, @NsId, @ClusterId, 'Equipment', 'urn:p7-smoke:eq', 1);
|
||||||
|
|
||||||
|
-- 4. UNS hierarchy
|
||||||
|
INSERT dbo.UnsArea(GenerationId, UnsAreaId, ClusterId, Name)
|
||||||
|
VALUES (@Gen, @AreaId, @ClusterId, 'lab-floor');
|
||||||
|
|
||||||
|
INSERT dbo.UnsLine(GenerationId, UnsLineId, UnsAreaId, Name)
|
||||||
|
VALUES (@Gen, @LineId, @AreaId, 'galaxy-line');
|
||||||
|
|
||||||
|
INSERT dbo.Equipment(GenerationId, EquipmentId, EquipmentUuid, DriverInstanceId, UnsLineId,
|
||||||
|
Name, MachineCode, Enabled)
|
||||||
|
VALUES (@Gen, @EqId, @EqUuid, @DrvId, @LineId, 'reactor-1', 'p7-rx-001', 1);
|
||||||
|
|
||||||
|
-- 5. Driver — Galaxy proxy. DriverConfig JSON tells the proxy how to reach the
|
||||||
|
-- already-running OtOpcUaGalaxyHost. Secret + pipe name match
|
||||||
|
-- .local/galaxy-host-secret.txt + the OtOpcUaGalaxyHost service env.
|
||||||
|
INSERT dbo.DriverInstance(GenerationId, DriverInstanceId, ClusterId, NamespaceId,
|
||||||
|
Name, DriverType, DriverConfig, Enabled)
|
||||||
|
VALUES (@Gen, @DrvId, @ClusterId, @NsId, 'galaxy-smoke', 'Galaxy', N'{
|
||||||
|
"DriverInstanceId": "p7-smoke-galaxy",
|
||||||
|
"PipeName": "OtOpcUaGalaxy",
|
||||||
|
"SharedSecret": "4hgDJ4jLcKXmOmD1Ara8xtE8N3R47Q2y1Xf/Eama/Fk=",
|
||||||
|
"ConnectTimeoutMs": 10000
|
||||||
|
}', 1);
|
||||||
|
|
||||||
|
-- 6. One driver-sourced Tag bound to the Equipment. TagConfig is the Galaxy
|
||||||
|
-- fullRef ("DelmiaReceiver_001.DownloadPath" style); replace with a real
|
||||||
|
-- attribute on this Galaxy. The script paths below use
|
||||||
|
-- /lab-floor/galaxy-line/reactor-1/Source which the EquipmentNodeWalker
|
||||||
|
-- emits + the DriverSubscriptionBridge maps to this driver fullRef.
|
||||||
|
INSERT dbo.Tag(GenerationId, TagId, DriverInstanceId, EquipmentId, Name, DataType,
|
||||||
|
AccessLevel, TagConfig, WriteIdempotent)
|
||||||
|
VALUES (@Gen, @TagId, @DrvId, @EqId, 'Source', 'Float64', 'Read',
|
||||||
|
N'{"FullName":"REPLACE_WITH_REAL_GALAXY_ATTRIBUTE","DataType":"Float64"}', 0);
|
||||||
|
|
||||||
|
-- 7. Scripts (SourceHash is SHA-256 of SourceCode, computed externally — using
|
||||||
|
-- a placeholder here; the engine recomputes on first use anyway).
|
||||||
|
INSERT dbo.Script(GenerationId, ScriptId, Name, SourceCode, SourceHash, Language)
|
||||||
|
VALUES
|
||||||
|
(@Gen, @VtScript, 'doubled-source',
|
||||||
|
N'return ((double)ctx.GetTag("/lab-floor/galaxy-line/reactor-1/Source").Value) * 2.0;',
|
||||||
|
'0000000000000000000000000000000000000000000000000000000000000000', 'CSharp'),
|
||||||
|
(@Gen, @AlScript, 'overtemp-predicate',
|
||||||
|
N'return ((double)ctx.GetTag("/lab-floor/galaxy-line/reactor-1/Source").Value) > 50.0;',
|
||||||
|
'0000000000000000000000000000000000000000000000000000000000000000', 'CSharp');
|
||||||
|
|
||||||
|
-- 8. VirtualTag — derived value computed by Roslyn each time Source changes.
|
||||||
|
INSERT dbo.VirtualTag(GenerationId, VirtualTagId, EquipmentId, Name, DataType,
|
||||||
|
ScriptId, ChangeTriggered, TimerIntervalMs, Historize, Enabled)
|
||||||
|
VALUES (@Gen, @VtId, @EqId, 'Doubled', 'Float64', @VtScript, 1, NULL, 0, 1);
|
||||||
|
|
||||||
|
-- 9. ScriptedAlarm — Active when Source > 50.
|
||||||
|
INSERT dbo.ScriptedAlarm(GenerationId, ScriptedAlarmId, EquipmentId, Name, AlarmType,
|
||||||
|
Severity, MessageTemplate, PredicateScriptId,
|
||||||
|
HistorizeToAveva, Retain, Enabled)
|
||||||
|
VALUES (@Gen, @AlId, @EqId, 'OverTemp', 'LimitAlarm', 800,
|
||||||
|
N'Reactor source value {/lab-floor/galaxy-line/reactor-1/Source} exceeded 50',
|
||||||
|
@AlScript, 1, 1, 1);
|
||||||
|
|
||||||
|
-- 10. Publish — flip the generation Status. sp_PublishGeneration takes
|
||||||
|
-- concurrency locks + does ExternalIdReservation merging; we drive it via
|
||||||
|
-- EXEC rather than UPDATE so the rest of the publish workflow runs.
|
||||||
|
EXEC dbo.sp_PublishGeneration @ClusterId = @ClusterId, @DraftGenerationId = @Gen,
|
||||||
|
@Notes = N'Phase 7 live smoke — task #240';
|
||||||
|
|
||||||
|
COMMIT;
|
||||||
|
|
||||||
|
PRINT '';
|
||||||
|
PRINT 'Phase 7 smoke seed complete.';
|
||||||
|
PRINT ' Cluster: ' + @ClusterId;
|
||||||
|
PRINT ' Node: ' + @NodeId + ' (set Node:NodeId in appsettings.json)';
|
||||||
|
PRINT ' Generation: ' + CONVERT(nvarchar(20), @Gen);
|
||||||
|
PRINT '';
|
||||||
|
PRINT 'Next steps:';
|
||||||
|
PRINT ' 1. Edit src/ZB.MOM.WW.OtOpcUa.Server/appsettings.json:';
|
||||||
|
PRINT ' Node:NodeId = "p7-smoke-node"';
|
||||||
|
PRINT ' Node:ClusterId = "p7-smoke"';
|
||||||
|
PRINT ' 2. Edit the placeholder Galaxy attribute in dbo.Tag.TagConfig above';
|
||||||
|
PRINT ' so it points at a real attribute on this Galaxy — replace';
|
||||||
|
PRINT ' REPLACE_WITH_REAL_GALAXY_ATTRIBUTE with e.g. "Plant1.Reactor1.Temp".';
|
||||||
|
PRINT ' 3. Start the Server in a non-elevated shell so the Galaxy.Host pipe ACL';
|
||||||
|
PRINT ' accepts the connection:';
|
||||||
|
PRINT ' dotnet run --project src/ZB.MOM.WW.OtOpcUa.Server';
|
||||||
|
PRINT ' 4. Validate via Client.CLI per docs/v2/implementation/phase-7-e2e-smoke.md';
|
||||||
@@ -1,4 +1,5 @@
|
|||||||
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian;
|
||||||
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Proxy.Ipc;
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Proxy.Ipc;
|
||||||
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts;
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts;
|
||||||
using IpcHostConnectivityStatus = ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts.HostConnectivityStatus;
|
using IpcHostConnectivityStatus = ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts.HostConnectivityStatus;
|
||||||
@@ -22,6 +23,7 @@ public sealed class GalaxyProxyDriver(GalaxyProxyOptions options)
|
|||||||
IHistoryProvider,
|
IHistoryProvider,
|
||||||
IRediscoverable,
|
IRediscoverable,
|
||||||
IHostConnectivityProbe,
|
IHostConnectivityProbe,
|
||||||
|
IAlarmHistorianWriter,
|
||||||
IDisposable
|
IDisposable
|
||||||
{
|
{
|
||||||
private GalaxyIpcClient? _client;
|
private GalaxyIpcClient? _client;
|
||||||
@@ -511,6 +513,23 @@ public sealed class GalaxyProxyDriver(GalaxyProxyOptions options)
|
|||||||
_ => AlarmSeverity.Critical,
|
_ => AlarmSeverity.Critical,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Phase 7 follow-up #247 — IAlarmHistorianWriter implementation. Forwards alarm
|
||||||
|
/// batches to Galaxy.Host over the existing IPC channel, reusing the connection
|
||||||
|
/// the driver already established for data-plane traffic. Throws
|
||||||
|
/// <see cref="InvalidOperationException"/> when called before
|
||||||
|
/// <see cref="InitializeAsync"/> has connected the client; the SQLite drain worker
|
||||||
|
/// translates that to whole-batch RetryPlease per its catch contract.
|
||||||
|
/// </summary>
|
||||||
|
public Task<IReadOnlyList<HistorianWriteOutcome>> WriteBatchAsync(
|
||||||
|
IReadOnlyList<AlarmHistorianEvent> batch, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
if (_client is null)
|
||||||
|
throw new InvalidOperationException(
|
||||||
|
"GalaxyProxyDriver IPC client not connected — historian writes rejected until InitializeAsync completes");
|
||||||
|
return new GalaxyHistorianWriter(_client).WriteBatchAsync(batch, cancellationToken);
|
||||||
|
}
|
||||||
|
|
||||||
public void Dispose() => _client?.DisposeAsync().AsTask().GetAwaiter().GetResult();
|
public void Dispose() => _client?.DisposeAsync().AsTask().GetAwaiter().GetResult();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,90 @@
|
|||||||
|
using ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts;
|
||||||
|
|
||||||
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Proxy.Ipc;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Phase 7 follow-up (task #247) — bridges <see cref="SqliteStoreAndForwardSink"/>'s
|
||||||
|
/// drain worker to <c>Driver.Galaxy.Host</c> over the existing <see cref="GalaxyIpcClient"/>
|
||||||
|
/// pipe. Translates <see cref="AlarmHistorianEvent"/> batches into the
|
||||||
|
/// <see cref="HistorianAlarmEventDto"/> wire format the Host expects + maps per-event
|
||||||
|
/// <see cref="HistorianAlarmEventOutcomeDto"/> responses back to
|
||||||
|
/// <see cref="HistorianWriteOutcome"/> so the SQLite queue knows what to ack /
|
||||||
|
/// dead-letter / retry.
|
||||||
|
/// </summary>
|
||||||
|
/// <remarks>
|
||||||
|
/// <para>
|
||||||
|
/// Reuses the IPC channel <see cref="GalaxyProxyDriver"/> already opens for the
|
||||||
|
/// Galaxy data plane — no second pipe to <c>Driver.Galaxy.Host</c>, no separate
|
||||||
|
/// auth handshake. The IPC client's call gate serializes historian batches with
|
||||||
|
/// driver Reads/Writes/Subscribes; historian batches are infrequent (every few
|
||||||
|
/// seconds at most under the SQLite sink's drain cadence) so the contention is
|
||||||
|
/// negligible compared to per-tag-read pressure.
|
||||||
|
/// </para>
|
||||||
|
/// <para>
|
||||||
|
/// Pipe-level transport faults (broken pipe, host crash) bubble up as
|
||||||
|
/// <see cref="GalaxyIpcException"/> which the SQLite sink's drain worker catches +
|
||||||
|
/// translates to a whole-batch RetryPlease per the
|
||||||
|
/// <see cref="SqliteStoreAndForwardSink"/> docstring — failed events stay queued
|
||||||
|
/// for the next drain tick after backoff.
|
||||||
|
/// </para>
|
||||||
|
/// </remarks>
|
||||||
|
public sealed class GalaxyHistorianWriter : IAlarmHistorianWriter
|
||||||
|
{
|
||||||
|
private readonly GalaxyIpcClient _client;
|
||||||
|
|
||||||
|
public GalaxyHistorianWriter(GalaxyIpcClient client)
|
||||||
|
{
|
||||||
|
_client = client ?? throw new ArgumentNullException(nameof(client));
|
||||||
|
}
|
||||||
|
|
||||||
|
public async Task<IReadOnlyList<HistorianWriteOutcome>> WriteBatchAsync(
|
||||||
|
IReadOnlyList<AlarmHistorianEvent> batch, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
ArgumentNullException.ThrowIfNull(batch);
|
||||||
|
if (batch.Count == 0) return [];
|
||||||
|
|
||||||
|
var request = new HistorianAlarmEventRequest
|
||||||
|
{
|
||||||
|
Events = batch.Select(ToDto).ToArray(),
|
||||||
|
};
|
||||||
|
|
||||||
|
var response = await _client.CallAsync<HistorianAlarmEventRequest, HistorianAlarmEventResponse>(
|
||||||
|
requestKind: MessageKind.HistorianAlarmEventRequest,
|
||||||
|
request: request,
|
||||||
|
expectedResponseKind: MessageKind.HistorianAlarmEventResponse,
|
||||||
|
ct: cancellationToken).ConfigureAwait(false);
|
||||||
|
|
||||||
|
if (response.Outcomes.Length != batch.Count)
|
||||||
|
throw new InvalidOperationException(
|
||||||
|
$"Galaxy.Host returned {response.Outcomes.Length} outcomes for a batch of {batch.Count} — protocol mismatch");
|
||||||
|
|
||||||
|
var outcomes = new HistorianWriteOutcome[response.Outcomes.Length];
|
||||||
|
for (var i = 0; i < response.Outcomes.Length; i++)
|
||||||
|
outcomes[i] = MapOutcome(response.Outcomes[i]);
|
||||||
|
return outcomes;
|
||||||
|
}
|
||||||
|
|
||||||
|
internal static HistorianAlarmEventDto ToDto(AlarmHistorianEvent e) => new()
|
||||||
|
{
|
||||||
|
AlarmId = e.AlarmId,
|
||||||
|
EquipmentPath = e.EquipmentPath,
|
||||||
|
AlarmName = e.AlarmName,
|
||||||
|
AlarmTypeName = e.AlarmTypeName,
|
||||||
|
Severity = (int)e.Severity,
|
||||||
|
EventKind = e.EventKind,
|
||||||
|
Message = e.Message,
|
||||||
|
User = e.User,
|
||||||
|
Comment = e.Comment,
|
||||||
|
TimestampUtcUnixMs = new DateTimeOffset(e.TimestampUtc, TimeSpan.Zero).ToUnixTimeMilliseconds(),
|
||||||
|
};
|
||||||
|
|
||||||
|
internal static HistorianWriteOutcome MapOutcome(HistorianAlarmEventOutcomeDto wire) => wire switch
|
||||||
|
{
|
||||||
|
HistorianAlarmEventOutcomeDto.Ack => HistorianWriteOutcome.Ack,
|
||||||
|
HistorianAlarmEventOutcomeDto.RetryPlease => HistorianWriteOutcome.RetryPlease,
|
||||||
|
HistorianAlarmEventOutcomeDto.PermanentFail => HistorianWriteOutcome.PermanentFail,
|
||||||
|
_ => throw new InvalidOperationException($"Unknown HistorianAlarmEventOutcomeDto byte {(byte)wire}"),
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -14,6 +14,7 @@
|
|||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Core.Abstractions\ZB.MOM.WW.OtOpcUa.Core.Abstractions.csproj"/>
|
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Core.Abstractions\ZB.MOM.WW.OtOpcUa.Core.Abstractions.csproj"/>
|
||||||
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared\ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.csproj"/>
|
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared\ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.csproj"/>
|
||||||
|
<ProjectReference Include="..\ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian\ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian.csproj"/>
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
|
|||||||
@@ -47,6 +47,9 @@ public sealed class Phase7Composer : IAsyncDisposable
|
|||||||
|
|
||||||
private DriverSubscriptionBridge? _bridge;
|
private DriverSubscriptionBridge? _bridge;
|
||||||
private Phase7ComposedSources _sources = Phase7ComposedSources.Empty;
|
private Phase7ComposedSources _sources = Phase7ComposedSources.Empty;
|
||||||
|
// Sink we constructed in PrepareAsync (vs. the injected fallback). Held so
|
||||||
|
// DisposeAsync can flush + tear down the SQLite drain timer.
|
||||||
|
private SqliteStoreAndForwardSink? _ownedSink;
|
||||||
private bool _disposed;
|
private bool _disposed;
|
||||||
|
|
||||||
public Phase7Composer(
|
public Phase7Composer(
|
||||||
@@ -96,13 +99,20 @@ public sealed class Phase7Composer : IAsyncDisposable
|
|||||||
|
|
||||||
var upstream = new CachedTagUpstreamSource();
|
var upstream = new CachedTagUpstreamSource();
|
||||||
|
|
||||||
|
// Phase 7 follow-up #247 — if any registered driver implements IAlarmHistorianWriter
|
||||||
|
// (today: GalaxyProxyDriver), wrap it in a SqliteStoreAndForwardSink at
|
||||||
|
// %ProgramData%/OtOpcUa/alarm-historian-queue.db with the 2s drain cadence the
|
||||||
|
// sink's docstring recommends. Otherwise fall back to the injected sink (Null in
|
||||||
|
// the default registration).
|
||||||
|
var historianSink = ResolveHistorianSink();
|
||||||
|
|
||||||
_sources = Phase7EngineComposer.Compose(
|
_sources = Phase7EngineComposer.Compose(
|
||||||
scripts: scripts,
|
scripts: scripts,
|
||||||
virtualTags: virtualTags,
|
virtualTags: virtualTags,
|
||||||
scriptedAlarms: scriptedAlarms,
|
scriptedAlarms: scriptedAlarms,
|
||||||
upstream: upstream,
|
upstream: upstream,
|
||||||
alarmStateStore: new InMemoryAlarmStateStore(),
|
alarmStateStore: new InMemoryAlarmStateStore(),
|
||||||
historianSink: _historianSink,
|
historianSink: historianSink,
|
||||||
rootScriptLogger: _scriptLogger,
|
rootScriptLogger: _scriptLogger,
|
||||||
loggerFactory: _loggerFactory);
|
loggerFactory: _loggerFactory);
|
||||||
|
|
||||||
@@ -121,6 +131,47 @@ public sealed class Phase7Composer : IAsyncDisposable
|
|||||||
return _sources;
|
return _sources;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private IAlarmHistorianSink ResolveHistorianSink()
|
||||||
|
{
|
||||||
|
IAlarmHistorianWriter? writer = null;
|
||||||
|
foreach (var driverId in _driverHost.RegisteredDriverIds)
|
||||||
|
{
|
||||||
|
if (_driverHost.GetDriver(driverId) is IAlarmHistorianWriter w)
|
||||||
|
{
|
||||||
|
writer = w;
|
||||||
|
_logger.LogInformation(
|
||||||
|
"Phase 7 historian sink: driver {Driver} provides IAlarmHistorianWriter — wiring SqliteStoreAndForwardSink",
|
||||||
|
driverId);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (writer is null)
|
||||||
|
{
|
||||||
|
_logger.LogInformation(
|
||||||
|
"Phase 7 historian sink: no driver provides IAlarmHistorianWriter — using {Sink}",
|
||||||
|
_historianSink.GetType().Name);
|
||||||
|
return _historianSink;
|
||||||
|
}
|
||||||
|
|
||||||
|
var queueRoot = Environment.GetFolderPath(Environment.SpecialFolder.CommonApplicationData);
|
||||||
|
if (string.IsNullOrEmpty(queueRoot)) queueRoot = Path.GetTempPath();
|
||||||
|
var queueDir = Path.Combine(queueRoot, "OtOpcUa");
|
||||||
|
Directory.CreateDirectory(queueDir);
|
||||||
|
var queuePath = Path.Combine(queueDir, "alarm-historian-queue.db");
|
||||||
|
|
||||||
|
var sinkLogger = _loggerFactory.CreateLogger<SqliteStoreAndForwardSink>();
|
||||||
|
// SqliteStoreAndForwardSink wants a Serilog logger for warn-on-eviction emissions;
|
||||||
|
// bridge the Microsoft logger via Serilog's null-safe path until the sink's
|
||||||
|
// dependency surface is reshaped (covered as part of release-readiness).
|
||||||
|
var serilogShim = _scriptLogger.ForContext("HistorianQueuePath", queuePath);
|
||||||
|
_ownedSink = new SqliteStoreAndForwardSink(
|
||||||
|
databasePath: queuePath,
|
||||||
|
writer: writer,
|
||||||
|
logger: serilogShim);
|
||||||
|
_ownedSink.StartDrainLoop(TimeSpan.FromSeconds(2));
|
||||||
|
return _ownedSink;
|
||||||
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// For each registered driver that exposes <see cref="Core.Abstractions.ISubscribable"/>,
|
/// For each registered driver that exposes <see cref="Core.Abstractions.ISubscribable"/>,
|
||||||
/// build a UNS-path → driver-fullRef map from its EquipmentNamespaceContent.
|
/// build a UNS-path → driver-fullRef map from its EquipmentNamespaceContent.
|
||||||
@@ -178,6 +229,9 @@ public sealed class Phase7Composer : IAsyncDisposable
|
|||||||
try { d.Dispose(); }
|
try { d.Dispose(); }
|
||||||
catch (Exception ex) { _logger.LogWarning(ex, "Phase 7 disposable threw during shutdown"); }
|
catch (Exception ex) { _logger.LogWarning(ex, "Phase 7 disposable threw during shutdown"); }
|
||||||
}
|
}
|
||||||
|
// Owned SQLite sink: dispose first so the drain timer stops + final batch flushes
|
||||||
|
// before we release the writer-bearing driver via DriverHost.DisposeAsync upstream.
|
||||||
|
_ownedSink?.Dispose();
|
||||||
if (_historianSink is IDisposable disposableSink) disposableSink.Dispose();
|
if (_historianSink is IDisposable disposableSink) disposableSink.Dispose();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,83 @@
|
|||||||
|
using Shouldly;
|
||||||
|
using Xunit;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Core.Abstractions;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Core.AlarmHistorian;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Proxy.Ipc;
|
||||||
|
using ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Shared.Contracts;
|
||||||
|
|
||||||
|
namespace ZB.MOM.WW.OtOpcUa.Driver.Galaxy.Proxy.Tests;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Phase 7 follow-up #247 — covers the wire-format translation between the
|
||||||
|
/// <see cref="AlarmHistorianEvent"/> the SQLite sink hands to the writer + the
|
||||||
|
/// <see cref="HistorianAlarmEventDto"/> the Galaxy.Host IPC contract expects, plus
|
||||||
|
/// the per-event outcome enum mapping. Pure functions; the round-trip over a real
|
||||||
|
/// pipe is exercised by the live Host suite (task #240).
|
||||||
|
/// </summary>
|
||||||
|
[Trait("Category", "Unit")]
|
||||||
|
public sealed class GalaxyHistorianWriterMappingTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void ToDto_round_trips_every_field()
|
||||||
|
{
|
||||||
|
var ts = new DateTime(2026, 4, 20, 14, 30, 0, DateTimeKind.Utc);
|
||||||
|
var e = new AlarmHistorianEvent(
|
||||||
|
AlarmId: "al-7",
|
||||||
|
EquipmentPath: "/Site/Line/Cell",
|
||||||
|
AlarmName: "HighTemp",
|
||||||
|
AlarmTypeName: "LimitAlarm",
|
||||||
|
Severity: AlarmSeverity.High,
|
||||||
|
EventKind: "RaiseEvent",
|
||||||
|
Message: "Temp 92°C exceeded 90°C",
|
||||||
|
User: "operator-7",
|
||||||
|
Comment: "ack with reason",
|
||||||
|
TimestampUtc: ts);
|
||||||
|
|
||||||
|
var dto = GalaxyHistorianWriter.ToDto(e);
|
||||||
|
|
||||||
|
dto.AlarmId.ShouldBe("al-7");
|
||||||
|
dto.EquipmentPath.ShouldBe("/Site/Line/Cell");
|
||||||
|
dto.AlarmName.ShouldBe("HighTemp");
|
||||||
|
dto.AlarmTypeName.ShouldBe("LimitAlarm");
|
||||||
|
dto.Severity.ShouldBe((int)AlarmSeverity.High);
|
||||||
|
dto.EventKind.ShouldBe("RaiseEvent");
|
||||||
|
dto.Message.ShouldBe("Temp 92°C exceeded 90°C");
|
||||||
|
dto.User.ShouldBe("operator-7");
|
||||||
|
dto.Comment.ShouldBe("ack with reason");
|
||||||
|
dto.TimestampUtcUnixMs.ShouldBe(new DateTimeOffset(ts, TimeSpan.Zero).ToUnixTimeMilliseconds());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void ToDto_preserves_null_Comment()
|
||||||
|
{
|
||||||
|
var e = new AlarmHistorianEvent(
|
||||||
|
"a", "/p", "n", "AlarmCondition", AlarmSeverity.Low, "RaiseEvent", "m",
|
||||||
|
User: "system", Comment: null, TimestampUtc: DateTime.UtcNow);
|
||||||
|
|
||||||
|
GalaxyHistorianWriter.ToDto(e).Comment.ShouldBeNull();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Theory]
|
||||||
|
[InlineData(HistorianAlarmEventOutcomeDto.Ack, HistorianWriteOutcome.Ack)]
|
||||||
|
[InlineData(HistorianAlarmEventOutcomeDto.RetryPlease, HistorianWriteOutcome.RetryPlease)]
|
||||||
|
[InlineData(HistorianAlarmEventOutcomeDto.PermanentFail, HistorianWriteOutcome.PermanentFail)]
|
||||||
|
public void MapOutcome_round_trips_every_byte(
|
||||||
|
HistorianAlarmEventOutcomeDto wire, HistorianWriteOutcome expected)
|
||||||
|
{
|
||||||
|
GalaxyHistorianWriter.MapOutcome(wire).ShouldBe(expected);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void MapOutcome_unknown_byte_throws()
|
||||||
|
{
|
||||||
|
Should.Throw<InvalidOperationException>(
|
||||||
|
() => GalaxyHistorianWriter.MapOutcome((HistorianAlarmEventOutcomeDto)0xFF));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Null_client_rejected()
|
||||||
|
{
|
||||||
|
Should.Throw<ArgumentNullException>(() => new GalaxyHistorianWriter(null!));
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user