lmxopcua

Author SHA1 Message Date

Author	SHA1	Message	Date
Joseph Doherty	ab57e53b92	fix(code-review): resolve Batch 2 open findings (AbCip, AbLegacy, Galaxy, FOCAS) - Driver.AbCip.Contracts-001: parse 'writable' from TagConfig JSON (default true) instead of hardcoding - Driver.AbCip.Contracts-002/-003: Dt type comment; drop dead [Display]/[Range] annotations - Driver.AbCip.Contracts-004: dedicated AbCipEquipmentTagParser test class (+15) - Driver.AbCip-017: document Tick severity Low-fallback on Bad severity read - Driver.AbLegacy.Contracts-002/-003/-004: isArray-scalar remarks (+tests), MaxTagBytes/ForFamily docs - Driver.Galaxy.Browser-003 + Driver.Galaxy.Contracts-003: extract ResolveApiKey -> GalaxySecretRef (dedup) - Driver.Galaxy-019: cache buffered-interval only on Ok + ILogger warnings + ClassifyIntervalReply (+tests) - Driver.FOCAS.Contracts-002: thread WriteIdempotent through DiscoverAsync (+test)	2026-06-20 22:43:36 -04:00
Joseph Doherty	45711e437d	review(Driver.Galaxy.Contracts): first review; [Range] guard on EventPumpChannelCapacity First review at `7286d320`. -002 (Medium) fixed: EventPumpChannelCapacity now [Range(1,..)] (a 0 passed AdminUI validation but faulted the driver at InitializeAsync). -001 stale finding-id doc fixed. -003 ResolveApiKey dedup Open (3-module coordination).	2026-06-19 12:22:53 -04:00

Joseph Doherty

ab57e53b92

fix(code-review): resolve Batch 2 open findings (AbCip, AbLegacy, Galaxy, FOCAS)

- Driver.AbCip.Contracts-001: parse 'writable' from TagConfig JSON (default true) instead of hardcoding
- Driver.AbCip.Contracts-002/-003: Dt type comment; drop dead [Display]/[Range] annotations
- Driver.AbCip.Contracts-004: dedicated AbCipEquipmentTagParser test class (+15)
- Driver.AbCip-017: document Tick severity Low-fallback on Bad severity read
- Driver.AbLegacy.Contracts-002/-003/-004: isArray-scalar remarks (+tests), MaxTagBytes/ForFamily docs
- Driver.Galaxy.Browser-003 + Driver.Galaxy.Contracts-003: extract ResolveApiKey -> GalaxySecretRef (dedup)
- Driver.Galaxy-019: cache buffered-interval only on Ok + ILogger warnings + ClassifyIntervalReply (+tests)
- Driver.FOCAS.Contracts-002: thread WriteIdempotent through DiscoverAsync (+test)

2026-06-20 22:43:36 -04:00

Joseph Doherty

45711e437d

review(Driver.Galaxy.Contracts): first review; [Range] guard on EventPumpChannelCapacity

First review at 7286d320. -002 (Medium) fixed: EventPumpChannelCapacity now [Range(1,..)]
(a 0 passed AdminUI validation but faulted the driver at InitializeAsync). -001 stale finding-id
doc fixed. -003 ResolveApiKey dedup Open (3-module coordination).

2026-06-19 12:22:53 -04:00

2 Commits