7 Commits

Author	SHA1	Message	Date
Joseph Doherty	dc0d7653b9	feat(v3-batch3): B3-WP4 — {{equip}}/<RefName> reference-relative resolution ... Replace the deleted equipment-base-prefix {{equip}} mechanism (impossible now that equipment is reference-only) with per-reference resolution: {{equip}}/<RefName> resolves through the owning equipment's UnsTagReference rows (by effective name) to the backing raw tag's RawPath. Every unresolved <RefName> is a clear deploy error + authoring rejection + Monaco diagnostic — preserving "editor accepts <=> publish accepts". Commons: - EquipmentScriptPaths: delete DeriveEquipmentBase; SubstituteEquipmentToken now takes the equipment's reference map (effectiveName -> RawPath) and substitutes {{equip}}/<RefName> inside path literals (unresolved left intact, never throws); add ExtractEquipReferenceNames (path-literal scoped) + ExtractEquipReferenceNamesFromText (message templates). Slash syntax replaces the v2 dot joint. - New EquipmentReferenceMap: shared, input-shape-agnostic builder (entity + JSON sides) over RawPathResolver — the single authority both compose seams + the validator use, so resolved RawPaths agree byte-for-byte. Compose seams (byte-parity kept): - AddressSpaceComposer.Compose + DeploymentArtifact.ParseComposition both build the per-equipment reference map from UnsTagReferences + Tags + raw topology and substitute VirtualTag AND ScriptedAlarm-predicate sources before dependency extraction (runtime dep refs = resolved RawPaths). Deploy gate + authoring + editor: - DraftValidator.ValidateEquipReferenceResolution: EquipReferenceUnresolved error for unresolved {{equip}}/<RefName> in VirtualTag/ScriptedAlarm scripts + alarm message-template tokens (naming script, equipment, missing ref). - UnsTreeService.ValidateEquipTokenAsync (Wave-A M1): reference-relative authoring rejection, replacing the stale DeriveEquipmentBase(empty)->reject-all logic. - ScriptAnalysisService: {{equip}}/ completion offers the equipment's reference effective names; DiagnoseAsync flags unresolved refs (OTSCRIPT_EQUIPREF) same as the deploy gate. Requests carry optional EquipmentId (threaded MonacoEditor -> monaco-init.js -> fetch bodies). IScriptTagCatalog.GetEquipmentRelativeLeavesAsync repurposed to GetEquipmentReferenceNamesAsync(equipmentId, filter). Tests: EquipmentScriptPaths substitution/extraction (slash pinned); composer<-> artifact reference-resolution byte-parity; DraftValidator unresolved-ref; ScriptAnalysis completion+diagnostic; M1 authoring gate. Build clean (0/0); all five affected suites green. Claude-Session: https://claude.ai/code/session_01LVneM3eh1UtJxEisFXgmox	2026-07-16 06:58:17 -04:00
Joseph Doherty	688a003d1d	fix(adminui): tag-path completion replaces the whole dotted path, not just the last segment ... Monaco's word definition splits on '.', so accepting a full tag path while a partial path was typed (e.g. "X.Protected") duplicated the prefix (-> "X.X.ProtectedValue"). Tag-path items now replace the whole literal content from the opening quote to the caret.	2026-06-09 17:06:55 -04:00
Joseph Doherty	da80195599	fix(adminui): render Monaco overflow widgets in a body-level node ... The suggest/hover popups were offset far from the caret because the theme's .rise entrance animation leaves a CSS transform on an ancestor, which becomes the containing block for the position:fixed overflow widgets. Render them in a body-level overflowWidgetsDomNode so they stay viewport-correct at the caret.	2026-06-09 17:01:18 -04:00
Joseph Doherty	72fcde5b44	fix(adminui): auto-suggest tag paths inside string literals (quickSuggestions.strings)	2026-06-09 15:46:30 -04:00
Joseph Doherty	9444348c0d	fix(adminui): forward insertTextRules + correct Monaco completion-kind icons	2026-06-09 15:31:16 -04:00
Joseph Doherty	071bed5f94	feat(adminui): wire Monaco language providers to /api/script-analysis	2026-06-09 15:09:06 -04:00
Joseph Doherty	9afb2d230e	feat(adminui): vendor Monaco + reusable MonacoEditor component (no providers yet)	2026-06-09 14:06:29 -04:00