6 Commits

Author	SHA1	Message	Date
Joseph Doherty	b31d7cb03f	fix(scripted-alarms): lock CreateVariable + RemoveRootNotifier on rebuild (T14 review)	2026-06-10 19:26:01 -04:00
Joseph Doherty	60d48a2a0a	feat(scripted-alarms): materialise real Part 9 AlarmConditionState nodes (T14)	2026-06-10 19:19:10 -04:00
Joseph Doherty	64e3fbe035	docs: backfill XML documentation across 756 files ... Adds <summary>, <param>, <typeparam>, and <inheritdoc/> tags to public members surfaced by commentchecker — resolves 5,847 of 5,869 issues (99.6%) across three /fixdocs passes.	2026-05-28 08:10:17 -04:00
Joseph Doherty	7dfbca6469	feat(opcua): materialise SystemPlatform tags (Galaxy) as OPC UA variables ... Closes the gap where Tag rows with EquipmentId=NULL + Namespace.Kind=SystemPlatform (Galaxy hierarchy) existed in ConfigDb but were never surfaced in the OPC UA address space. Now they materialise as Variable nodes under a folder named for their FolderPath, browseable through any OPC UA client. Layers touched: - IOpcUaAddressSpaceSink: new EnsureVariable(nodeId, parentFolderId, displayName, dataType) signature on the sink interface, NullSink, DeferredSink, SdkSink. - OtOpcUaNodeManager.EnsureVariable: creates a BaseDataVariableState parented under the named folder (or root), initial Value=null + StatusCode=BadWaitingForInitialData; resolves Tag.DataType strings to the matching OPC UA built-in NodeId. Idempotent. - Phase7CompositionResult: new GalaxyTags collection of GalaxyTagPlan records carrying (TagId, DriverInstanceId, FolderPath, DisplayName, DataType, MxAccessRef). Constructor overloads keep existing call sites compiling. - Phase7Composer.Compose: now takes Tag + Namespace inputs, filters for SystemPlatform-namespace tags with EquipmentId=NULL, emits GalaxyTagPlan rows with MXAccess ref "FolderPath.Name". - Phase7Plan: new AddedGalaxyTags / RemovedGalaxyTags / ChangedGalaxyTags collections + GalaxyTagDelta record; IsEmpty + needsRebuild updated. - Phase7Planner.Compute: diffs GalaxyTags by TagId via existing DiffById helper. - DeploymentArtifact.ParseComposition: reads the Tags + Namespaces + DriverInstances arrays the ConfigComposer already emits, applies the same SystemPlatform filter, returns the same GalaxyTagPlan list as the composer so artifact-side and compose-side plans agree. - Phase7Applier: new MaterialiseGalaxyTags pass that ensures one folder per distinct FolderPath then one Variable per tag. NodeId for the variable is "<FolderPath>.<Name>" matching the MXAccess ref so the future Galaxy SubscribeBulk wiring can address them directly. - OpcUaPublishActor.RebuildAddressSpace: invokes MaterialiseGalaxyTags after MaterialiseHierarchy. _lastApplied initialiser updated for the new ctor. - seed-clusters.sql: pre-existing TestMachine_001.TestAlarm001..003 rows needed no change — the composer/applier now picks them up automatically. Verified end-to-end via docker-dev: deploy click → driver-a logs "Phase7Applier: Galaxy tags materialised (tags=3, folders=1)" → OPC UA Client CLI browses the three Variable nodes under TestMachine_001 folder. Reads return BadWaitingForInitialData status (expected — Galaxy driver's SubscribeBulk wiring to push values into the nodes is the remaining follow-up).	2026-05-26 15:43:22 -04:00
Joseph Doherty	607dc51dec	feat(opcua): #85 UNS Area/Line/Equipment folder hierarchy in SDK ... Phase7Composer now carries UnsAreaProjection + UnsLineProjection lists so the applier can materialise the full UNS topology in the OPC UA address space. New IOpcUaAddressSpaceSink.EnsureFolder(folderNodeId, parentNodeId, displayName) seam (no-op default, recorded in tests, forwarded by DeferredAddressSpaceSink, implemented by SdkAddressSpaceSink). The SDK- side OtOpcUaNodeManager gains an EnsureFolder API that creates FolderState nodes with proper parent linkage; RebuildAddressSpace now clears folders too so re-applies don't accumulate stale topology. Phase7Applier.MaterialiseHierarchy walks composition.UnsAreas → composition.UnsLines → composition.EquipmentNodes, calling EnsureFolder with the correct parent at each level. Idempotent — calling twice with the same composition is a no-op. OpcUaPublishActor.HandleRebuild invokes it after Phase7Applier.Apply so OPC UA clients browsing the server now see Area/Line/Equipment as proper folders rather than flat tag ids. DeploymentArtifact.ParseComposition reads UnsAreas + UnsLines from the JSON snapshot the ControlPlane emits, populating the new fields when present. Phase7Composer.Compose now accepts UnsAreas + UnsLines; a 3-arg overload preserves the old signature for legacy callers + existing tests. The Phase7CompositionResult convenience ctor likewise keeps the planner tests working without UNS data. 3 new hierarchy tests (pure unit + boot-verify against a real OtOpcUaSdkServer); OpcUaServer suite is 48/48 green (was 45, +3), Runtime 74/74 unchanged. Closes #85.	2026-05-26 10:48:56 -04:00
Joseph Doherty	d21f6947e1	feat(opcua): F10b SDK NodeManager binding — real OPC UA address-space writes ... OtOpcUaNodeManager + SdkAddressSpaceSink: the v2 IOpcUaAddressSpaceSink seam now has a production adapter against a real Opc.Ua.Server CustomNodeManager2. Writes through OpcUaPublishActor's sink materialise as real OPC UA Variable updates that subscribed clients see via the standard ClearChangeMasks notification path. OtOpcUaNodeManager (CustomNodeManager2): - Owns a ConcurrentDictionary<string, BaseDataVariableState> under a single namespace (https://zb.com/otopcua/ns) hung off Objects/. - WriteValue lazy-creates the variable on first write, sets Value + StatusCode (mapped from OpcUaQuality severity bits) + SourceTimestamp, then ClearChangeMasks to notify subscribers. - WriteAlarmState surfaces a [active, acknowledged] pair on a dedicated node id — full AlarmConditionState/event firing comes with #85 F14b (EquipmentNodeWalker SDK integration). - RebuildAddressSpace tears down every registered variable + clears the dictionary so the next write-pass starts fresh. - Address-space root folder is materialised in CreateAddressSpace. SdkAddressSpaceSink: thin IOpcUaAddressSpaceSink → OtOpcUaNodeManager bridge. Production DI binding (#108) constructs this once the host's StandardServer has booted. OtOpcUaSdkServer (StandardServer subclass): overrides CreateMasterNodeManager to inject OtOpcUaNodeManager via the MasterNodeManager additionalManagers ctor. NodeManager property exposes the live instance so OpcUaApplicationHost callers can wrap it in a sink. Tests: OpcUaServer 20 -> 24 (+4): - WriteValue creates + updates variables in the manager - WriteAlarmState creates a node distinct from value writes - RebuildAddressSpace clears everything; subsequent writes start fresh - NullOpcUaAddressSpaceSink no-op sanity Each test boots a real OpcUaApplicationHost on a free port with the SDK certificate auto-create flow (F13a) intact — full integration slice on macOS. All 6 v2 test suites green: 167 tests passing. F10 status updated to reflect SDK binding shipped. Residuals: - #109 OpcUaPublishActor.RebuildAddressSpace → Phase7Applier wiring - #108 Host DI default to SdkAddressSpaceSink when hasDriver - #85 F14b EquipmentNodeWalker integration (proper AlarmConditionState + folder hierarchy) - IServiceLevelPublisher SDK binding (writes Server.ServiceLevel node)	2026-05-26 09:49:44 -04:00