lmxopcua

Author SHA1 Message Date

Author	SHA1	Message	Date
Joseph Doherty	a5a8710af5	fix(mqtt): pin security-critical defaults with tests + redact password in ToString Code review of `f22db5d8` (approved-with-findings): the existing round-trip tests only exercised explicit JSON payloads, so nothing failed if UseTls / AllowUntrustedServerCertificate or the §5.1 numeric defaults were flipped. Adds a defaults-pinning test plus a partial-JSON test that omits the TLS knobs entirely (the production case — an operator config that just doesn't mention TLS must not silently land insecure). Also overrides the record's PrintMembers so ToString() no longer prints Password in plaintext (verified RED before the fix: the new test failed with the raw password in the rendered string). OpcUaClientDriverOptions has the same unredacted-ToString() shape but is out of scope for this task per the coordinator's note; flagging as a possible follow-up. Claude-Session: https://claude.ai/code/session_01GASWkNEi68FSCtvr6rLoEW	2026-07-24 14:01:01 -04:00
Joseph Doherty	f22db5d801	feat(mqtt): Contracts options DTO + enums (name-serialized) Task 1 of the MQTT/Sparkplug B driver plan: MqttMode, MqttPayloadFormat, MqttProtocolVersion enums + MqttDriverOptions (broker conn + mode + nullable Sparkplug/Plain sub-options) per design doc §5.1. Removes the Task 0 temporary MQTTnet PackageReference from .Contracts (transport-free; references only Core.Abstractions). MQTTnet stays pinned in Directory.Packages.props for the .Driver project (Task 3). Claude-Session: https://claude.ai/code/session_01GASWkNEi68FSCtvr6rLoEW	2026-07-24 13:53:06 -04:00

Joseph Doherty

a5a8710af5

fix(mqtt): pin security-critical defaults with tests + redact password in ToString

Code review of f22db5d8 (approved-with-findings): the existing round-trip
tests only exercised explicit JSON payloads, so nothing failed if UseTls /
AllowUntrustedServerCertificate or the §5.1 numeric defaults were flipped.
Adds a defaults-pinning test plus a partial-JSON test that omits the TLS
knobs entirely (the production case — an operator config that just doesn't
mention TLS must not silently land insecure).

Also overrides the record's PrintMembers so ToString() no longer prints
Password in plaintext (verified RED before the fix: the new test failed
with the raw password in the rendered string). OpcUaClientDriverOptions has
the same unredacted-ToString() shape but is out of scope for this task per
the coordinator's note; flagging as a possible follow-up.

Claude-Session: https://claude.ai/code/session_01GASWkNEi68FSCtvr6rLoEW

2026-07-24 14:01:01 -04:00

Joseph Doherty

f22db5d801

feat(mqtt): Contracts options DTO + enums (name-serialized)

Task 1 of the MQTT/Sparkplug B driver plan: MqttMode, MqttPayloadFormat,
MqttProtocolVersion enums + MqttDriverOptions (broker conn + mode +
nullable Sparkplug/Plain sub-options) per design doc §5.1. Removes the
Task 0 temporary MQTTnet PackageReference from .Contracts (transport-free;
references only Core.Abstractions). MQTTnet stays pinned in
Directory.Packages.props for the .Driver project (Task 3).

Claude-Session: https://claude.ai/code/session_01GASWkNEi68FSCtvr6rLoEW

2026-07-24 13:53:06 -04:00

2 Commits