Joseph Doherty
98b27fc1b6
fix(code-review): resolve Batch 1 open findings (AdminUI auth, AlarmHistorian dispose guards, docs)
...
- AdminUI-001: gate Script editor pages at Administrator,Designer + loosen ScriptAnalysis backend to match
- AdminUI-004: explicit [Authorize] on FleetStatus/Alert/ScriptLog hubs
- Core.AlarmHistorian-014: ObjectDisposedException guards on GetStatus/RetryDeadLettered (+ regression test)
- Core.Scripting.Abstractions-004/-007: Deadband tolerance doc + stale ScriptedAlarms.md path
- Host-003: correct config-overlay precedence in ServiceHosting.md
- Configuration-014: LdapGroupRoleMapping collation-dependency doc
- Driver.TwinCAT.Contracts-002: Structure enum doc (discovery-only sentinel)
2026-06-20 22:30:33 -04:00
Joseph Doherty
145b06bec9
review(Core.Scripting.Abstractions): refresh stale Phase7 labels + document {{equip}}
...
First review at 7286d320 . Five Low doc fixes (BadNodeIdUnknown comment parity, three stale
Phase7 labels -> design-doc cites, {{equip}} token doc on GetTag/SetVirtualTag). Deadband
NaN/negative-tolerance (004) + a stale docs path (007) left Open.
2026-06-19 11:06:56 -04:00
Joseph Doherty
b73ce75402
harden(vtag): exclude backslash from passthrough capture + parity tests (A review)
2026-06-07 15:31:54 -04:00
Joseph Doherty
08d7477860
feat(vtag): passthrough fast-path skips Roslyn for mirror scripts (A)
2026-06-07 15:26:20 -04:00
Joseph Doherty
1827c51c42
refactor(scripting): clarify sandbox-pin invariant + add RootNamespace (A0 review)
2026-06-07 15:16:14 -04:00
Joseph Doherty
56cac39216
refactor(scripting): extract script-callable types into Roslyn-free Core.Scripting.Abstractions (A0)
2026-06-07 15:10:00 -04:00