lmxopcua

Author SHA1 Message Date

Author	SHA1	Message	Date
Joseph Doherty	94eec70fb0	fix(code-review): resolve Batch 3 wave A (OpcUaServer history/guard, ControlPlane topology gate) - OpcUaServer-002: HistoryRead-Events NumValuesPerNode==0 now maps to unbounded (int.MaxValue) instead of the backend default-cap sentinel; no Core.Abstractions contract change (+EventMaxEvents helper tests) - OpcUaServer-004: EnsureAddressSpaceCreated guard on public mutators -> clear InvalidOperationException instead of bare NRE if called pre-start (+tests) - OpcUaServer-003: Deferred (endUtc inclusive/exclusive needs live Wonderware boundary confirmation) - Configuration-013: wire DraftValidator.ValidateClusterTopology into AdminOperationsActor deploy gate (read-only, no migration) (+2 tests)	2026-06-20 22:53:29 -04:00
Joseph Doherty	40749d3f67	review(OpcUaServer): fix silent auto-unshelve failure (empty User -> 'system') Cross-module fix from the review sweep. -007 (Medium): OnTimedUnshelve built its AlarmCommand with User=string.Empty, so Part9StateMachine.ApplyUnshelve rejected it (ArgumentException, swallowed) and a TimedShelve never auto-expired. Pass the canonical 'system' user; the AlarmAck-gate bypass is preserved. Repurposed the test that had encoded the bug.	2026-06-19 12:29:40 -04:00
Joseph Doherty	bac6613dd2	review(OpcUaServer): record findings + fix stale node-manager/host docs First review of the v2 OPC UA core at HEAD `7286d320`. 6 findings (2 Medium, 4 Low). OpcUaServer-006 fixed (stale NodeManager/ApplicationHost XML docs). 001-004 deferred (cross-module: Runtime publish-actor / Core.Abstractions history contract / Wonderware boundary semantics, or latent-only). 005 re-triaged Won't-Fix (coverage already exists). High-scrutiny paths (Lock discipline, OnWriteValue fire-and-forget, WriteOperate/AlarmAck gates, HistoryRead AccessLevel bits) verified correct.	2026-06-19 10:37:00 -04:00

Joseph Doherty

94eec70fb0

fix(code-review): resolve Batch 3 wave A (OpcUaServer history/guard, ControlPlane topology gate)

- OpcUaServer-002: HistoryRead-Events NumValuesPerNode==0 now maps to unbounded (int.MaxValue) instead of the backend default-cap sentinel; no Core.Abstractions contract change (+EventMaxEvents helper tests)
- OpcUaServer-004: EnsureAddressSpaceCreated guard on public mutators -> clear InvalidOperationException instead of bare NRE if called pre-start (+tests)
- OpcUaServer-003: Deferred (endUtc inclusive/exclusive needs live Wonderware boundary confirmation)
- Configuration-013: wire DraftValidator.ValidateClusterTopology into AdminOperationsActor deploy gate (read-only, no migration) (+2 tests)

2026-06-20 22:53:29 -04:00

Joseph Doherty

40749d3f67

review(OpcUaServer): fix silent auto-unshelve failure (empty User -> 'system')

Cross-module fix from the review sweep. -007 (Medium): OnTimedUnshelve built its AlarmCommand
with User=string.Empty, so Part9StateMachine.ApplyUnshelve rejected it (ArgumentException,
swallowed) and a TimedShelve never auto-expired. Pass the canonical 'system' user; the
AlarmAck-gate bypass is preserved. Repurposed the test that had encoded the bug.

2026-06-19 12:29:40 -04:00

Joseph Doherty

bac6613dd2

review(OpcUaServer): record findings + fix stale node-manager/host docs

First review of the v2 OPC UA core at HEAD 7286d320. 6 findings (2 Medium, 4 Low).
OpcUaServer-006 fixed (stale NodeManager/ApplicationHost XML docs). 001-004 deferred
(cross-module: Runtime publish-actor / Core.Abstractions history contract / Wonderware
boundary semantics, or latent-only). 005 re-triaged Won't-Fix (coverage already exists).
High-scrutiny paths (Lock discipline, OnWriteValue fire-and-forget, WriteOperate/AlarmAck
gates, HistoryRead AccessLevel bits) verified correct.

2026-06-19 10:37:00 -04:00

3 Commits