lmxopcua

dohertj2/lmxopcua

Fork 0

Commit Graph

Author	SHA1	Message	Date
Joseph Doherty	8b2c3fa04c	v3(focas): adopt Modbus RawTagEntry exemplar (multi-device) - Rename FocasEquipmentTagParser -> FocasTagDefinitionFactory; TryParse -> FromTagConfig(tagConfig, rawPath, out def). Drop leading-{ heuristic + the deviceHostAddress blob key; def.Name = rawPath. Add inverse ToTagConfig. writable: absent -> read-only, explicit true honoured (note preserved). - FocasDriverOptions.Tags -> RawTags (IReadOnlyList<RawTagEntry>). - FocasDriver: _tagsByRawPath (Ordinal); byName-only resolver; build table from RawTags via FromTagConfig; multi-device routing threads RawTagEntry.DeviceName -> ResolveDeviceHost match against options.Devices -> def.DeviceHostAddress (TODO v3 WaveC: live host from Device row DeviceConfig). Tolerant per-tag skip+log (mapper/address/matrix miss -> BadNodeIdUnknown); unknown device fails init fast. - Factory: bind List<RawTagEntry> RawTags; retire FocasTagDto/ParseDataType. - CLI FocasCommandBase.BuildOptions -> RawTags via ToTagConfig + DeviceName. - Tests: FocasRawTags helper; migrate Tags= -> RawTags=; rename parser tests to FromTagConfig; rewrite retired blob-ref tests (equipment-tag/capability-gate/ resolve-host) onto authored RawPath. 272 driver + 52 CLI green.	2026-07-15 20:19:55 -04:00
Joseph Doherty	235b8b8e6d	fix(focas): serialize per-device wire I/O + bound reads; tolerate AdminUI config formats Equipment tags were stuck at Bad_WaitingForInitialData on the deployed driver: the equipment poll, fixed-tree loop, probe and recycle shared one FOCAS/2 socket with no serialization, and the steady-state read had no timeout — concurrent reads collided and a stalled read hung forever, never overwriting the node's initial-data seed. - SynchronizedFocasClient: per-device SemaphoreSlim gate + per-call timeout around every wire op (Connect/Probe gated, not double-bounded); wired in EnsureConnectedAsync. ReadAsync/WriteAsync map a per-call timeout to BadCommunicationError instead of rethrowing. - FlexibleStringConverter on FOCAS config Series: the AdminUI persists the enum as a number ("series":6); accept number-or-string instead of throwing -> stub. - FocasHostAddress.TryParse tolerates a scheme-less {ip}[:{port}] (AdminUI hostAddress form); canonical focas:// unchanged, malformed schemes still rejected. 247 FOCAS tests green; each fix has a regression test. Live-validated on wonder-app-vd03 (tags read Good).	2026-06-26 05:59:54 -04:00

Author

SHA1

Message

Date

Joseph Doherty

8b2c3fa04c

v3(focas): adopt Modbus RawTagEntry exemplar (multi-device)

- Rename FocasEquipmentTagParser -> FocasTagDefinitionFactory; TryParse ->
  FromTagConfig(tagConfig, rawPath, out def). Drop leading-{ heuristic + the
  deviceHostAddress blob key; def.Name = rawPath. Add inverse ToTagConfig.
  writable: absent -> read-only, explicit true honoured (note preserved).
- FocasDriverOptions.Tags -> RawTags (IReadOnlyList<RawTagEntry>).
- FocasDriver: _tagsByRawPath (Ordinal); byName-only resolver; build table from
  RawTags via FromTagConfig; multi-device routing threads RawTagEntry.DeviceName
  -> ResolveDeviceHost match against options.Devices -> def.DeviceHostAddress
  (TODO v3 WaveC: live host from Device row DeviceConfig). Tolerant per-tag
  skip+log (mapper/address/matrix miss -> BadNodeIdUnknown); unknown device
  fails init fast.
- Factory: bind List<RawTagEntry> RawTags; retire FocasTagDto/ParseDataType.
- CLI FocasCommandBase.BuildOptions -> RawTags via ToTagConfig + DeviceName.
- Tests: FocasRawTags helper; migrate Tags= -> RawTags=; rename parser tests to
  FromTagConfig; rewrite retired blob-ref tests (equipment-tag/capability-gate/
  resolve-host) onto authored RawPath. 272 driver + 52 CLI green.

2026-07-15 20:19:55 -04:00

Joseph Doherty

235b8b8e6d

fix(focas): serialize per-device wire I/O + bound reads; tolerate AdminUI config formats

Equipment tags were stuck at Bad_WaitingForInitialData on the deployed driver: the equipment poll, fixed-tree loop, probe and recycle shared one FOCAS/2 socket with no serialization, and the steady-state read had no timeout — concurrent reads collided and a stalled read hung forever, never overwriting the node's initial-data seed.

- SynchronizedFocasClient: per-device SemaphoreSlim gate + per-call timeout around every wire op (Connect/Probe gated, not double-bounded); wired in EnsureConnectedAsync. ReadAsync/WriteAsync map a per-call timeout to BadCommunicationError instead of rethrowing.
- FlexibleStringConverter on FOCAS config Series: the AdminUI persists the enum as a number ("series":6); accept number-or-string instead of throwing -> stub.
- FocasHostAddress.TryParse tolerates a scheme-less {ip}[:{port}] (AdminUI hostAddress form); canonical focas:// unchanged, malformed schemes still rejected.

247 FOCAS tests green; each fix has a regression test. Live-validated on wonder-app-vd03 (tags read Good).

2026-06-26 05:59:54 -04:00

2 Commits