2 Commits

Author	SHA1	Message	Date
Joseph Doherty	54f58c583c	fix(heidenhain): refuse literal credentials and writable/mistyped tags at the save path (#803 review) ... - Review 1: RawTreeService Create/UpdateDriver and Create/UpdateDevice refuse a Heidenhain config whose password fields are not blank / secret:heidenhain/... / env:OTOPCUA_HEIDENHAIN_... (DriverConfigSaveGate over HeidenhainOptionsParser.DescribeCredentialProblems: top level, Access, Devices[], case-insensitive keys; the value is never echoed), so a literal password never reaches the draft DB. The driver and device modals show the reason and disable Save. - Review 8: CreateTag/UpdateTag/ImportTags (tag modal, manual entry, CSV import, browse commit) refuse a ReadWrite Heidenhain tag or a Tag.DataType that disagrees with what the driver publishes (HeidenhainTagRules: catalog type, Float64 => Double, or the binding's dataType). The tag modal and manual-entry grid fix the access level at Read and derive the data type from the address (RawTagRowDefaults). New deploy gate HeidenhainTagDataTypeMismatch. - docs/drivers/Heidenhain.md: credential namespace convention + why, the save-path and deploy enforcement, optional-role credential behaviour, BadConfigurationError, backoff/ordering notes. Tests: HeidenhainSavePathTests (service save path; red with the gates disabled) and new DraftValidatorHeidenhainTests cases.	2026-11-10 23:54:32 -05:00
Joseph Doherty	8fb03d6a72	docs(heidenhain): driver page, README/probe index rows, drivers rule note (#803) ... docs/drivers/Heidenhain.md: read-only boundary + allowlist table, transport, config, credential references, address grammar (fixed catalog, PLC element/byte-count rules, DATA types incl. FF Boolean), quality table, lifecycle/health/comms loss, probe, tests, hardware-gated items and deliberate exclusions. Also: InitializeAsync clears surviving subscription handles (the actor re-subscribes after every successful init, so a kept handle would double-publish).	2026-11-10 23:23:25 -05:00