From fcf84adbad307d748f7c3380acfacc67a8cf1ca3 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Fri, 12 Jun 2026 12:13:04 -0400 Subject: [PATCH] fix(historian-client): cancellable TLS client handshake + default-fields test (review) --- .../Internal/FrameChannel.cs | 2 +- .../HistorianWonderwareDriverPageFormSerializationTests.cs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client/Internal/FrameChannel.cs b/src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client/Internal/FrameChannel.cs index 2e678b0c..bdd2f305 100644 --- a/src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client/Internal/FrameChannel.cs +++ b/src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client/Internal/FrameChannel.cs @@ -68,7 +68,7 @@ internal sealed class FrameChannel : IAsyncDisposable }); try { - await ssl.AuthenticateAsClientAsync(opts.Host).ConfigureAwait(false); + await ssl.AuthenticateAsClientAsync(new SslClientAuthenticationOptions { TargetHost = opts.Host }, ct).ConfigureAwait(false); } catch { diff --git a/tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/HistorianWonderwareDriverPageFormSerializationTests.cs b/tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/HistorianWonderwareDriverPageFormSerializationTests.cs index d99d6522..df4928cd 100644 --- a/tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/HistorianWonderwareDriverPageFormSerializationTests.cs +++ b/tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/HistorianWonderwareDriverPageFormSerializationTests.cs @@ -64,6 +64,8 @@ public sealed class HistorianWonderwareDriverPageFormSerializationTests back.CallTimeout.ShouldBeNull(); back.EffectiveConnectTimeout.ShouldBe(TimeSpan.FromSeconds(10)); back.EffectiveCallTimeout.ShouldBe(TimeSpan.FromSeconds(30)); + back.UseTls.ShouldBeFalse(); + back.ServerCertThumbprint.ShouldBeNull(); } [Fact]