fix(historian): #679 Gateway — Average/Count not supported (no AVEVA equivalent), TimeAverage → TimeWeightedAverage

2026-10-11 15:19:19 -04:00
parent 6d5c1c768b
commit fb5ec80fe6
7 changed files with 56 additions and 22 deletions
@@ -37,6 +37,30 @@ public sealed class GatewayHistorianDataSourceTests
        Assert.Equal(TimeSpan.FromSeconds(60), fake.LastAggregateInterval);
    }

+    [Fact]
+    public async Task ReadProcessed_TimeAverage_requests_TimeWeightedAverage()
+    {
+        var fake = new FakeHistorianGatewayClient();
+        var ds = new GatewayHistorianDataSource(fake, NullLogger<GatewayHistorianDataSource>.Instance);
+        await ds.ReadProcessedAsync("T", default, default, TimeSpan.FromSeconds(60), HistoryAggregateType.TimeAverage, TestContext.Current.CancellationToken);
+        Assert.Equal(RetrievalMode.TimeWeightedAverage, fake.LastAggregateMode);
+    }
+
+    [Theory] // #679: no AVEVA equivalent — not supported, gateway never called, no backend failure recorded
+    [InlineData(HistoryAggregateType.Average)]
+    [InlineData(HistoryAggregateType.Count)]
+    public async Task ReadProcessed_unsupported_aggregate_throws_without_calling_gateway_or_recording_failure(HistoryAggregateType aggregate)
+    {
+        var fake = new FakeHistorianGatewayClient();
+        var ds = new GatewayHistorianDataSource(fake, NullLogger<GatewayHistorianDataSource>.Instance);
+        await Assert.ThrowsAsync<HistoryAggregateNotSupportedException>(() => ds.ReadProcessedAsync(
+            "T", default, default, TimeSpan.FromSeconds(60), aggregate, TestContext.Current.CancellationToken));
+        Assert.Equal(0, fake.ReadAggregateCallCount);
+        var h = ds.GetHealthSnapshot();
+        Assert.Equal(0, h.TotalFailures);
+        Assert.Equal(0, h.TotalQueries);
+    }
+
    [Fact]
    public async Task ReadAtTime_aligns_one_snapshot_per_timestamp_with_gaps_Bad()
    {