fix(localdb): phase-2 live gate — 4 production defects found and fixed

Gate record: docs/plans/2026-07-20-localdb-phase2-live-gate.md. Checks 1, 2, 5, 6 pass. Checks 3 and 4 are NOT satisfied — the defect they were meant to confirm turned out to be the opposite of what the plan assumed. Three defects crash-looped every driver node before check 1 could even run: 1. An empty ServerHistorian:ApiKey kills the host. ServerHistorianOptions- Validator exists to turn exactly that class of failure into a named OptionsValidationException, but its documented fail tier explicitly excluded ApiKey on the reasoning that a keyless client "degrades — the gateway rejects calls". It does not: the client validates its own options at construction, so the process dies during Akka startup and never makes a call. 2. UseTls disagreeing with the endpoint scheme kills the host too, in both directions (both messages confirmed in the shipped client assembly). Moving an endpoint from https to http without clearing UseTls is an ordinary migration slip. 3. Plaintext h2c was UNREACHABLE. HistorianGatewayClientAdapter forwarded the TLS-only options unconditionally, and AllowUntrustedServerCertificate defaults to false, so it always sent RequireCertificateValidation=true — which the client rejects outright when UseTls=false. Every http:// deployment crashed, though the scheme is documented as the supported way to select h2c, and the only workaround was to assert a certificate posture for a connection that has no certificate. The fourth was the blocker, and it is Phase 2's own: 4. The drain gate deferred to a Primary that cannot deliver. Redundancy roles are elected CLUSTER-WIDE; the alarm queue is PAIR-LOCAL. On the rig the elected driver Primary is central-1 — it carries the driver Akka role, replicates nobody's LocalDb and does not even run the alarm historian — so every driver node logged "Historian drain suspended", including the two site-b nodes that have no peer at all. Nothing drained anywhere, where before Phase 2 it drained fine. The cost is not a duplicate; it is the buffer growing to the capacity wall and evicting the audit trail it exists to protect. Fixed in three layers: a separate ShouldDrainAlarmHistory policy (unknown role drains; the two gates now deliberately disagree, and a test pins that); peer- host matching in DriverHostActor so a node stands down only for a Primary holding its rows; and AddAlarmHistorian short-circuiting the gate when replication is unconfigured — testing BOTH Replication:PeerAddress and SyncListenPort, since only the dialing half sets the former while both halves share the queue. Every one of these follows from the asymmetry: a false allow costs a duplicate row, which at-least-once delivery already accepts and payload-hash ids collapse; a false deny loses data silently. A third vacuous test, caught by the same delete-the-guard discipline: the role-view tests stayed green with the guard removed, because AwaitAssert polls until an assertion passes and the assertion was "reads open" — which is the SEEDED value, satisfied at the first poll before the actor processed anything. They now assert the sequence of published values through a recording view; the control then goes red for exactly the cases that matter. Migration evidence: 11 legacy rows across two deliberately overlapping files converged to exactly 9 identical rows on both nodes, proving D-6's payload-hash identity on real nodes rather than in a fixture. Open design fork, recorded in the gate doc rather than decided here: a pair cannot currently identify its own Primary, so both halves drain. Safe in every topology — nothing loses data — but the gate's de-duplication benefit is unrealised until roles are scoped per pair. Claude-Session: https://claude.ai/code/session_01GASWkNEi68FSCtvr6rLoEW
2026-07-21 06:13:01 -04:00
parent 2e4ccf7fe9
commit f9f1b8fcee
14 changed files with 885 additions and 73 deletions
@@ -22,6 +22,61 @@ public sealed class HistorianGatewayClientAdapterTests
        Assert.NotNull(adapter);
    }

+    /// <summary>
+    ///     A plaintext <c>h2c</c> gateway (an <c>http://</c> endpoint with <c>UseTls=false</c>) must
+    ///     construct, using nothing but documented defaults.
+    /// </summary>
+    /// <remarks>
+    ///     <para>
+    ///         Found by the LocalDb Phase 2 live gate, on the third consecutive crash-loop of the rig.
+    ///         <c>docs/Historian.md</c> and CLAUDE.md both document <c>http://</c> as a supported
+    ///         transport ("scheme selects transport: https = TLS, http = h2c"), but it was in fact
+    ///         <b>unreachable</b>: this factory forwarded the TLS-only options unconditionally, and
+    ///         <see cref="ServerHistorianOptions.AllowUntrustedServerCertificate"/> defaults to
+    ///         <see langword="false"/>, so it always sent <c>RequireCertificateValidation=true</c> —
+    ///         which the client rejects outright when <c>UseTls=false</c>
+    ///         ("RequireCertificateValidation is a TLS-only option and requires UseTls=true").
+    ///     </para>
+    ///     <para>
+    ///         So <b>every</b> h2c deployment crashed at startup, and the only way to avoid it was to
+    ///         set <c>AllowUntrustedServerCertificate=true</c> — asserting a certificate posture for a
+    ///         connection that has no certificate at all.
+    ///     </para>
+    /// </remarks>
+    [Fact]
+    public void Adapter_constructs_for_plaintext_h2c_endpoint()
+    {
+        var opts = new ServerHistorianOptions
+        {
+            Enabled = true, Endpoint = "http://localhost:5222", ApiKey = "histgw_x_y", UseTls = false,
+        };
+
+        using var adapter = HistorianGatewayClientAdapter.Create(opts, NullLoggerFactory.Instance);
+
+        adapter.ShouldNotBeNull();
+    }
+
+    /// <summary>
+    ///     A pinned CA path is likewise TLS-only, and must not leak into an h2c client — the same
+    ///     rejection, reached by a different field.
+    /// </summary>
+    [Fact]
+    public void Adapter_ignores_tls_only_settings_on_a_plaintext_endpoint()
+    {
+        var opts = new ServerHistorianOptions
+        {
+            Enabled = true,
+            Endpoint = "http://localhost:5222",
+            ApiKey = "histgw_x_y",
+            UseTls = false,
+            CaCertificatePath = "/etc/ssl/certs/leftover-from-a-tls-config.pem",
+        };
+
+        using var adapter = HistorianGatewayClientAdapter.Create(opts, NullLoggerFactory.Instance);
+
+        adapter.ShouldNotBeNull();
+    }
+
    /// <summary>
    /// archreview 06/S-11 — an enabled historian with an empty <c>Endpoint</c> must fail with a
    /// named, config-key-carrying <see cref="InvalidOperationException"/> (defense-in-depth for any