fix(admin-ui): harden read-only script source dialog lifecycle
This commit is contained in:
+164
@@ -0,0 +1,164 @@
|
||||
using System.Reflection;
|
||||
using Bunit;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using Microsoft.AspNetCore.Components;
|
||||
using Microsoft.AspNetCore.Components.Rendering;
|
||||
using Microsoft.AspNetCore.Components.RenderTree;
|
||||
using Microsoft.AspNetCore.Components.Web;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using Microsoft.Extensions.DependencyInjection;
|
||||
using Shouldly;
|
||||
using Xunit;
|
||||
using ZB.MOM.WW.OtOpcUa.AdminUI.Components.Pages;
|
||||
using ZB.MOM.WW.OtOpcUa.AdminUI.Components.Shared;
|
||||
using ZB.MOM.WW.OtOpcUa.Configuration;
|
||||
using ZB.MOM.WW.OtOpcUa.Configuration.Entities;
|
||||
using ZB.MOM.WW.OtOpcUa.Security.Auth;
|
||||
|
||||
namespace ZB.MOM.WW.OtOpcUa.AdminUI.Tests.Pages;
|
||||
|
||||
/// <summary>Read-only Scripts Source dialog; database queries remain real EF InMemory reads.</summary>
|
||||
[Trait("Category", "Unit")]
|
||||
public sealed class ScriptsDialogAccessibilityTests : BunitContext
|
||||
{
|
||||
private readonly GatedFactory _factory = new();
|
||||
public ScriptsDialogAccessibilityTests()
|
||||
{
|
||||
JSInterop.Setup<bool>("otDialog.activate", _ => true).SetResult(true);
|
||||
JSInterop.SetupVoid("otDialog.update", _ => true).SetVoidResult();
|
||||
JSInterop.SetupVoid("otDialog.deactivate", _ => true).SetVoidResult();
|
||||
Services.AddSingleton<IDbContextFactory<OtOpcUaConfigDbContext>>(_factory);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SourceDialogHasContextualNameScrollableBodySafeCloseAndReadableSource()
|
||||
{
|
||||
var cut = Render<Scripts>();
|
||||
Source(cut, "Alpha").Click();
|
||||
var modal = cut.Find("[role=dialog]");
|
||||
modal.GetAttribute("aria-modal").ShouldBe("true");
|
||||
cut.Find("#" + modal.GetAttribute("aria-labelledby")).TextContent.ShouldContain("Alpha");
|
||||
cut.Find(".modal-dialog").ClassList.ShouldContain("modal-lg");
|
||||
cut.Find(".modal-dialog").ClassList.ShouldContain("modal-dialog-scrollable");
|
||||
cut.Find("[data-initial-focus]").TextContent.Trim().ShouldBe("Close");
|
||||
var source = cut.Find("pre[role=region]");
|
||||
source.GetAttribute("aria-label")!.ShouldContain("Alpha");
|
||||
source.GetAttribute("tabindex").ShouldBe("0");
|
||||
source.TextContent.ShouldBe("// alpha <script> is literal source\nreturn 1;");
|
||||
cut.FindAll("pre script").ShouldBeEmpty();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("Alpha")]
|
||||
[InlineData("Beta")]
|
||||
public async Task RetainedCloseCannotDismissReopenedSource(string nextName)
|
||||
{
|
||||
var cut = Render<Scripts>();Source(cut,"Alpha").Click();
|
||||
var retired = CaptureClose(cut);
|
||||
cut.Find(".modal-footer button").Click();
|
||||
Source(cut,nextName).Click();
|
||||
await cut.InvokeAsync(retired);
|
||||
cut.Find("[role=dialog]").TextContent.ShouldContain(nextName);
|
||||
cut.Find("pre").TextContent.ShouldBe(nextName=="Alpha"?"// alpha <script> is literal source\nreturn 1;":"return 2;");
|
||||
cut.Find(".modal-footer button").Click();cut.FindAll("[role=dialog]").ShouldBeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task DisposalRetiresPendingSourceWithoutInstallingItsText()
|
||||
{
|
||||
_factory.HoldSecond = true;
|
||||
var cut = Render<Scripts>();var instance=cut.Instance;
|
||||
var opening=Source(cut,"Alpha").ClickAsync(new());
|
||||
await _factory.Entered.Task.WaitAsync(TimeSpan.FromSeconds(10),Xunit.TestContext.Current.CancellationToken);
|
||||
await DisposeComponentsAsync();_factory.Release.TrySetResult();await opening;
|
||||
Field<string?>(instance,"_sourceCode").ShouldBeNull();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(false)]
|
||||
[InlineData(true)]
|
||||
public async Task PendingReadCanCloseAndCannotReplaceReopenedSource(bool failOld)
|
||||
{
|
||||
_factory.HoldSecond = true;_factory.FailSecond=failOld;
|
||||
var cut=Render<Scripts>();var opening=Source(cut,"Alpha").ClickAsync(new());
|
||||
await _factory.Entered.Task.WaitAsync(TimeSpan.FromSeconds(10),Xunit.TestContext.Current.CancellationToken);
|
||||
cut.Find(".modal-footer button").HasAttribute("disabled").ShouldBeFalse();
|
||||
cut.Find(".modal-footer button").Click();Source(cut,"Beta").Click();
|
||||
_factory.Release.TrySetResult();await opening;
|
||||
cut.Find("[role=dialog]").TextContent.ShouldContain("Beta");cut.Find("pre").TextContent.ShouldBe("return 2;");
|
||||
cut.Markup.ShouldNotContain("Synthetic source read failure");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CurrentSourceFailureStaysInsideClosableDialog()
|
||||
{
|
||||
_factory.FailSecond=true;
|
||||
var cut=Render<Scripts>();Source(cut,"Alpha").Click();
|
||||
cut.Find("[role=dialog]").TextContent.ShouldContain("The script source could not be loaded: Synthetic source read failure");
|
||||
cut.Markup.ShouldNotContain("data-testid=\"page-error-boundary\"");
|
||||
cut.Find(".modal-footer button").Click();cut.FindAll("[role=dialog]").ShouldBeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void TemporaryMissingListKeepsIntentDialogAndCloseMounted()
|
||||
{
|
||||
var cut=Render<Scripts>();Source(cut,"Alpha").Click();
|
||||
typeof(Scripts).GetField("_rows",BindingFlags.Instance|BindingFlags.NonPublic)!.SetValue(cut.Instance,null);
|
||||
cut.Render();cut.Find("[role=dialog]").TextContent.ShouldContain("This script is no longer loaded.");
|
||||
cut.Find(".modal-footer button").Click();cut.FindAll("[role=dialog]").ShouldBeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ActualRouteRetainsConfigEditorAuthorization()
|
||||
=> typeof(Scripts).GetCustomAttributes<AuthorizeAttribute>().ShouldContain(x=>x.Policy==AdminUiPolicies.ConfigEditor);
|
||||
|
||||
private static AngleSharp.Dom.IElement Source(IRenderedComponent<Scripts> cut,string name)
|
||||
=> cut.FindAll("tbody tr").Single(row=>row.TextContent.Contains(name,StringComparison.Ordinal)).QuerySelector("button")!;
|
||||
private static T Field<T>(object instance,string name)=>(T)instance.GetType().GetField(name,BindingFlags.Instance|BindingFlags.NonPublic)!.GetValue(instance)!;
|
||||
|
||||
#pragma warning disable BL0006 // Capture actual rendered footer event; do not replace it with a parallel test action.
|
||||
private static Func<Task> CaptureClose(IRenderedComponent<Scripts> cut)
|
||||
{
|
||||
var frame=cut.FindComponents<ModalFrame>().SingleOrDefault();
|
||||
var fragment=frame is null ? cut.FindComponent<PageErrorBoundary>().Instance.ChildContent! : frame.Instance.Footer!;
|
||||
using var builder=new RenderTreeBuilder();fragment(builder);var range=builder.GetFrames();var frames=range.Array;
|
||||
for(var i=0;i<range.Count;i++)
|
||||
{
|
||||
if(frames[i].FrameType!=RenderTreeFrameType.Element||frames[i].ElementName!="button")continue;
|
||||
var body=frames.Skip(i+1).Take(frames[i].ElementSubtreeLength-1).ToArray();
|
||||
if(!body.Any(x=>x.FrameType==RenderTreeFrameType.Text&&x.TextContent.Trim()=="Close"))continue;
|
||||
var action=body.Single(x=>x.FrameType==RenderTreeFrameType.Attribute&&x.AttributeName=="onclick").AttributeValue;
|
||||
return ()=>action switch
|
||||
{
|
||||
EventCallback callback=>callback.InvokeAsync(new MouseEventArgs()),
|
||||
EventCallback<MouseEventArgs> callback=>callback.InvokeAsync(new()),
|
||||
Action callback=>EventCallback.Factory.Create(cut.Instance,callback).InvokeAsync(),
|
||||
Func<Task> callback=>EventCallback.Factory.Create(cut.Instance,callback).InvokeAsync(),
|
||||
_=>throw new InvalidOperationException("Unknown rendered close callback representation")
|
||||
};
|
||||
}
|
||||
throw new InvalidOperationException("No rendered footer Close callback");
|
||||
}
|
||||
#pragma warning restore BL0006
|
||||
|
||||
private sealed class GatedFactory:IDbContextFactory<OtOpcUaConfigDbContext>
|
||||
{
|
||||
private readonly string _database="scripts-dialog-"+Guid.NewGuid().ToString("N");private int _calls;
|
||||
public bool HoldSecond,FailSecond;
|
||||
public readonly TaskCompletionSource Entered=new(TaskCreationOptions.RunContinuationsAsynchronously),Release=new(TaskCreationOptions.RunContinuationsAsynchronously);
|
||||
public GatedFactory()
|
||||
{
|
||||
using var db=CreateDbContext();db.Scripts.AddRange(new Script{ScriptId="s-a",Name="Alpha",SourceCode="// alpha <script> is literal source\nreturn 1;",SourceHash="hash-a"},new Script{ScriptId="s-b",Name="Beta",SourceCode="return 2;",SourceHash="hash-b"});db.SaveChanges();
|
||||
}
|
||||
public OtOpcUaConfigDbContext CreateDbContext()=>new(new DbContextOptionsBuilder<OtOpcUaConfigDbContext>().UseInMemoryDatabase(_database).Options);
|
||||
public async Task<OtOpcUaConfigDbContext> CreateDbContextAsync(CancellationToken ct=default)
|
||||
{
|
||||
if(Interlocked.Increment(ref _calls)==2)
|
||||
{
|
||||
if(HoldSecond){Entered.TrySetResult();await Release.Task.WaitAsync(ct);}
|
||||
if(FailSecond)throw new InvalidOperationException("Synthetic source read failure");
|
||||
}
|
||||
return CreateDbContext();
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user