From f19f2ee73bf358c06e1d078560ea72fc6e16f9f3 Mon Sep 17 00:00:00 2001
From: Joseph Doherty <dohejw01@gmail.com>
Date: Tue, 9 Jun 2026 07:39:08 -0400
Subject: [PATCH] fix(adminui): bind driver-page Error + picker SelectedNodeId
 as Razor expressions

Audit (task #134) found the same Razor literal-binding bug class as the UNS
Filter fix (14b4692): a string-typed component parameter assigned without a
leading @ is a LITERAL, not an expression. Confirmed against the generated
.g.cs (literal "_error" vs TypeCheck<String>(_error)).

- DriverFormShell Error="_error" -> "@_error" on all 9 driver edit pages:
  Error received the constant "_error", so the error banner rendered
  permanently and the real failure message was never shown.
- DriverBrowseTree SelectedNodeId="_tagName"/"_nodeId" -> "@..." in the
  Galaxy and OpcUaClient address pickers: the tree's selected-node highlight
  compared against a literal that never matched a real node.

Build clean; generated code now binds all 11 as TypeCheck<String>(field);
AdminUI.Tests 216/216 green.
---
 .../Components/Pages/Clusters/Drivers/AbCipDriverPage.razor     | 2 +-
 .../Components/Pages/Clusters/Drivers/AbLegacyDriverPage.razor  | 2 +-
 .../Components/Pages/Clusters/Drivers/FocasDriverPage.razor     | 2 +-
 .../Components/Pages/Clusters/Drivers/GalaxyDriverPage.razor    | 2 +-
 .../Pages/Clusters/Drivers/HistorianWonderwareDriverPage.razor  | 2 +-
 .../Components/Pages/Clusters/Drivers/ModbusDriverPage.razor    | 2 +-
 .../Pages/Clusters/Drivers/OpcUaClientDriverPage.razor          | 2 +-
 .../Components/Pages/Clusters/Drivers/S7DriverPage.razor        | 2 +-
 .../Components/Pages/Clusters/Drivers/TwinCATDriverPage.razor   | 2 +-
 .../Shared/Drivers/Pickers/GalaxyAddressPickerBody.razor        | 2 +-
 .../Shared/Drivers/Pickers/OpcUaClientAddressPickerBody.razor   | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbCipDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbCipDriverPage.razor
index bf566480..056c3b3b 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbCipDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbCipDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="abcipDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbLegacyDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbLegacyDriverPage.razor
index 3486b554..5cea4448 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbLegacyDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/AbLegacyDriverPage.razor
@@ -33,7 +33,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="ablegacyDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/FocasDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/FocasDriverPage.razor
index c933bc5b..7873f1fa 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/FocasDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/FocasDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="focasDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/GalaxyDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/GalaxyDriverPage.razor
index 18c3ef35..64107c2e 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/GalaxyDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/GalaxyDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="galaxyDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/HistorianWonderwareDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/HistorianWonderwareDriverPage.razor
index 8916dcc4..871415d5 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/HistorianWonderwareDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/HistorianWonderwareDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="historianwonderwareDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/ModbusDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/ModbusDriverPage.razor
index 5f58e258..d16a9112 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/ModbusDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/ModbusDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="modbustcpDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/OpcUaClientDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/OpcUaClientDriverPage.razor
index aa04a0e3..ccffb20e 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/OpcUaClientDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/OpcUaClientDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="opcuaclientDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/S7DriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/S7DriverPage.razor
index 33b25652..f8332eb1 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/S7DriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/S7DriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="s7DriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/TwinCATDriverPage.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/TwinCATDriverPage.razor
index 4abf9dc2..80772120 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/TwinCATDriverPage.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Pages/Clusters/Drivers/TwinCATDriverPage.razor
@@ -32,7 +32,7 @@ else
 {
     <EditForm Model="_form" OnValidSubmit="SubmitAsync" FormName="twincatDriverEdit">
         <DataAnnotationsValidator />
-        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="_error"
+        <DriverFormShell IsNew="IsNew" Busy="_busy" Error="@_error"
                          CancelHref="@($"/clusters/{ClusterId}/drivers")"
                          OnDelete="@(IsNew ? null : (EventCallback?)EventCallback.Factory.Create(this, DeleteAsync))">
 
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/GalaxyAddressPickerBody.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/GalaxyAddressPickerBody.razor
index f1926888..9238f11a 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/GalaxyAddressPickerBody.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/GalaxyAddressPickerBody.razor
@@ -51,7 +51,7 @@
             <div class="col-md-7">
                 <label class="form-label small">Objects</label>
                 <DriverBrowseTree SessionToken="_token" OnNodeSelected="OnObjectSelectAsync"
-                                  SelectedNodeId="_tagName" />
+                                  SelectedNodeId="@_tagName" />
             </div>
             <div class="col-md-5">
                 <label class="form-label small">Attributes of @(string.IsNullOrEmpty(_tagName) ? "—" : _tagName)</label>
diff --git a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/OpcUaClientAddressPickerBody.razor b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/OpcUaClientAddressPickerBody.razor
index 01168f50..a00ef2de 100644
--- a/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/OpcUaClientAddressPickerBody.razor
+++ b/src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/Pickers/OpcUaClientAddressPickerBody.razor
@@ -47,7 +47,7 @@
     {
         <div class="mt-2">
             <DriverBrowseTree SessionToken="_token" OnNodeSelected="OnTreeSelectAsync"
-                              SelectedNodeId="_nodeId" />
+                              SelectedNodeId="@_nodeId" />
         </div>
     }
 }