dohertj2/lmxopcua
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs(driver-twincat): update findings.md status fields and open count

Browse Source 
Mark findings 003, 009, 010, 011, 012 Status: Resolved (status fields
were missing the update in earlier commits); reduce Open findings
count from 11 to 5 (Low findings 004, 006, 014, 015, 016 remain open).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Joseph Doherty
2026-05-22 10:52:35 -04:00
parent 3f6b61133e
commit e774b6f88d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
code-reviews/Driver.TwinCAT/findings.md
View File

@@ -7,7 +7,7 @@
| Review date | 2026-05-22 | | Review date | 2026-05-22 |
| Commit reviewed | `76d35d1` | | Commit reviewed | `76d35d1` |
| Status | Reviewed | | Status | Reviewed |
| Open findings | 11 | | Open findings | 5 |
## Checklist coverage ## Checklist coverage
@@ -88,7 +88,7 @@ to `UInt16`, and `USInt`/`SInt` to their natural widths. Remove the stale "Int64
| Severity | Medium | | Severity | Medium |
| Category | Correctness & logic bugs | | Category | Correctness & logic bugs |
| Location | `AdsTwinCATClient.cs:264-281`, `283-300` | | Location | `AdsTwinCATClient.cs:264-281`, `283-300` |
| Status | Open | | Status | Resolved |
**Description:** `MapToClrType` has a `_ => typeof(int)` fallthrough and `ConvertForWrite` has **Description:** `MapToClrType` has a `_ => typeof(int)` fallthrough and `ConvertForWrite` has
a `_ => throw NotSupportedException` fallthrough. `TwinCATDataType.Structure` is a declared a `_ => throw NotSupportedException` fallthrough. `TwinCATDataType.Structure` is a declared
@@ -230,7 +230,7 @@ a dedicated managed task before invoking `OnChange`/`OnDataChange`, exactly as t
| Severity | Medium | | Severity | Medium |
| Category | Concurrency & thread safety | | Category | Concurrency & thread safety |
| Location | `TwinCATDriver.cs:80-99`, `41-72`, `366-388` | | Location | `TwinCATDriver.cs:80-99`, `41-72`, `366-388` |
| Status | Open | | Status | Resolved |
**Description:** `ShutdownAsync` mutates `_devices`, `_tagsByName`, and `_nativeSubs` with no **Description:** `ShutdownAsync` mutates `_devices`, `_tagsByName`, and `_nativeSubs` with no
synchronization while `ReadAsync`/`WriteAsync`/`SubscribeAsync` may be iterating or indexing synchronization while `ReadAsync`/`WriteAsync`/`SubscribeAsync` may be iterating or indexing
@@ -257,7 +257,7 @@ tasks before disposing `DeviceState`s.
| Severity | Medium | | Severity | Medium |
| Category | Error handling & resilience | | Category | Error handling & resilience |
| Location | `AdsTwinCATClient.cs:178-195` | | Location | `AdsTwinCATClient.cs:178-195` |
| Status | Open | | Status | Resolved |
**Description:** `BrowseSymbolsAsync` checks `cancellationToken.IsCancellationRequested` and **Description:** `BrowseSymbolsAsync` checks `cancellationToken.IsCancellationRequested` and
does `yield break` (a clean completion) rather than throwing `OperationCanceledException`. does `yield break` (a clean completion) rather than throwing `OperationCanceledException`.
@@ -281,7 +281,7 @@ discovery.
| Severity | Medium | | Severity | Medium |
| Category | Error handling & resilience | | Category | Error handling & resilience |
| Location | `TwinCATStatusMapper.cs:29-42` | | Location | `TwinCATStatusMapper.cs:29-42` |
| Status | Open | | Status | Resolved |
**Description:** ADS error-code mapping has gaps and an inconsistency versus **Description:** ADS error-code mapping has gaps and an inconsistency versus
`docs/v2/driver-specs.md` section 6. The spec documents symbol-not-found as 0x0701 `docs/v2/driver-specs.md` section 6. The spec documents symbol-not-found as 0x0701
@@ -307,7 +307,7 @@ to `BadOutOfService`/`BadInvalidState`.
| Severity | Medium | | Severity | Medium |
| Category | Performance & resource management | | Category | Performance & resource management |
| Location | `TwinCATDriver.cs:102`, `AdsTwinCATClient.cs:178-195` | | Location | `TwinCATDriver.cs:102`, `AdsTwinCATClient.cs:178-195` |
| Status | Open | | Status | Resolved |
**Description:** `GetMemoryFootprint()` returns a hard-coded 0. `docs/v2/driver-stability.md` **Description:** `GetMemoryFootprint()` returns a hard-coded 0. `docs/v2/driver-stability.md`
section "In-process only (Tier A/B) — driver-instance allocation tracking" requires the section "In-process only (Tier A/B) — driver-instance allocation tracking" requires the