dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore(historian): drop dead pipe package ref + stale pipe strings (review)

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-12 12:02:05 -04:00
parent 72f32045a4
commit e2960515cf
6 changed files with 18 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Drivers/ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client/WonderwareHistorianDriverProbe.cs
+7 -9
View File
@@ -6,11 +6,10 @@ namespace ZB.MOM.WW.OtOpcUa.Driver.Historian.Wonderware.Client;
/// <summary>
/// Driver probe for the <see cref="WonderwareHistorianClientOptions"/>-shaped driver config.
/// The Wonderware Historian client communicates over a Windows named pipe (not a TCP socket),
/// so a cheap TCP-connect probe is not applicable for this transport. This probe always
/// returns a well-formed "not applicable" result so the AdminUI can display a meaningful
/// message instead of a red error. A full named-pipe connect + Hello-frame probe is a
/// documented follow-up.
/// The Wonderware Historian client communicates over TCP, but a lightweight TCP-connect +
/// Hello-frame probe is not yet implemented. This probe always returns a well-formed
/// "not applicable" result so the AdminUI can display a meaningful message instead of a
/// red error. A full TCP connect + Hello-frame probe is a documented follow-up.
/// </summary>
public sealed class WonderwareHistorianDriverProbe : IDriverProbe
{
@@ -36,12 +35,11 @@ public sealed class WonderwareHistorianDriverProbe : IDriverProbe
if (opts is null)
return Task.FromResult(new DriverProbeResult(false, "Config JSON deserialized to null.", null));
// The Wonderware Historian sidecar communicates over a Windows named pipe; there is no
// TCP endpoint to connect to. A full pipe connect + Hello-frame probe is a follow-up.
// The Wonderware Historian sidecar communicates over TCP; a full TCP connect +
// Hello-frame probe is a documented follow-up.
return Task.FromResult(new DriverProbeResult(
false,
"TCP probe not applicable for this transport — the Historian sidecar uses a named pipe. " +
"A full named-pipe probe is a documented follow-up.",
"Full TCP probe (connect + Hello handshake) is not yet implemented for this driver — it is a documented follow-up.",
null));
}
}