refactor(mesh): collapse MeshPaths to local actor names — no longer a wire contract (review follow-up)
MeshPaths.CentralCommunication / .NodeCommunication (the "/user/..." full-path constants) had
ZERO production consumers after the ClusterClient deletion: both gRPC services resolve their
comm actor through ActorRegistry by typed key, never by ActorSelection over a path. Only the
path-probe test still read them, while the class doc went on calling them "the wire contract
of the central↔node boundary" — a claim that stopped being true the moment nothing addressed
an actor across a process boundary by name.
- The two full-path constants are deleted; the two Name constants remain.
- MeshPaths' doc now says what it is (the local actor-naming convention the registry-keyed
services are spawned under) and records what it stopped being, so the next reader does not
re-derive a contract from the file's history.
- MeshCommActorPathTests composes "/user/" + Name itself — the absolute path is that test's
own addressing detail now, not something the product declares. Renamed
Both_mesh_comm_actors_exist_at_their_contract_paths ->
..._are_spawned_under_their_declared_names, because what it still pins is that the two
registration sites actually ran on a real booted node; a rename is now a compile error, so
"contract" was the wrong word for what would break.
- NodeCommunicationActor's summary no longer cross-references the deleted constant or calls
the name an address. CentralCommunicationActor was checked and makes no such claim.
This commit is contained in:
@@ -1,33 +1,43 @@
|
||||
namespace ZB.MOM.WW.OtOpcUa.Commons.Messages.Mesh;
|
||||
|
||||
/// <summary>
|
||||
/// Actor paths the two mesh comm actors register under. <b>These strings are the wire
|
||||
/// contract</b> of the central↔node boundary.
|
||||
/// The <b>local actor names</b> the two mesh comm actors are spawned under. Not a wire contract:
|
||||
/// nothing off-process addresses either actor by name.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// Declared once, here, rather than as literals on each side. The <c>deployments</c> /
|
||||
/// <c>deployment-acks</c> topic names are declared twice — once in
|
||||
/// <c>ConfigPublishCoordinator</c> and again in <c>DriverHostActor</c> — and agree only by
|
||||
/// convention; renaming one would compile, deploy, and deliver nothing. A mesh path
|
||||
/// has the same failure mode and no compiler to catch it, so the constant is shared.
|
||||
/// <b>This used to be a wire contract and no longer is.</b> While the cross-mesh transport
|
||||
/// was an Akka <c>ClusterClient</c>, central addressed a node by the literal path string
|
||||
/// <c>/user/node-communication</c> and the far side resolved it — so the two processes had to
|
||||
/// agree on a string neither could see the other spell. Both gRPC services now resolve
|
||||
/// their comm actor through <c>ActorRegistry</c> (<c>CentralCommunicationActorKey</c> /
|
||||
/// <c>NodeCommunicationActorKey</c>), which is type-checked, so the name below never crosses
|
||||
/// a process boundary. The full <c>/user/...</c> path constants that carried the old contract
|
||||
/// are deleted; what remains is a naming convention.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// Nothing else pins these values, which is why <c>MeshCommActorPathTests</c> boots a real
|
||||
/// host and <c>Identify</c>-probes both paths.
|
||||
/// Still declared once, here, rather than as literals at each spawn site — a shared constant
|
||||
/// costs nothing and keeps the name an operator sees in a log or an <c>ActorSelection</c>
|
||||
/// attached to one declaration. The registry key, not this string, is what a mis-rename
|
||||
/// would break, and that failure is a compile error rather than a silent drop.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// <c>MeshCommActorPathTests</c> boots a real host and <c>Identify</c>-probes
|
||||
/// <c>/user/{name}</c> on both nodes, which is what pins these values against the two
|
||||
/// registration sites.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
public static class MeshPaths
|
||||
{
|
||||
/// <summary>Central-side comm actor — where a driver node sends its deployment acks.</summary>
|
||||
public const string CentralCommunication = "/user/central-communication";
|
||||
|
||||
/// <summary>Node-side comm actor — where central sends commands.</summary>
|
||||
public const string NodeCommunication = "/user/node-communication";
|
||||
|
||||
/// <summary>Actor name of <see cref="CentralCommunication"/> (the path's final segment).</summary>
|
||||
/// <summary>
|
||||
/// Actor name of the central-side comm actor — where an inbound deployment ack is handed
|
||||
/// over, after <c>CentralCommandService</c> has resolved it by registry key.
|
||||
/// </summary>
|
||||
public const string CentralCommunicationName = "central-communication";
|
||||
|
||||
/// <summary>Actor name of <see cref="NodeCommunication"/> (the path's final segment).</summary>
|
||||
/// <summary>
|
||||
/// Actor name of the node-side comm actor — where an inbound command is handed over, after
|
||||
/// <c>NodeCommandService</c> has resolved it by registry key.
|
||||
/// </summary>
|
||||
public const string NodeCommunicationName = "node-communication";
|
||||
}
|
||||
|
||||
@@ -8,9 +8,11 @@ using ZB.MOM.WW.OtOpcUa.Commons.OpcUa;
|
||||
namespace ZB.MOM.WW.OtOpcUa.Runtime.Communication;
|
||||
|
||||
/// <summary>
|
||||
/// Node-side end of the central↔node command boundary (per-cluster mesh Phase 2), living at
|
||||
/// <see cref="MeshPaths.NodeCommunication"/> — the path this node's <c>NodeCommandService</c>
|
||||
/// gRPC ingress hands every decoded command to.
|
||||
/// Node-side end of the central↔node command boundary (per-cluster mesh Phase 2). This node's
|
||||
/// <c>NodeCommandService</c> gRPC ingress hands it every decoded command, resolving it from
|
||||
/// <c>ActorRegistry</c> by <c>NodeCommunicationActorKey</c> — the actor's name
|
||||
/// (<see cref="MeshPaths.NodeCommunicationName"/>) is a local convention, not an address anything
|
||||
/// off-process uses.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
|
||||
Reference in New Issue
Block a user