Merge #868 third review fixes: truncated failure reasons, poison ack writes counted, bounded deadline deferral, cache-booted revision unconfirmed

Claude-Session: https://claude.ai/code/session_01GT67AD99zQQqpLCVm3p7xk
This commit is contained in:
Joseph Doherty
2026-11-11 13:14:17 -05:00
8 changed files with 378 additions and 24 deletions
+12 -2
View File
@@ -679,8 +679,18 @@ deployment green fleet-wide. Now:
**That row stays `Applying` until the outcome is known** (lmxopcua#868): it used to be written `Applied`/clean
the moment the revision advanced, and `ConfigPublishCoordinator`'s recovery counts any non-`Applying` row as
an ack, so a coordinator restart inside the ~105 s outcome window sealed the deployment clean while the node
was about to report degraded. `/fleet` therefore shows the node *Applying* until its outcome lands; a restart
of the node in that window replays the orphan `Applying` row (re-applies) instead of restoring it.
was about to report degraded. `/fleet` therefore shows the node *Applying* until its outcome lands.
A restart of the node inside that window depends on how it boots:
- a `Direct` node that can read the ConfigDb finds the orphan `Applying` row and **replays** the apply, which
acks the real outcome;
- a node that boots **from its LocalDb cache** (every `FetchAndCache` driver-only node, or a `Direct` node
whose ConfigDb is unreachable) restores the cached revision — the cache is written before the outcome — and
sends **no ack**, so central times that deployment out even though the node runs it. The restored revision
is marked *unconfirmed*, so **re-deploying it re-applies** and acks the real outcome rather than
short-circuiting a clean `Applied`.
- **Upgrade note (lmxopcua#868): do not deploy while the central pair is mid rolling-upgrade across this
change.** An old-build fused central node still writes its own row `Applied` before the outcome, which a
new-build coordinator's recovery would count as a clean ack. Finish upgrading both central nodes, then deploy.
- **Mixed-version fleets.** An old node never sets the flag, so its acks are treated exactly as before
(clean). A new node acking an old central: the old coordinator ignores the unknown field and seals as it
always did — no worse than today.