From c904472af2235709d8b8b580ddd9e709f1b432ae Mon Sep 17 00:00:00 2001
From: Joseph Doherty <dohejw01@gmail.com>
Date: Mon, 9 Nov 2026 13:34:45 -0500
Subject: [PATCH] build: ratchet warnings to errors for every project via
 Directory.Build.props; refresh stale comment (lmxopcua#766)

Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
---
 Directory.Build.props | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 34733807..f2ceb237 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -2,16 +2,18 @@
   <!--
     Defaults inherited by every csproj. Individual projects may override.
 
-    TreatWarningsAsErrors is NOT set globally because test projects carry analyzer warnings
-    (e.g. xUnit1051) that would fail the build. src/ projects opt in to
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors> in their own csproj — all 61 do as of #606.
-    It stays per-project rather than global only because the test projects are not yet clean.
+    TreatWarningsAsErrors is ON for every project, src/ and tests alike (#766 ratchet). The solution builds with
+    0 warnings since #725 (xUnit1051 etc. cleaned), so any new warning, including analyzer ones, now fails the
+    build instead of accumulating. The 61 src/ projects also still set it in their own csproj (#606); that is
+    redundant but harmless. A project that genuinely needs an exception should suppress the specific warning
+    via NoWarn, not turn this off.
   -->
   <PropertyGroup>
     <TargetFramework>net10.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>latest</LangVersion>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <!--