Close all four stability-review 2026-04-13 findings so a failed runtime probe subscription can no longer leave a phantom entry that Tick() flips to Stopped and fans out false BadOutOfService quality across a host's subtree, a silently-failed dashboard bind no longer lets the service advertise a successful start while an operator-visible endpoint is dead, the seven sync-over-async sites in LmxNodeManager (rebuild probe sync, Read, Write, four HistoryRead overrides) can no longer park the OPC UA stack thread indefinitely on a hung backend, and alarm auto-subscribe + transferred-subscription restore no longer race shutdown as untracked fire-and-forget tasks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-14 00:48:07 -04:00
parent 731092595f
commit c76ab8fdee
21 changed files with 869 additions and 53 deletions
--- a/tests/ZB.MOM.WW.LmxOpcUa.Tests/Wiring/OpcUaServiceDashboardFailureTests.cs
+++ b/tests/ZB.MOM.WW.LmxOpcUa.Tests/Wiring/OpcUaServiceDashboardFailureTests.cs
@@ -0,0 +1,78 @@
+using System;
+using System.Collections.Generic;
+using System.Net;
+using Shouldly;
+using Xunit;
+using ZB.MOM.WW.LmxOpcUa.Host;
+using ZB.MOM.WW.LmxOpcUa.Host.Configuration;
+using ZB.MOM.WW.LmxOpcUa.Host.Domain;
+using ZB.MOM.WW.LmxOpcUa.Tests.Helpers;
+
+namespace ZB.MOM.WW.LmxOpcUa.Tests.Wiring
+{
+    /// <summary>
+    ///     Regression for stability review 2026-04-13 Finding 2. Confirms that when the dashboard
+    ///     port is already bound, the service continues to start (degraded mode) and the
+    ///     <see cref="OpcUaService.DashboardStartFailed"/> flag is raised.
+    /// </summary>
+    public class OpcUaServiceDashboardFailureTests
+    {
+        [Fact]
+        public void Start_DashboardPortInUse_ContinuesInDegradedMode()
+        {
+            var dashboardPort = new Random().Next(19500, 19999);
+            using var blocker = new HttpListener();
+            blocker.Prefixes.Add($"http://localhost:{dashboardPort}/");
+            blocker.Start();
+
+            var config = new AppConfiguration
+            {
+                OpcUa = new OpcUaConfiguration
+                {
+                    Port = 14842,
+                    GalaxyName = "TestGalaxy",
+                    EndpointPath = "/LmxOpcUa"
+                },
+                MxAccess = new MxAccessConfiguration { ClientName = "Test" },
+                GalaxyRepository = new GalaxyRepositoryConfiguration(),
+                Dashboard = new DashboardConfiguration { Enabled = true, Port = dashboardPort }
+            };
+
+            var proxy = new FakeMxProxy();
+            var repo = new FakeGalaxyRepository
+            {
+                Hierarchy = new List<GalaxyObjectInfo>
+                {
+                    new()
+                    {
+                        GobjectId = 1, TagName = "TestObj", BrowseName = "TestObj",
+                        ParentGobjectId = 0, IsArea = false
+                    }
+                },
+                Attributes = new List<GalaxyAttributeInfo>
+                {
+                    new()
+                    {
+                        GobjectId = 1, TagName = "TestObj", AttributeName = "TestAttr",
+                        FullTagReference = "TestObj.TestAttr", MxDataType = 5, IsArray = false
+                    }
+                }
+            };
+
+            var service = new OpcUaService(config, proxy, repo);
+            service.Start();
+
+            try
+            {
+                // Service continues despite dashboard bind failure — degraded mode policy.
+                service.ServerHost.ShouldNotBeNull();
+                service.DashboardStartFailed.ShouldBeTrue();
+                service.StatusWeb.ShouldBeNull();
+            }
+            finally
+            {
+                service.Stop();
+            }
+        }
+    }
+}