fix(historian): ContinuousHistorization CommitMode code default is PerEntry, matching appsettings/docker-dev/fallback (lmxopcua#776)
v2-ci / unit-tests (push) Has been cancelled
v2-ci / unit-tests (push) Has been cancelled
The Lane H2 remediation made Periodic(100 ms) the options-class default, but appsettings.json, docker-dev and Program.cs's bad-value fallback all used PerEntry, so effective behaviour never changed and the docs contradicted the shipped config. The options default is now PerEntry; Periodic stays opt-in (<= CommitIntervalMs of crash loss in exchange for throughput). Program.cs now uses ContinuousHistorizationOptions.ResolveCommitMode() so the fallback shares the single DefaultCommitMode constant. docs/Historian.md updated. Claude-Session: https://claude.ai/code/session_01GT67AEHd2Acv1YPwGfXEoV
This commit is contained in:
@@ -315,10 +315,7 @@ if (hasDriver)
|
||||
// outbox depth/dropped gauges here (once, on first resolution) keeps the live instance behind them.
|
||||
builder.Services.AddSingleton<IHistorizationOutbox>(_ =>
|
||||
{
|
||||
var commitMode = Enum.TryParse<HistorizationCommitMode>(
|
||||
continuousHistorizationOptions.CommitMode, ignoreCase: true, out var parsedMode)
|
||||
? parsedMode
|
||||
: HistorizationCommitMode.PerEntry;
|
||||
var commitMode = continuousHistorizationOptions.ResolveCommitMode();
|
||||
var outbox = new FasterLogHistorizationOutbox(
|
||||
continuousHistorizationOptions.OutboxPath,
|
||||
commitMode,
|
||||
|
||||
Reference in New Issue
Block a user