dohertj2/lmxopcua
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(adminui): case-insensitive resilience policy keys + malformed-json test (review)

Browse Source
This commit is contained in:
Joseph Doherty
2026-05-29 09:10:41 -04:00
parent a2761e4b98
commit c3fec1426c
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Server/ZB.MOM.WW.OtOpcUa.AdminUI/Components/Shared/Drivers/ResilienceFormModel.cs
+1 -1
View File
@@ -20,7 +20,7 @@ public sealed class ResilienceFormModel
// capability name -> (timeout, retry, breaker), each nullable. // capability name -> (timeout, retry, breaker), each nullable.
public Dictionary<string, CapabilityRow> Policies { get; set; } = public Dictionary<string, CapabilityRow> Policies { get; set; } =
Capabilities.ToDictionary(c => c, _ => new CapabilityRow()); Capabilities.ToDictionary(c => c, _ => new CapabilityRow(), StringComparer.OrdinalIgnoreCase);
public sealed class CapabilityRow public sealed class CapabilityRow
{ {
tests/Server/ZB.MOM.WW.OtOpcUa.AdminUI.Tests/ResilienceFormModelTests.cs
+8
View File
@@ -26,6 +26,14 @@ public class ResilienceFormModelTests
back.Policies["Write"].IsEmpty.ShouldBeTrue(); back.Policies["Write"].IsEmpty.ShouldBeTrue();
} }
[Fact]
public void Malformed_json_yields_empty_model()
{
var m = ResilienceFormModel.FromJson("{ not valid json");
m.BulkheadMaxConcurrent.ShouldBeNull();
m.Policies["Read"].IsEmpty.ShouldBeTrue();
}
[Fact] [Fact]
public void Emitted_json_is_consumable_by_the_runtime_parser() public void Emitted_json_is_consumable_by_the_runtime_parser()
{ {