docs(raw): close the #468 follow-up — raw modals now feed pickers live merged config
Records the outcome in the design doc §6 (including the stale-open race the review found and fixed in both modals), closes the follow-up in the tracking doc and the universal-browser plan, and registers RawBrowseModal's shared race shape in deferment.md §0.1 as the deliberate leftover.
This commit is contained in:
@@ -1154,11 +1154,14 @@ neither agreed with a controller. Fixed, with the layout now pinned by a capture
|
||||
### Follow-ups discovered during the first gate
|
||||
|
||||
1. ~~**Full tree-render verification is fixture-blocked.**~~ **CLOSED** by the second gate above.
|
||||
2. **Driver-page address pickers pass no live config.** `AbCipDriverPage`/`TwinCATDriverPage`/`FOCASDriverPage`
|
||||
host the same `*AddressPickerBody` but do **not** pass `DriverType`/`GetConfigJson`, so their (now-visible)
|
||||
Browse button would capture against `"{}"` (no device). Out of Task 14's scope (which listed only the
|
||||
TagEditor pass-through); wire the live form config through there too, or hide the Browse affordance on the
|
||||
driver-config picker.
|
||||
2. ~~**Driver-page address pickers pass no live config.**~~ — **CLOSED 2026-08-05.** The named
|
||||
`*DriverPage` shells were deleted by v3 Batch 2 before this was ever actioned, but the defect
|
||||
pattern survived into the v3 tag-editor hosts (`RawTagModal` / `RawManualTagEntryModal`, both
|
||||
passing a `"{}"` stub as `GetDriverConfigJson`). Fixed by resolving the merged Driver+Device
|
||||
config (`IRawTreeService.LoadMergedProbeConfigAsync` — the same blob Test-connect and
|
||||
`RawBrowseModal` dial) once per open and forwarding a live accessor; fail-soft on resolve
|
||||
failure. See `2026-08-05-raw-modal-picker-live-config-design.md` for the design and outcome
|
||||
(including the stale-open race the review found and closed).
|
||||
|
||||
## Out of scope (explicitly)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user