fix(scripting): explicit companion logger + disposable ScriptRootLogger (T2 review)

This commit is contained in:
Joseph Doherty
2026-06-10 11:56:51 -04:00
parent 73014258ef
commit bf86b3def6
3 changed files with 26 additions and 11 deletions
@@ -27,12 +27,19 @@ public static class ScriptRootLoggerFactory
/// Minimum level for events forwarded to the <c>script-logs</c> topic; lower-level events
/// still land in the file sink but are not pushed onto the cluster bus.
/// </param>
/// <param name="companionLogger">
/// The application's main logger that receives mirrored Error-or-higher script events at
/// Warning level. Passed explicitly so callers control the source rather than reading the
/// global <see cref="Serilog.Log.Logger"/> static inside the factory.
/// </param>
/// <returns>The composed root script logger.</returns>
public static Serilog.ILogger Build(IScriptLogPublisher publisher, string filePath, LogEventLevel topicMinLevel)
public static Serilog.Core.Logger Build(
IScriptLogPublisher publisher, string filePath, LogEventLevel topicMinLevel,
Serilog.ILogger companionLogger)
=> new LoggerConfiguration()
.MinimumLevel.Verbose()
.WriteTo.File(filePath, rollingInterval: RollingInterval.Day)
.WriteTo.Sink(new ScriptLogCompanionSink(Serilog.Log.Logger))
.WriteTo.Sink(new ScriptLogCompanionSink(companionLogger))
.WriteTo.Sink(new ScriptLogTopicSink(publisher, topicMinLevel))
.CreateLogger();
}
+1 -1
View File
@@ -131,7 +131,7 @@ if (hasDriver)
new DpsScriptLogPublisher(() => sp.GetRequiredService<ActorSystem>()));
builder.Services.AddSingleton(sp => new ScriptRootLogger(
ScriptRootLoggerFactory.Build(
sp.GetRequiredService<IScriptLogPublisher>(), scriptLogFilePath, scriptLogTopicMinLevel)));
sp.GetRequiredService<IScriptLogPublisher>(), scriptLogFilePath, scriptLogTopicMinLevel, Serilog.Log.Logger)));
builder.Services.AddValidatedOptions<LdapOptions, LdapOptionsValidator>(builder.Configuration, LdapOptions.SectionName);
// TryAdd so a fused admin+driver node (where AddOtOpcUaAuth also registers these) ends up